From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 35B11F960 for ; Wed, 18 Jan 2017 11:46:27 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id r144so18660897wme.1 for ; Wed, 18 Jan 2017 02:46:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=lGAJimiSVMUB+Z5/P9SBGBSOv61Uqr4HyfuZm+aMNRc=; b=kWPsU71Zz8COmg63tqsYjYtRq4AXpYd1ubKNT0NqVEs7asnyq8MBSEdgRSILXdvswQ jpmwROvxc9kRDFD3TcvGo+Uq124iao+9loH8b1EQd2doKv4HI48SYs6bKdiveep0wj53 mLp+kj/5zcCWl0IO/KW4LbnjoepZaC+NU1517sjrjAMF3ZCi1wRq37ftHfggAdk2iAyA QV1r2vXSmdNi8vViWviJ8e2W6SnYUu2zGS9o32zz0AP+2fdtMkx6VLx7O1FQ5BxmuAlv nziKDwEwBjNS7bJSrNxw2nrByMzoeIUbgY3V2WEmSBLiFuC9Ud0wmlrtMK5tWakegg+S Og2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=lGAJimiSVMUB+Z5/P9SBGBSOv61Uqr4HyfuZm+aMNRc=; b=NdcAzEROaWRHuDBhe09Cqv2rMyl8eEFzAzU4LiaSbpWdAEfAINbw/EHbV5cniweF9W 1zlqZDL6bCfLZyBt34BNwJ3ROj0olI1Mm9wCg5cllBeaqAE8GoOlMKr2w1Yy4YH5aDxA 79t1u1oNUpSWYZqmB1Ed84ypL3F8l1AGQNRwH1ifZ62jRGpEss+DiUdJFjOw8PZh2wKX mNwcyjHCNEUa9APbp3NbXVjUuOwj6NN963sU2xMBi2HueIeYXuE2n2NjLsnYCqtMqJ9A aNWHgnK+ylIzxSHPf2bgcFzcD3o8WXoqsHWXSRTfMhWS2Xl5DPBN8H3SZIWI5hCDeJuy wsZA== X-Gm-Message-State: AIkVDXLSw7sFmTDba2Ug2dpPxaLsm1B2/FGfSdFcKgfCL3N5aQxBSOQeOTfeKSs0pgGAQVIc X-Received: by 10.223.128.77 with SMTP id 71mr2211091wrk.48.1484736386964; Wed, 18 Jan 2017 02:46:26 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id c81sm3910633wmf.22.2017.01.18.02.46.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jan 2017 02:46:26 -0800 (PST) From: Thomas Monjalon To: Shreyansh Jain Cc: dev@dpdk.org Date: Wed, 18 Jan 2017 11:46:25 +0100 Message-ID: <2101696.X900yayxyx@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1484735880-17178-2-git-send-email-shreyansh.jain@nxp.com> References: <1484660264-6531-1-git-send-email-shreyansh.jain@nxp.com> <1484735880-17178-1-git-send-email-shreyansh.jain@nxp.com> <1484735880-17178-2-git-send-email-shreyansh.jain@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v9 01/12] eal/bus: introduce bus abstraction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 10:46:27 -0000 2017-01-18 16:07, Shreyansh Jain: > +void > +rte_bus_register(struct rte_bus *bus) > +{ > + RTE_VERIFY(bus); > + RTE_VERIFY(bus->name && strlen(bus->name)); > + > + TAILQ_INSERT_TAIL(&rte_bus_list, bus, next); > + RTE_LOG(DEBUG, EAL, "Registered [%s] bus.\n", bus->name); > +} > + > +void > +rte_bus_unregister(struct rte_bus *bus) > +{ > + TAILQ_REMOVE(&rte_bus_list, bus, next); > + RTE_LOG(INFO, EAL, "Unregistered [%s] bus.\n", bus->name); > +} This log should be DEBUG, consistently with "register" one. > +DPDK_17.02 { > + global: > + > + rte_bus_list; So finally, is it an useful symbol? Could it be removed from this patch?