From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C68F43A1A; Wed, 31 Jan 2024 10:49:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FB3E402C5; Wed, 31 Jan 2024 10:49:26 +0100 (CET) Received: from fout1-smtp.messagingengine.com (fout1-smtp.messagingengine.com [103.168.172.144]) by mails.dpdk.org (Postfix) with ESMTP id EDEBD402A1; Wed, 31 Jan 2024 10:49:24 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id 5619A1380088; Wed, 31 Jan 2024 04:49:24 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 31 Jan 2024 04:49:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1706694564; x=1706780964; bh=stYzdbGBDwhT7JYMil1Xp/I6ZJ6mpGjaFaryIGyrAjg=; b= XRgWO6NCGUgD6iNZz5aTx9PQva6GZa/IbJgwxSApZh8r4ZZNDOHaPzhpUTMr3k5P eDvQtc1ahJjHb3NKAxb+Ffh/Umc5gGKLq/1ToTKfD8VeTTOISvxgWFFsJ+21LFk9 aGfK87F+0NBtxbNGpTjmofq+uxQBi4MMedRrzugBzExKUCds9+MnuXdrPw7JlK65 TeqePpV+x1jZrr2HcINs/poQZcghOBj4wr4/DY3lBoU/NSNNfHCQ1wLerwWvGvVo 9WZjvdyMnP9M878ZsNdeD2Nt+4YPtsxJMIXb2YlZooSMpVRJvZFl9WNxyHTyjEFl rGofOJedW7uk8w+2XrsAxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706694564; x= 1706780964; bh=stYzdbGBDwhT7JYMil1Xp/I6ZJ6mpGjaFaryIGyrAjg=; b=y QtLrl91AdeL2dv0Fq1d3tqm6ToTkoDAiXUvfTBb9eqml8i+eURKVco6gsYC6TqOH SL8WkWUcvWS8FLy18ytN9afrbXah1jQyhb2LN8SdZKPJnYGyo1qveDqdrlVwnAzL ZJ64W05J6Ti8+Asu/v9+GZUv2ZQsKqkVUVlbRtoch28RcoujDwGxiVeQ8xNRkiLE qWqOcmov97eaXVk917OJCwfxMrwEzYYAzEut0Qw37OTi4AqsZ+njPfx8F1xBblUE GSdbrPvQXZKa/bm1vaI90Xdo5TSlsttRAoAfeZ4HH4HMLAmOV8QamFqxhgfwKQ1d d9BM+gfzExiLUETC9APeQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedtledgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 31 Jan 2024 04:49:23 -0500 (EST) From: Thomas Monjalon To: "Richardson, Bruce" Cc: "dev@dpdk.org" , "Gao, DaxueX" , stable@dpdk.org Subject: Re: [PATCH] kernel/freebsd: fix module build on FreeBSD 14 Date: Wed, 31 Jan 2024 10:49:21 +0100 Message-ID: <2103024.K71DO8KEF6@thomas> In-Reply-To: References: <20231219112959.10440-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > When building nic_uio module on FreeBSD 14, a build error is given in the > > DRIVER_MODULE macro: > > > > .../nic_uio.c:84:81: error: too many arguments provided to function-like > > macro invocation DRIVER_MODULE(nic_uio, pci, nic_uio_driver, > > nic_uio_devclass, nic_uio_modevent, 0); > > ^ On FreeBSD 14, the devclass > > parameter is dropped from the macro, so we conditionally compile a different > > invocation for BSD versions before/ after v14. > > > > Bugzilla Id: 1335 Id -> ID > > > > Signed-off-by: Bruce Richardson > Tested-by: Daxue Gao +Cc: stable@dpdk.org Applied, thanks.