From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43C7BA0597; Wed, 8 Apr 2020 20:03:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEA901C1C2; Wed, 8 Apr 2020 20:03:32 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 427721C1BD for ; Wed, 8 Apr 2020 20:03:31 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 97CCF5C0273; Wed, 8 Apr 2020 14:03:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 08 Apr 2020 14:03:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=tu0b8RlkqLXaXCBS2O+qO4G0fFnNEMweOU/26KPToHc=; b=H92kLqSQdKDs yjWbDuI//8sIjLkcKXf86UiYgQ8khDS9tYdSc+VNUuLg8wt1FUP2Vce5aUyhtOzS bHUN9USkdO7rNbD2a9wXOcBmn9DYysjL9fWw8gYZJz0VMuAm+D7LnDUR+urzZVEg y6DVcK/Y4OGl9UiNCMo9qMAcsBH1ZJk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=tu0b8RlkqLXaXCBS2O+qO4G0fFnNEMweOU/26KPTo Hc=; b=21yU/A1PRzUM1cg4gdpCicCSakChlUaTfy4rTm7LOj7a2B88T+YLBLX/5 KncxiDCIF39hAoEpbymwFqHbHLzQZPbUcg86eln/naX4KC0AudV0SPtb6qqU/tob qj+DcJxzOmLNzQAImDkyU+cvAM1mX/hd4+73NqyXzKOIp5/UiUdiapP2U3m0fYVD dXgLlZDuQ/T9QGvJEMJCwSPYlurj89cG6qtCYuIpKbDT7LghNIbj29XN4qRA6YYa 6YWGZW04TBnRsBb4nqBP+NGICnlB3k5rrZymW1iSiDu4bFes+YLZ+qsOfZ3aBZUw FvOI8TnMBd5RIebODoUa9ceT12tEw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejgdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrddvtdefrddukeegnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrg hssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 185BA3280059; Wed, 8 Apr 2020 14:03:27 -0400 (EDT) From: Thomas Monjalon To: Ciara Power Cc: dev@dpdk.org, kevin.laatz@intel.com, reshma.pattan@intel.com, jerinjacobk@gmail.com, david.marchand@redhat.com, keith.wiles@intel.com, mb@smartsharesystems.com, bruce.richardson@intel.com Date: Wed, 08 Apr 2020 20:03:26 +0200 Message-ID: <2104953.NgBsaNRSFp@thomas> In-Reply-To: <20200408164956.47864-1-ciara.power@intel.com> References: <20200319171907.60891-1-ciara.power@intel.com> <20200408164956.47864-1-ciara.power@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 00/16] update and simplify telemetry library. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/04/2020 18:49, Ciara Power: > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. > > This work is based on the previously sent RFC for a "process info" > library: https://patchwork.dpdk.org/project/dpdk/list/?series=7741 > However, rather than creating a new library, this patchset takes > that work and merges it into the existing telemetry library, as > mentioned above. > > The telemetry library as shipped in 19.11 is based upon the metrics > library and outputs all statistics based on that as a source. However, > this limits the telemetry output to only port-level statistics > information, rather than allowing it to be used as a general scheme for > telemetry information across all DPDK libraries. > > With this patchset applied, rather than the telemetry library being > responsible for pulling ethdev stats and pushing them into the metrics > library for retrieval later, each library e.g. ethdev, rawdev, and even > the metrics library itself (for backwards compatiblity) now handle their > own stats. Any library or app can register a callback function with > telemetry, which will be called if requested by the client connected via > the telemetry socket. The callback function in the library/app then > formats its stats, or other data, into a JSON string, and returns it to > telemetry to be sent to the client. I think this is a global need in DPDK, and it is usually called RPC, IPC or control messaging. We had a similar need for multi-process communication, thus rte_mp IPC. We also need a control channel for user configuration applications. We also need to control some features like logging or tracing. In my opinion, it is time to introduce a general control channel in DPDK. The application must be in the loop of the control mechanism. Making such channel standard will ease application adoption. Please read some comments here: http://inbox.dpdk.org/dev/2580933.jp2sp48Hzj@xps/