From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6E6F91B518; Mon, 7 Jan 2019 18:45:14 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E494322EC5; Mon, 7 Jan 2019 12:45:13 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 07 Jan 2019 12:45:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=EXB/83ZaMq+M+/2u6lv1OD6p1I31Gb+23AMM+JROyGg=; b=qpBPvwlP+e6W CVdEb0aFhS6N+cAhvR96nXqcuuPNNfMpIGf6IY6HUNIrdzdbvZNXhrhlG51wU2wN dzcZBnX46L9LzivhN20FOmYGBhANSs5Au2Mxm9yvFdRWjFO8LxfPF97HFk+BdsIE hJ0iyJaDJQKgzOMP+OTV4m8dbocL+oI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=EXB/83ZaMq+M+/2u6lv1OD6p1I31Gb+23AMM+JROy Gg=; b=wRkdEecnBIeBhCpvOJoJYVR089QAQZvYvG4Hrw1O1f7eWH2iUYGNio7SX fe26TXRTmfmqDyNochEFCdTPKB9DJpxEZN2x3y82N/aLxx1t3Hx3HhOKexyB1Zn0 1Tj/XKFIL1pwuW8qAaJj8rKBSE6cV4s4rwoLsrphGkEhDcD0iXYJXqdPUekTWfPo m2VbklFgYC6wgCJIT/Esab06BWi9bqpbXf25YSfPBWPy55UqPRVtHeKT0mvki2R1 QSSemuNNSBTJF+aQQcm6aVv4dt9hTjqf6aOITWWbktlqYF1jxyYM1g6iPvGjffcz x6zbKIlgj3fzSm5mFQt4bs6jEBeXg== X-ME-Sender: <xms:KZAzXBhyhCcBa3_xUT3DLhLobIlmtUimRVteCR-zkqPZoCYkDu_R5Q> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrvdejgddutddvucdltddurdegtdekrddttd dmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhht necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ffohhmrghinhepghhithhhuhgsrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudek geenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnh gvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:KZAzXEchyaMaKROFCm1qNAuCHx5sDnFe8ijTzBsNJgshrVwSi6vmoA> <xmx:KZAzXD2AsswI8UQB_bCCCsJl-jM26breduvlRlXsnXpoiBATomB07g> <xmx:KZAzXLEt6vzgeNsMMsZPZM9bLKux5mYdugpF0x8ntromszfFURVYTA> <xmx:KZAzXMxNCOjv7_0df0aLy-bJLzwfNBTIFcuRsa8jWNlCq61Uk0dTfw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8F885100BB; Mon, 7 Jan 2019 12:45:12 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com>, Luca Boccassi <bluca@debian.org> Cc: stable@dpdk.org, techboard@dpdk.org, dev@dpdk.org Date: Mon, 07 Jan 2019 18:45:11 +0100 Message-ID: <2105533.CpohIH1hI0@xps> In-Reply-To: <4262310.sn7WroDi98@xps> References: <20190103175725.5836-1-bluca@debian.org> <20190107165552.GA23828@bricha3-MOBL.ger.corp.intel.com> <4262310.sn7WroDi98@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [dpdk-techboard] [PATCH 2/2] build: use dependency() instead of find_library() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 07 Jan 2019 17:45:14 -0000 07/01/2019 18:03, Thomas Monjalon: > 07/01/2019 17:55, Bruce Richardson: > > On Mon, Jan 07, 2019 at 04:39:34PM +0000, Luca Boccassi wrote: > > > On Mon, 2019-01-07 at 14:28 +0000, Bruce Richardson wrote: > > > > However, in > > > > conjunction with meson version checks, I believe this was done this > > > > way > > > > originally because of a meson bug which caused recursive dependencies > > > > for > > > > things like this to get duplicated many times in the build.ninja > > > > file. > > > > > > > > https://github.com/mesonbuild/meson/issues/2150 > > > > > > > > If we take the approach of adding bsd explicitly using dependency > > > > object > > > > our minimum version needs to have the fix for this bug included. > > > > > > Ah that's not nice. Just verified, and it happens with dependency() as > > > well as find_library(). It was fixed in 0.47.1. > > > > > > > Yep, it was a right royal pain when I was doing the original work. Now that > > there is a fix in, we can do cleanups like you suggest if we are prepared > > to bump our minimum version. > > > > I'll refer back to the key question here: > > "Is it reasonable to ask users compiling DPDK to pull meson from pip rather > > than using the distro built-in version?" > > [Adding techboard on CC, in the hopes they might have some thoughts] > > > > If it is ok for most folks, and personally I don't think it's a big deal, > > then that gives us a faster path forward. If not, we raise the minimum more > > slowly, and keep the existing way of managing the dependencies for a while > > longer. Worst case, I'd still hope by 19.11 LTS for us to have minimum > > 0.47.1 to have the fix in question. > > Please, could you describe what are the meson versions in major distros? It was already listed by Luca in this thread (thanks Bruce). I looks like latest Debian/Ubuntu and Fedora have meson 0.47 or higher. I vote for bumping to meson 0.47.