* [dpdk-dev] [PATCH] fm10k: remove useless code
@ 2015-07-16 22:05 Stephen Hemminger
2015-07-21 7:19 ` Chen, Jing D
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2015-07-16 22:05 UTC (permalink / raw)
To: Jing Chen; +Cc: dev
The return in fm10k_dev_handle_fault has useless conditional
since it always returns 0 here.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/fm10k/fm10k_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c
index 902ccae..493b6f9 100644
--- a/drivers/net/fm10k/fm10k_ethdev.c
+++ b/drivers/net/fm10k/fm10k_ethdev.c
@@ -1793,8 +1793,6 @@ fm10k_dev_handle_fault(struct fm10k_hw *hw, uint32_t eicr)
fault.address, fault.specinfo);
}
- if (estr)
- return 0;
return 0;
error:
PMD_INIT_LOG(ERR, "Failed to handle fault event.");
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: remove useless code
2015-07-16 22:05 [dpdk-dev] [PATCH] fm10k: remove useless code Stephen Hemminger
@ 2015-07-21 7:19 ` Chen, Jing D
2015-07-22 10:44 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Chen, Jing D @ 2015-07-21 7:19 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, July 17, 2015 6:05 AM
> To: Chen, Jing D
> Cc: dev@dpdk.org; Stephen Hemminger
> Subject: [PATCH] fm10k: remove useless code
>
> The return in fm10k_dev_handle_fault has useless conditional
> since it always returns 0 here.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Jing Chen <jing.d.chen@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] fm10k: remove useless code
2015-07-21 7:19 ` Chen, Jing D
@ 2015-07-22 10:44 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-07-22 10:44 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev
> > The return in fm10k_dev_handle_fault has useless conditional
> > since it always returns 0 here.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Acked-by: Jing Chen <jing.d.chen@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-22 10:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-16 22:05 [dpdk-dev] [PATCH] fm10k: remove useless code Stephen Hemminger
2015-07-21 7:19 ` Chen, Jing D
2015-07-22 10:44 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).