From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EC76B1B05; Thu, 28 Mar 2019 23:50:31 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8C2A821FC1; Thu, 28 Mar 2019 18:50:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 18:50:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=7az3yEMMJIueOaEoWyxK27OlYu9R+qbvXjj6MuOfaus=; b=D1HCNkd9Mr4L X+Pz3i5ZJwteHmbEM5Dh59DrcRYRv3n/XwKewrAxfHvVwQOtDVSzBvR2FgYkLBsY QIfl9m5fhvglmHbKV1dCAQlwtuM98j+ZOdx7OqNOp79TcpJEHmOuaTjfj3B3Olpe G0GWU8d1/igOA66qkPG4FmqI0Y7eFfI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=7az3yEMMJIueOaEoWyxK27OlYu9R+qbvXjj6MuOfa us=; b=WeKl3gPyxXWgAaZHyCrRDqjditlIsS8GIrsmDdMTz2ZZJfOEOWQdomLLh EvIjVUV1aizAWn7TIHAxKyfgeaUMem5VPYaKImeB7KGMJosBXge1Rn3pmFSXL0Zh fLPW+mwbUSyB47Zyk50YxFW87ed+2g4B353K/eAS9ti+IiLrD7sya2qURzCsTNjg Oxo6Toat+0EbQtIhK/xej5fdiO5JqZq5eu2MhiYb/PQbowZwYqb+s4bcx4GQ7qRg nkUK5ZLfTeMdeq583TYUW1+VkA4qdIdkT3TLGufjNje4q1XATlxijroMwMzPXNHv M40Q04jbzstMSfvD2FExU2+p12gTg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggdduieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehisghmrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9752210310; Thu, 28 Mar 2019 18:50:29 -0400 (EDT) From: Thomas Monjalon To: Dekel Peled Cc: stable@dpdk.org, chaozhu@linux.vnet.ibm.com, yskoh@mellanox.com, shahafs@mellanox.com, dev@dpdk.org, orika@mellanox.com, pradeep@us.ibm.com, David Christensen Date: Thu, 28 Mar 2019 23:50:28 +0100 Message-ID: <2107406.dfrop5AP8K@xps> In-Reply-To: <1552913893-43407-1-git-send-email-dekelp@mellanox.com> References: <1552913893-43407-1-git-send-email-dekelp@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Mar 2019 22:50:32 -0000 18/03/2019 13:58, Dekel Peled: > From previous patch description: "to improve performance on PPC64, > use light weight sync instruction instead of sync instruction." > > Excerpt from IBM doc [1], section "Memory barrier instructions": > "The second form of the sync instruction is light-weight sync, > or lwsync. > This form is used to control ordering for storage accesses to system > memory only. It does not create a memory barrier for accesses to > device memory." > > This patch removes the use of lwsync, so calls to rte_wmb() and > rte_rmb() will provide correct memory barrier to ensure order of > accesses to system memory and device memory. > > [1] https://www.ibm.com/developerworks/systems/articles/powerpc.html > > Fixes: d23a6bd04d72 ("eal/ppc: fix memory barrier for IBM POWER") > Cc: stable@dpdk.org > > Signed-off-by: Dekel Peled Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 85498A0679 for ; Thu, 28 Mar 2019 23:50:35 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BEF072C54; Thu, 28 Mar 2019 23:50:33 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id EC76B1B05; Thu, 28 Mar 2019 23:50:31 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8C2A821FC1; Thu, 28 Mar 2019 18:50:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 28 Mar 2019 18:50:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=7az3yEMMJIueOaEoWyxK27OlYu9R+qbvXjj6MuOfaus=; b=D1HCNkd9Mr4L X+Pz3i5ZJwteHmbEM5Dh59DrcRYRv3n/XwKewrAxfHvVwQOtDVSzBvR2FgYkLBsY QIfl9m5fhvglmHbKV1dCAQlwtuM98j+ZOdx7OqNOp79TcpJEHmOuaTjfj3B3Olpe G0GWU8d1/igOA66qkPG4FmqI0Y7eFfI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=7az3yEMMJIueOaEoWyxK27OlYu9R+qbvXjj6MuOfa us=; b=WeKl3gPyxXWgAaZHyCrRDqjditlIsS8GIrsmDdMTz2ZZJfOEOWQdomLLh EvIjVUV1aizAWn7TIHAxKyfgeaUMem5VPYaKImeB7KGMJosBXge1Rn3pmFSXL0Zh fLPW+mwbUSyB47Zyk50YxFW87ed+2g4B353K/eAS9ti+IiLrD7sya2qURzCsTNjg Oxo6Toat+0EbQtIhK/xej5fdiO5JqZq5eu2MhiYb/PQbowZwYqb+s4bcx4GQ7qRg nkUK5ZLfTeMdeq583TYUW1+VkA4qdIdkT3TLGufjNje4q1XATlxijroMwMzPXNHv M40Q04jbzstMSfvD2FExU2+p12gTg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkeeggdduieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehisghmrdgtohhmnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 9752210310; Thu, 28 Mar 2019 18:50:29 -0400 (EDT) From: Thomas Monjalon To: Dekel Peled Cc: stable@dpdk.org, chaozhu@linux.vnet.ibm.com, yskoh@mellanox.com, shahafs@mellanox.com, dev@dpdk.org, orika@mellanox.com, pradeep@us.ibm.com, David Christensen Date: Thu, 28 Mar 2019 23:50:28 +0100 Message-ID: <2107406.dfrop5AP8K@xps> In-Reply-To: <1552913893-43407-1-git-send-email-dekelp@mellanox.com> References: <1552913893-43407-1-git-send-email-dekelp@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal/ppc: remove fix of memory barrier for IBM POWER X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190328225028._gbpG4gU7pTYvi-z1T-xVRRNC0yPTycJa42HsHgkYr4@z> 18/03/2019 13:58, Dekel Peled: > From previous patch description: "to improve performance on PPC64, > use light weight sync instruction instead of sync instruction." > > Excerpt from IBM doc [1], section "Memory barrier instructions": > "The second form of the sync instruction is light-weight sync, > or lwsync. > This form is used to control ordering for storage accesses to system > memory only. It does not create a memory barrier for accesses to > device memory." > > This patch removes the use of lwsync, so calls to rte_wmb() and > rte_rmb() will provide correct memory barrier to ensure order of > accesses to system memory and device memory. > > [1] https://www.ibm.com/developerworks/systems/articles/powerpc.html > > Fixes: d23a6bd04d72 ("eal/ppc: fix memory barrier for IBM POWER") > Cc: stable@dpdk.org > > Signed-off-by: Dekel Peled Applied, thanks