From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: maxime.leroy@6wind.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: fix vdev allocation on non-0 numa socket
Date: Wed, 30 Apr 2014 23:16:30 +0200 [thread overview]
Message-ID: <2109617.VLhUbDmGTm@xps13> (raw)
In-Reply-To: <1398863708-31078-1-git-send-email-david.marchand@6wind.com>
> From: Maxime Leroy <maxime.leroy@6wind.com>
>
> vdev ethdev can not be allocated on a numa socket that is not socket 0.
> The reason comes from rte_eth_dev_allocate() which uses rte_socket_id() to
> identify the socket on which vdev driver data should be allocated.
> However, at this initialization step, rte_socket_id() always returns 0.
>
> Looking at rte_socket_id(), it needs rte_lcore_id() which uses the per-core
> global _lcore_id variable. This variable is initialised by
> eal_thread_init_master.
>
> So eal_thread_init_master should be called before rte_eal_vdev_init().
>
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
Applied for version 1.6.0r2.
Thanks
--
Thomas
prev parent reply other threads:[~2014-04-30 21:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 13:15 David Marchand
2014-04-30 21:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2109617.VLhUbDmGTm@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=maxime.leroy@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).