From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 3B354590E for ; Wed, 30 Apr 2014 23:16:28 +0200 (CEST) Received: by mail-wi0-f182.google.com with SMTP id d1so2933879wiv.3 for ; Wed, 30 Apr 2014 14:16:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=h6218vfBKIun7KBqu7aSdq3ozMOitPmyDtAv4SMCPog=; b=OH7ZSilGvU8NZmjUFVSidGrLBZtU9vAiqDxVaCp0VOxzoVMjEtXHQMmbmiR+HIoMad HlxYYfeEnNd20q4V4X4s6okb9fRdjLz6yHzcQKrgBB2Yger8Q0GhQOA+QUnrVDA+BHjM kqQvn6JLR+WHz862FPrlyHwvksqNXqfGUpvuDMALVPDMlO7UCG37QZjUKD8ISdew9pLJ EoKW/xFu++tfAxYkL8cLA7K0a0CXSGBWH5Dwg/homNVXXB5+WWcOrN2vBiVMwOD9B+xJ nveVtGar+FnUPCa9+FLQsz7JkuhbZ/crTTDhvjto319dsKgSsTrlIyaxHvXk7FWHimgm Fgqw== X-Gm-Message-State: ALoCoQm9ly/qXA4AbR+4IM3ZY9PYjXGF7zn69xkoXnhuoaELY2sTeltYr1cLf407keFzMl7LE/Ar X-Received: by 10.194.118.163 with SMTP id kn3mr81962wjb.77.1398892592430; Wed, 30 Apr 2014 14:16:32 -0700 (PDT) Received: from xps13.localnet (abo-213-55-68.mts.modulonet.fr. [85.68.55.213]) by mx.google.com with ESMTPSA id h1sm37953315wjy.7.2014.04.30.14.16.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Apr 2014 14:16:31 -0700 (PDT) From: Thomas Monjalon To: maxime.leroy@6wind.com Date: Wed, 30 Apr 2014 23:16:30 +0200 Message-ID: <2109617.VLhUbDmGTm@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.1-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1398863708-31078-1-git-send-email-david.marchand@6wind.com> References: <1398863708-31078-1-git-send-email-david.marchand@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: fix vdev allocation on non-0 numa socket X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Apr 2014 21:16:28 -0000 > From: Maxime Leroy > > vdev ethdev can not be allocated on a numa socket that is not socket 0. > The reason comes from rte_eth_dev_allocate() which uses rte_socket_id() to > identify the socket on which vdev driver data should be allocated. > However, at this initialization step, rte_socket_id() always returns 0. > > Looking at rte_socket_id(), it needs rte_lcore_id() which uses the per-core > global _lcore_id variable. This variable is initialised by > eal_thread_init_master. > > So eal_thread_init_master should be called before rte_eal_vdev_init(). > > Signed-off-by: Maxime Leroy Acked-by: Thomas Monjalon Applied for version 1.6.0r2. Thanks -- Thomas