DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jijiang Liu <jijiang.liu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 4/4] testpmd:rework csum forward engine
Date: Fri, 28 Nov 2014 11:10:27 +0100	[thread overview]
Message-ID: <2110618.Ag0tEN76Sp@xps13> (raw)
In-Reply-To: <54784562.90906@6wind.com>

2014-11-28 10:50, Olivier MATZ:
> Hi Jijiang,
> 
> On 11/27/2014 06:03 PM, Jijiang Liu wrote:
> > @@ -303,7 +305,7 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype,
> >   * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control
> >   * wether a checksum must be calculated in software or in hardware. The
> >   * IP, UDP, TCP and SCTP flags always concern the inner layer.  The
> > - * VxLAN flag concerns the outer IP and UDP layer (if packet is
> > + * VxLAN flag concerns the outer IP(if packet is
> >   * recognized as a vxlan packet).
> >   */
> 
> Please reindent the comment properly, taking care of the space before
> the parenthesis.
> 
> Another comment that concerns the whole patchset. It's maybe a question
> for Thomas, but I think that having patches that don't break compilation
> between each other would help when bissecting.
> 
> In this case, I wonder if it's possible to split in something like:
> 
> - change PKT_TX_IPV4 and PKT_TX_IPV6 definition
> - add + rename flags (update them in mbuf + testpmd + i40)
> - rename inner_l{23}, l{23} in l{23}, outer_l{23} (update them in mbuf
>   + testpmd + i40)
> 
> I'm not sure it's feasible, I let Thomas give his mind about this.

Exact, compilation must not be broken between patches.
The proposal from Olivier seems OK.

-- 
Thomas

  reply	other threads:[~2014-11-28 10:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-27 17:03 [dpdk-dev] [PATCH v3 0/4] i40e VXLAN TX checksum rework Jijiang Liu
2014-11-27 17:03 ` [dpdk-dev] [PATCH v3 1/4] mbuf:add three TX offload flags and change three fields Jijiang Liu
2014-11-28  9:36   ` Olivier MATZ
2014-11-28 10:27     ` Ananyev, Konstantin
2014-11-28 10:33     ` Liu, Jijiang
2014-11-28 10:40       ` Ananyev, Konstantin
2014-11-28 11:00         ` Olivier MATZ
2014-11-28 11:13           ` Ananyev, Konstantin
2014-11-28 11:18             ` Olivier MATZ
2014-11-28 15:46               ` Ananyev, Konstantin
2014-11-27 17:03 ` [dpdk-dev] [PATCH v3 2/4] mbuf:change PKT_TX_IPV4 and PKT_TX_IPV6 definition Jijiang Liu
2014-11-28  9:37   ` Olivier MATZ
2014-11-27 17:03 ` [dpdk-dev] [PATCH v3 3/4] i40e:PMD change for VXLAN TX checksum Jijiang Liu
2014-11-27 17:03 ` [dpdk-dev] [PATCH v3 4/4] testpmd:rework csum forward engine Jijiang Liu
2014-11-28  9:50   ` Olivier MATZ
2014-11-28 10:10     ` Thomas Monjalon [this message]
2014-11-27 17:24 ` [dpdk-dev] [PATCH v3 0/4] i40e VXLAN TX checksum rework Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2110618.Ag0tEN76Sp@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jijiang.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).