From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id 93E83231C for ; Fri, 28 Nov 2014 11:10:51 +0100 (CET) Received: by mail-wi0-f181.google.com with SMTP id r20so10726240wiv.2 for ; Fri, 28 Nov 2014 02:10:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=tfvQrgE1Mb4BH+ZbtDAXTgchY2Ko8d9BCCPwGZ7Zj1I=; b=fFyq5Rt7rBaY8DgUVFWESlcfvoMqRp9q8bPmGIhM8i6WS5hPLy36Ohq4HBEPQCC6Go sJx+eSrobFY58qd2EWakabXGKEFCm1HCK6uCN6R8Yj3ZtP5ZDcUBrxrafQTW3el44yx+ g1/RMZq+41bcOUz/tb0ttmhc0nk+Diu+HRJw6sABMMvb7hrnBpjpCadCHhrD3NpEumdz 49vcIjrngP+fTXQ9oLzadRVVpjl9yfzsnelNEHqZ3kW6cBb9fGHAipJJLO3r7eoDaurF pV0LAbiUJ3YRQ53jjfXJ6M6DQkLVbBbreNFmG0E6MA+5z1xJf3VQWEaayQMm616TYoF1 ughg== X-Gm-Message-State: ALoCoQkuT2wCJ3fjxU7vX+bUlZFrZjrfBIjDTx7bAvgSXn6DhlS9aDVkrKh7ETux18tuzO9Jzaqw X-Received: by 10.194.92.148 with SMTP id cm20mr68643348wjb.88.1417169451385; Fri, 28 Nov 2014 02:10:51 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id iz19sm28921059wic.8.2014.11.28.02.10.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Nov 2014 02:10:50 -0800 (PST) From: Thomas Monjalon To: Jijiang Liu Date: Fri, 28 Nov 2014 11:10:27 +0100 Message-ID: <2110618.Ag0tEN76Sp@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <54784562.90906@6wind.com> References: <1417107801-9544-1-git-send-email-jijiang.liu@intel.com> <1417107801-9544-5-git-send-email-jijiang.liu@intel.com> <54784562.90906@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3 4/4] testpmd:rework csum forward engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Nov 2014 10:10:51 -0000 2014-11-28 10:50, Olivier MATZ: > Hi Jijiang, > > On 11/27/2014 06:03 PM, Jijiang Liu wrote: > > @@ -303,7 +305,7 @@ process_outer_cksums(void *outer_l3_hdr, uint16_t outer_ethertype, > > * TESTPMD_TX_OFFLOAD_* in ports[tx_port].tx_ol_flags. They control > > * wether a checksum must be calculated in software or in hardware. The > > * IP, UDP, TCP and SCTP flags always concern the inner layer. The > > - * VxLAN flag concerns the outer IP and UDP layer (if packet is > > + * VxLAN flag concerns the outer IP(if packet is > > * recognized as a vxlan packet). > > */ > > Please reindent the comment properly, taking care of the space before > the parenthesis. > > Another comment that concerns the whole patchset. It's maybe a question > for Thomas, but I think that having patches that don't break compilation > between each other would help when bissecting. > > In this case, I wonder if it's possible to split in something like: > > - change PKT_TX_IPV4 and PKT_TX_IPV6 definition > - add + rename flags (update them in mbuf + testpmd + i40) > - rename inner_l{23}, l{23} in l{23}, outer_l{23} (update them in mbuf > + testpmd + i40) > > I'm not sure it's feasible, I let Thomas give his mind about this. Exact, compilation must not be broken between patches. The proposal from Olivier seems OK. -- Thomas