From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 6A5B6326C for ; Fri, 7 Apr 2017 11:34:11 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id g19so55082575wrb.0 for ; Fri, 07 Apr 2017 02:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=dYaRaJNptFxpiQUKmg/4ln7PBr5ara4qjphowNN0s2o=; b=XLedcOnql1zgAOKBRM5C3p/W0r7W1xOMLEk23RIh75i2WqZSMzyt2KWIbgYwo7VTTI MgQ/ow+DG+r1kvtC/4uRX87/z/iaa1NA/UEThO9TGMqwr+vY6/FhYohPgYmgZbcsx2lU HF2Wdp1Y/BMTtzWJHdRME4PPuWj2DxvQblbziye8ym/04dTgkwQmHk0n7ZrucczBEE00 bsbb5WRTdAwmq2/Ymi25ooGkPJ+Lf2P0atDZSHM9XFaKQevB83I3/8lrGfob/QsgurZj JsniDziX7GH8puwM3kkOJ5lQBCZty6ph3zEyvZCknt9B1yOqrlHpPUfRHuoAw/jDqW6s jY5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=dYaRaJNptFxpiQUKmg/4ln7PBr5ara4qjphowNN0s2o=; b=DJXKEWGXBJsaE1wT6v+Bclo3DxAusCcnWKRg9FfB8cUKNo4Cx2gJeAcVZyYKsjUHzY Nt/xVTcEUYhCCsFmLOIiD5aR6uHYQHXa8brkZL5WIM/xGqHYGxB7gslDFJJcSdE4w0B1 6XkHigiBiG1qmkrfPhzvQnbIAXAIooBavmA/wdDWQoOZJkYPkWfTaHcd4WNsy6bGdj3Q cfLmB3M2J5ryUmuqf7/ZKy/si6gwe6CzRhfS6VJuNmkCAq3+u9cT9xps2jXuSLjOurxD GxLh5arAMgQKGTwrsHklcZElJdEL2HbaDE/xC37PpIgdOFO276qNLGFy2jWdgvp06c4q FDMg== X-Gm-Message-State: AN3rC/6j4zbxJAjHizdI25IM0QKpkzXSLVa3x1znCXWcdP33Af/bZ5kIccEhEG8QESxb9afZ X-Received: by 10.28.223.213 with SMTP id w204mr9547408wmg.57.1491557651124; Fri, 07 Apr 2017 02:34:11 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g63sm29684953wme.11.2017.04.07.02.34.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Apr 2017 02:34:10 -0700 (PDT) From: Thomas Monjalon To: "Mcnamara, John" Cc: Shijith Thotton , dev@dpdk.org, "Yigit, Ferruh" Date: Fri, 07 Apr 2017 11:34:09 +0200 Message-ID: <2110765.8k0m84YbOW@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1491059040-20647-1-git-send-email-shijith.thotton@caviumnetworks.com> <20170407070724.GA5581@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and testing of PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 09:34:11 -0000 2017-04-07 09:23, Mcnamara, John: > > > -----Original Message----- > > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > > Sent: Friday, April 7, 2017 8:07 AM > > To: Thomas Monjalon > > Cc: Mcnamara, John ; dev@dpdk.org; Yigit, Ferruh > > > > Subject: Re: [dpdk-dev] [PATCH 1/8] doc: add doc to explain compiling and > > testing of PMD > > > > On Thu, Apr 06, 2017 at 08:30:21PM +0200, Thomas Monjalon wrote: > > > 2017-04-06 13:21, Shijith Thotton: > > > > Add a section in NIC drivers documentation to explain compiling and > > > > testing of a PMD. It also mentions about host setup, which is > > > > required before running testpmd. > > > > > > > > Add label "testpmd_ug" to refer user guide. > > > > > > > > Signed-off-by: Shijith Thotton > > > > > > It is really good to factorize documentation. > > > > > > This doc is about testpmd in Linux > > > and does not refer to FreeBSD. > > > Do we assume to take Linux as the reference? > > > > I can submit v2 with a subsection for running testpmd in FreeBSD. > > Hi, > > > I can submit v2 with a subsection for running testpmd in FreeBSD. > > I don't think that is necessary. You patch already calls out the > Linux and FreeBSD Getting Started Guides. I think that is enough. > > > @tmonjalo > For me this new "Compiling and testing a PMD for a NIC" section > is a way of avoiding duplicate sections in the NIC guides. I don't > think it has to be a definitive guide to TestPMD. > > As and aside, I would like to do something similar with the sample > app guides, i.e., have one section on compilation that the other > app guides can refer to. I'll try to add that in the next release. > > So for me this patchset is okay as it is. OK I just wanted to start discussing about more factorization. Thanks for leading this work, John.