From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48904A0547; Wed, 29 Sep 2021 18:22:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B04CB41103; Wed, 29 Sep 2021 18:22:10 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 2CC3641100 for ; Wed, 29 Sep 2021 18:22:07 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="247509138" X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="247509138" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2021 09:21:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="563407886" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga002.fm.intel.com with ESMTP; 29 Sep 2021 09:21:46 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 09:21:46 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 09:21:45 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 09:21:45 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.49) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 29 Sep 2021 09:21:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SLU9u5iliz3BFXkdl9YrktLz5cuC3qZNOZPam5MKLt9ObCTv/gt7L+IChQC/htd/TpJyrcEUnQIBJHj102fmRLLrBTKsmXSUzgKMLwKfVcKV8cNYbf4CyzWga4DvrN5OVz83PKwU7GI5FcZFXxJyd+0xHsstbbTSB7VJUjset0yVQn2MaSKjJs7UEFBRsR/7kn6z7LWNJvmIyEX3dO7uqU1bVu57rJf+siknzcTY8+ObDq3XlCFGoRc2hhl/rdf+TE+QqvDYi8y5MX4glelEbaAW6ZQOGOl0lOVYxIwYlWIfpoSeaA/aTHcxaO74nvMEVf8qyQf7weeF2bL3yV3+iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=dDdk2Uak7VOvQFYdZR9ZNOT59BLVgzq5Ie2/ki6aHzI=; b=IfFpdZkDYCBRolISn7yqNfixHx6MDOUzK4yBAIMGRSOT55bgDwRb7Q9HCFm8n2C7FTJlJeVBCO/Gnd//6Ub0rP59tjxvQQgPJFXQ3zrc4hJZpWCmM4la4TyFCTN57QbSRn/nB0vsWOA0vtDkfVw61w1snAQ2Ns8+mPS9x6e9xwy+W7fuZ22sWK6O0WdaF0wSJ9CV6xern6NNz9DjbWLuv/Jba6TTPjHMk12VMCzLE8H8SlnoOf+AB64zs3xoq+CN+ctgRsyWBWoey8jNs4afeYt0JhP9NgRLDnRL+qdoYh1vK13TTRzwHnhCTpQPlGe+ehtmy60g2xKxaMHNIAqr5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dDdk2Uak7VOvQFYdZR9ZNOT59BLVgzq5Ie2/ki6aHzI=; b=fBEv9wG5nFpWUe5WcjgMWkG2ktB78NT2d3kmD/OWRZn9DvFAhj4HxFrusYq4pxvSCd0g8z73GWSNQn3ObrFf073IM/TI4NE4WnLKDio9WQHYPJAYLSoFrimlfSwEjFn7bnJxmILFb9NWcWcFG5jFfdE0kZjB3l3qKfwLU6AyYEs= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5126.namprd11.prod.outlook.com (2603:10b6:510:3a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 29 Sep 2021 16:21:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Wed, 29 Sep 2021 16:21:38 +0000 To: Robin Zhang , CC: , , , , , , , , , , , , , , , Stanislaw Grzeszczak References: <20210618063851.3694702-1-robinx.zhang@intel.com> <20210906020258.1291688-1-robinx.zhang@intel.com> <20210906020258.1291688-3-robinx.zhang@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <2110ad6d-5d02-15ef-78db-d338ee68fae2@intel.com> Date: Wed, 29 Sep 2021 17:21:30 +0100 In-Reply-To: <20210906020258.1291688-3-robinx.zhang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0191.eurprd04.prod.outlook.com (2603:10a6:10:28d::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0191.eurprd04.prod.outlook.com (2603:10a6:10:28d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.15 via Frontend Transport; Wed, 29 Sep 2021 16:21:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 983da774-4dab-4b0a-10d9-08d9836536e0 X-MS-TrafficTypeDiagnostic: PH0PR11MB5126: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:800; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ehSMosHVjJ0yR6EQGNMVhYXbyvxIrmly5Z/WQ52IRVLJyQVEMvs5jE3Z9JerRROVDcxb9eSkmDM39PtZTo8vkmttIYGibZiPo6Vl0xFlGU/UPq9t6tNjtcGH50Dkh8yRe97yXNcXpafBH9YXDAqJ+d1OBqGB+p5Fb2yGdw5RDrPR7/lAzsjgpAeKCk7443OXdL8cCOI/K0e4s0dF7c097M9B8WeHQPRbJsfjdQal61fk8HcUGphOV78a+b0J8owsbpWGrpOGd74Eveqqh0Mpv02XYUadonpgEsik/Q9zJc5A/Q44H1AGZ9H1VhrgaOgYGxqIdaTm7Rpz59xiZBfMK2Lt7Dm2Dribhr6dz+OCKbzo0q3+AzjyoRO30FANi3xDYBmO4sNnd5R3X5vZShZVtHydJ5jq7yrQOjJEtIS1GH0gKGghqmuVahe+RYXXCk1FBR6wah0RCrryRLBXOEz5P91/NJxad+/T9Sc+XcrhHXrApNxRoiHwU6408qFLlXNaAEYJtGk73fPApns8KVTg7yLBxNdmk0ZcTE01HC7Gat0evuV5aQO9X5f8clbyCJ7AdGd7CuUDlyfPjkyxiJ5BjGrh+LE97aL1JuGSGu91iqqcd9w+4LEtJyP4/Xji7tTdQctKRO9GtUFgAQVGsOIzKoWsSmxhUFcnk/r5uZEIgxM1CfEXYcOBdFU7FyLONmiHgjmQVwF0Zd31z3Z70lBjJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6486002)(2906002)(2616005)(956004)(8936002)(8676002)(31686004)(83380400001)(31696002)(86362001)(6666004)(66556008)(66476007)(66946007)(26005)(186003)(508600001)(107886003)(36756003)(53546011)(38100700002)(44832011)(316002)(16576012)(4326008)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MVNncjk0K1lFUS96N0ZKQVJyeWorcEF5T2t4N1ROKzVTNWtDallQN0NoRjhp?= =?utf-8?B?WEt6Vkl2Wkk2QldNbWdWU1MxSzVoT2J5eks2TlBJdFVDdzdDVUt3dzF0c3I4?= =?utf-8?B?WC9jQ0oyZDB0Q21nSnFvMUp4d09Ha2gwT2x3T1R5MjgxNG4zWVp6QS9JdXI0?= =?utf-8?B?MWlNMzlWenZHSy9UMWowY2hnT1NibGpERXZTZUE2OFpBMk00dTRRcG01LzRr?= =?utf-8?B?SUE4bHNnOEV6dkxNeDBYSlhWdGQ1enZKZHQzUENoNVdxeW03cnBmU0tNOVFq?= =?utf-8?B?Mll6YThmL1RjRERxVEhJZVBjZXY2bDdEV1pLRTF5b21xZ1BtNmgzOS9LOVRO?= =?utf-8?B?MEFuR3hjVEJXd205dG9RZDNXZVByb1g2ZEU4VktwWVpzNjRvUUw3S1NwZWJz?= =?utf-8?B?YjNwZld3N1JsQ0gxQVEycXhSVVRLS3VtZ1Z5Vm1OSlpMSVFDUFVacm9vY1Nq?= =?utf-8?B?bVQxZW5Lc1lJRkQxM203aHNESUQ3THVtejFmbFpWcjhMWTNNYWhzdW5nQjNh?= =?utf-8?B?d1o2dEJORkozdzN2Rlh4MFduMjJMWjlvczVKSVVuTGVEWjNmT1YwODhxR0pi?= =?utf-8?B?bTR6VVZnbW9TbkxneUxQdGhyVlNOZ0Y1WkhQcVJYOVlTS0h2SkVTNWQ5MldK?= =?utf-8?B?aFh2QVN0VXl0WC9GSWNhd0VodTZIQ2hrb05lOHV2amtMVytKOVRBcGtoQkp0?= =?utf-8?B?WVF0c2ZVcDJ2WG1MRTlibFhNT2xxWXc0YmZjZnYwSWhMaFZZaktTT3NvVG41?= =?utf-8?B?N0JmcGFvblJtdzIyYlJOTEFyV2pKU25lRDFxY2JXVUprQU4zdUFYTGNaQlc4?= =?utf-8?B?dEh5bHZQeWRER3ZleU5VMFZQd3ZVNkNNclNOMGtwWEYyWmZxWjJSR3h1SHBK?= =?utf-8?B?WncwMGpmajVxTDdmMEd3SWVTclRNRHhLU2FDY2lydDVIUCtzMTZRNHpCelI1?= =?utf-8?B?dTRkaHBWTmNUd2RZcUxCVTU3T21GR2g3YmF4cUdEYmxWTnZENUo1dzV0b1Zt?= =?utf-8?B?L1cxN0tKY1l5cStSTk1EYSs3ZTAvQnZKdUpnYlpMNWZ1SitvenRWSGcrN3h4?= =?utf-8?B?dzJjL1dtRTJqejhhdFpkbGFXRlovbTdQVkhneU9NT2xDMFY5UURaQUdxWDFB?= =?utf-8?B?R241bjdiOGZva2pkWEg4V085SkRIR1c4eDNEWVVrZjg3cHc2eE4xd3NsZElU?= =?utf-8?B?VjRuQ0ZFTlRIY1BJQVpOK2ZNNDFpMFFuMk5VSlhtdUZ0RXIyNzFqcUsxd0Jj?= =?utf-8?B?dWRhU1phWURYTHQzVGJCUGowK2xnY1NOTFhKNnMzaTFsZlVVNGR0NVhINng3?= =?utf-8?B?ajJDVTlTZ2kzSkVLRGNIVFBySzVKNlNKWmtYMlVYdDNHYU5EZnlHeVZsclht?= =?utf-8?B?bHJrTFRrUGNnemJJd2U3NVdtamZrcEVVdVhtc2MvaUNQQ1dqUFNud0w5OWM1?= =?utf-8?B?Q1JGUUtCem1BWGhHNjJJN2dKMHNwb3hDR0FBQ2lzYzREanRvc2hSRXFlL2N1?= =?utf-8?B?QTBaOVo0TUJ4VGZQZTNlWnY5QktKSXNaRnpHZldwcXVZMktIVUV6MU4yUkNN?= =?utf-8?B?RWI1QStMZTcwc0FaOXljdFdiRzh6SWtrOVNVb1dNNk9NYjhYQnhLRlMxK2M2?= =?utf-8?B?ZVFiNFNOelk3NWZvYmZpZyt3S3VRN1hrNVFpTnl1SVd4bll3YUhDb29oWFZL?= =?utf-8?B?OWtlSy92bS9hZHFISWM5NmFpc1dhc21McnBJSWdsd2NmaWVSdUw2cDFHS1h1?= =?utf-8?Q?VLUrBAEtVGnTeaJ2uOwZM8oamCzz6X1Rt6jlDGN?= X-MS-Exchange-CrossTenant-Network-Message-Id: 983da774-4dab-4b0a-10d9-08d9836536e0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 16:21:38.7385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9FOT/MCF1gWZypS97dFhltxIZ2pMNNjARQ29qvcm/e5UFzq2YvoHJGFnxCpMtQYtQvHcBkwxDGSWwG6UoG75jQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5126 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 02/18] net/i40e/base: add support for Min Rollback Revision for 4 more X722 modules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/6/2021 3:02 AM, Robin Zhang wrote: > This change increments X722 API version and adds new constants related to > the extended implementation of Security Version Opt-In. > There are new 'I40E_AQ_RREV_MODULE_PHY_*' macros, what is their relation with "Security Version Opt-In"? Also title mentions "Min Rollback Revision for 4 more X722 modules", is this referred 4 more modules are 'I40E_AQ_RREV_MODULE_PHY_*', is added macros for "Security Version Opt-In" or "Min Rollback Revision"? And what does "Min Rollback Revision" mean? And why first letters of words are upper case? Overall can you please add a little more clarification to the commit log? > Signed-off-by: Stanislaw Grzeszczak > Signed-off-by: Robin Zhang > --- > drivers/net/i40e/base/i40e_adminq_cmd.h | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/i40e/base/i40e_adminq_cmd.h b/drivers/net/i40e/base/i40e_adminq_cmd.h > index 2ca41db5d3..a96527f31c 100644 > --- a/drivers/net/i40e/base/i40e_adminq_cmd.h > +++ b/drivers/net/i40e/base/i40e_adminq_cmd.h > @@ -12,7 +12,7 @@ > */ > > #define I40E_FW_API_VERSION_MAJOR 0x0001 > -#define I40E_FW_API_VERSION_MINOR_X722 0x000B > +#define I40E_FW_API_VERSION_MINOR_X722 0x000C > #define I40E_FW_API_VERSION_MINOR_X710 0x000C > > #define I40E_FW_MINOR_VERSION(_h) ((_h)->mac.type == I40E_MAC_XL710 ? \ > @@ -2425,11 +2425,15 @@ struct i40e_aqc_rollback_revision_update { > u8 optin_mode; /* bool */ > #define I40E_AQ_RREV_OPTION_MODE 0x01 > u8 module_selected; > -#define I40E_AQ_RREV_MODULE_PCIE_ANALOG 0 > -#define I40E_AQ_RREV_MODULE_PHY_ANALOG 1 > -#define I40E_AQ_RREV_MODULE_OPTION_ROM 2 > -#define I40E_AQ_RREV_MODULE_EMP_IMAGE 3 > -#define I40E_AQ_RREV_MODULE_PE_IMAGE 4 > +#define I40E_AQ_RREV_MODULE_PCIE_ANALOG 0 > +#define I40E_AQ_RREV_MODULE_PHY_ANALOG 1 > +#define I40E_AQ_RREV_MODULE_OPTION_ROM 2 > +#define I40E_AQ_RREV_MODULE_EMP_IMAGE 3 > +#define I40E_AQ_RREV_MODULE_PE_IMAGE 4 > +#define I40E_AQ_RREV_MODULE_PHY_PLL_O_CONFIGURATION 5 > +#define I40E_AQ_RREV_MODULE_PHY_0_CONFIGURATION 6 > +#define I40E_AQ_RREV_MODULE_PHY_PLL_1_CONFIGURATION 7 > +#define I40E_AQ_RREV_MODULE_PHY_1_CONFIGURATION 8 > u8 reserved1[2]; > u32 min_rrev; > u8 reserved2[8]; >