From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id B0999106B for ; Mon, 23 Mar 2015 12:40:52 +0100 (CET) Received: by wgs2 with SMTP id 2so36633155wgs.1 for ; Mon, 23 Mar 2015 04:40:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=b4ItvVrICnOWyBJvjocb6EUgB/6FxrG78msO+859Xvs=; b=Y6FyWz8sVMM36Lr5qLSVYhKRsUEMRgT/oyze5irE3DXCw96mxOIIBB2FX8nr+fFf4O yR0PGxBBuLXZEqYwgZ4y11KvexhUNRqgKwzc2KljgF4hocv3zC5ixMRyd+D4RE+JZnhF 9ZVNyOU/QOhHazSAySWTviex22PZpxnGtJQYd89fvhX7c+6n510hKoHrVF7nKkRBbvqK aczTLJSsvXpLLiEW1AtZXnVcSJClSdgztGz9ZgssVVf8hFkxmvnymWy1er1VHgG4mu7D IR0Ljr6StQuxrbItCspNP2P9E2HHnh6OsQuo19jlT158na/MclIUBgq8OHeMOIgraPlQ ytKg== X-Gm-Message-State: ALoCoQmJnCKTCUum1W2jLWkUxJ7xf36TYjzulDYW7TLXHsekZHKP47d3vIjTUB4cNiymBKvoQoQZ X-Received: by 10.180.83.195 with SMTP id s3mr19011735wiy.54.1427110852521; Mon, 23 Mar 2015 04:40:52 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id u18sm10839507wib.1.2015.03.23.04.40.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 04:40:51 -0700 (PDT) From: Thomas Monjalon To: dev@dpdk.org Date: Mon, 23 Mar 2015 12:40:11 +0100 Message-ID: <2111723.CRdqpS7LaL@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1425700658-12077-1-git-send-email-jiaxt@sinogrid.com> References: <1425700658-12077-1-git-send-email-jiaxt@sinogrid.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] librte_pmd_e1000: power down the serdes link X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 11:40:52 -0000 There is no maintainer declared for e1000. Maybe that an Intel expert could check this patch, please? 2015-03-07 11:57, Shelton Chia: > Signed-off-by: Shelton Chia > --- > lib/librte_pmd_e1000/igb_ethdev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c > index 504ae74..314ef2a 100644 > --- a/lib/librte_pmd_e1000/igb_ethdev.c > +++ b/lib/librte_pmd_e1000/igb_ethdev.c > @@ -948,7 +948,10 @@ eth_igb_stop(struct rte_eth_dev *dev) > } > > /* Power down the phy. Needed to make the link go Down */ > - e1000_power_down_phy(hw); > + if (hw->phy.media_type == e1000_media_type_copper) > + e1000_power_down_phy(hw); > + else > + e1000_shutdown_fiber_serdes_link(hw); > > igb_dev_clear_queues(dev); > >