From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 039FFA00C3; Thu, 14 May 2020 10:02:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86B4E1D68D; Thu, 14 May 2020 10:02:14 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 526901D68D for ; Thu, 14 May 2020 10:02:13 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id CA98B931; Thu, 14 May 2020 04:02:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 14 May 2020 04:02:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= np+aaRlJdUUmo5jPMm79gxuWoT96KSo9huAPojd2KdY=; b=Wka4TiESJYNJzs1x r52D/CBQ8XtDuAamWXGXBoLLwv4SS1ah1d/L+MbBFjIn4cg4rmSir7V4EXYBKU8d 50IhSH3tgTYg8/2R93ueojo/w3vVdPKgPl5GgXzNp9NjucNLHgWIikfnpCoUaPSk N/0cwWMT+5b9Y3cQl38eWYH/BYeRm3WOQAjEtbhNYM4CyElVq5kjfwJK7XFSmC7h DDbs4xythRcHTrBT4iRbf5IL8OHvxbTxYD+sQDBfsH7oPU16z220wCm2J6AkNyQ2 SKTI4thkNqzDJTXyu7ShO5d5enJe5YnN7fv2okYc6FY62qP1a+DKDSXgX9PQW7fz oN+WhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=np+aaRlJdUUmo5jPMm79gxuWoT96KSo9huAPojd2K dY=; b=z9acr+AAcmVLXZ+bga+DEWkF4aL+Kmp1sybNYns/pcVKQbtlanz8Pj37Z tWQbASwore+KqbB5q50fAR1E779BkVhQFi4ixJ9J2H9DhdvH+hNa+OgGuNmQIJcf krGhElACIlyTVjJCDlyi7tbZHj+4KKYkUZm7ABm7D1gScU+TprLHDM99jDgm3AyZ eCJHp6lwhPlySmB/RWGxBmnqPbSlfRHtnyo3gBOjqX0aGuIe1sdo2B+eqQGH+XGN +1ErbBmsClCZBGxo36rEcwj6B2SfIu9e4/SQBzjXay6B6HSb4GME22+OKKDnDyvI TDmdCuP8vyJuf+2Tr6L7ARhbRE4oA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrleehgdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8EEF73280059; Thu, 14 May 2020 04:02:09 -0400 (EDT) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com Date: Thu, 14 May 2020 10:02:07 +0200 Message-ID: <2114758.o7ts2hSHzF@thomas> In-Reply-To: <20200513225341.7620-1-pallavi.kadam@intel.com> References: <20200513225341.7620-1-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix warnings on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/05/2020 00:53, Pallavi Kadam: > This patch fixes bunch of warnings when compiling on Windows > such as the use of an unsafe string function (strerror), > [-Wunused-const-variable] in getopt.c and > [-Wunused-variable], [-Wunused-function] in eal_common_options.c > > Signed-off-by: Ranjit Menon > Signed-off-by: Pallavi Kadam > Tested-by: Pallavi Kadam > --- > +#ifndef RTE_EXEC_ENV_WINDOWS > static int > eal_plugindir_init(const char *path) Why disabling the plugin mechanism? Can we make it working instead? PS: When sending patches for Windows, please Cc the official Windows maintainers and Dmitry Kozliuk.