From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C8AF42F6C; Fri, 28 Jul 2023 17:06:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E58940685; Fri, 28 Jul 2023 17:06:39 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id ACF514021E for <dev@dpdk.org>; Fri, 28 Jul 2023 17:06:38 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 5E9B75C0090; Fri, 28 Jul 2023 11:06:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 28 Jul 2023 11:06:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1690556798; x=1690643198; bh=VyfXFN0cxarKX6XeK1oH+U4oRYBpctomO+S nFVVz2z8=; b=KFHjlK6QO+jDs0oTThuAKsb1wT9YW3W4a9BhaGxqWLI4EDwk6CG gh5aGlahTOzLAzIapZV7SQ5gD6IKcA1vO8hU+4Q0ToXwjnhYZBYP8jTzodPFhhXO TWY5XF6k/Ch48Jsx138ChWxjLLq5m+Gzq7UW2EgGssqo3j2lAidwagp+rr4wf/sy l9pDdCv1VlfO845wn91jbC9wvWheLjUw37RREWm8DZxRcEpf7QA+2eogcI6y5VpT 83lOTjuEY+QzKkGSRADShGEv+zbqhUG3kTQg0W1kXA+YgvxxZ9NBaSVZa+YGZGph 1sFDCARSICArGAkQV5hMLDwdHSr6m/QnOIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1690556798; x=1690643198; bh=VyfXFN0cxarKX6XeK1oH+U4oRYBpctomO+S nFVVz2z8=; b=uEsgK+D1g9jaU79PQn3DrrncyDpGE7rZMDDYx9Ch88sAxH/BNDB pUhmfEWdVLR1hS7ymcoL0GG0bwu8Yy8tiPUBYNRCpSF0YXq6HZyrmqicRxY2SFMC 6hcmm2Gc3pDug8bjx2GAiEmqe2+BSkr9M7Ij/8ht6z/K/VWfn6GWA+fxl4PaGoPk J2jgLVmU6Vc3v6ESjXniobvGmvOAfAIbdfKlCShlx304Kwjh+l7dYUyIYz9zvyqt MPxm7paVKQ+j74u2x3uYJHagng7/RfIkou/voA+iWXIQ5FqCksJbRKCkhF6iQfCX ni62wEcfDFJFXXdbvqZlqs365Hlrtbhx3dw== X-ME-Sender: <xms:ftnDZD_j5TpU0R4yjFE2To8t_obO9QxHYO5WXPJqMUcVNcYFg0rHBA> <xme:ftnDZPt3Fgbdx2KPIsMPcAg3ZYWOKpHdHLqLJm9Qs0bVcNrjtLwfk52Eznzktc837 3zhGkeGEQoHOMro8g> X-ME-Received: <xmr:ftnDZBDwIARwbgfwX9Ws57vAbkdRiNMwHdEGc-xfPFlzhT4Ob89O3EtcwNC0_e3Vq39tHwB7WG_j0LCEz8ZBsM8L0w> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepjeejffffgfffkeefffelgfekleetjeffleeludeghfehleffteeh veduffdugfdvnecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: <xmx:ftnDZPcCWM008H-L7ql6h1Q6Ovr40D7aDA7r7GWrEJWlK8e42vY71Q> <xmx:ftnDZIPxGquqUNgR3cGeOp0F6pC8_hT0e1N5t7c4s2tTb-FI7D-Hzg> <xmx:ftnDZBkjH88NxW2XHWOk67vnEziFGlJXDA507Mzq-3IlZ5KYzP5WPw> <xmx:ftnDZBaMM8xJrtjetMtZK5t1xsKTxNv90vHedy_bAHfOtwoCt3-ing> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jul 2023 11:06:37 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@amd.com>, Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, Dongdong Liu <liudongdong3@huawei.com> Subject: Re: [PATCH] doc: deprecation notice to add RSS hash algorithm field Date: Fri, 28 Jul 2023 17:06:35 +0200 Message-ID: <2114799.OBFZWjSADL@thomas> In-Reply-To: <20230606093542.351884fe@hermes.local> References: <20230606121126.9983-1-liudongdong3@huawei.com> <6e9dd06f-6f90-b80f-7f26-3b8c58ea2036@amd.com> <20230606093542.351884fe@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 06/06/2023 18:35, Stephen Hemminger: > On Tue, 6 Jun 2023 16:50:53 +0100 > Ferruh Yigit <ferruh.yigit@amd.com> wrote: > > > On 6/6/2023 4:39 PM, Stephen Hemminger wrote: > > > On Tue, 6 Jun 2023 20:11:26 +0800 > > > Dongdong Liu <liudongdong3@huawei.com> wrote: > > > > > >> Deprecation notice to add "func" field to ``rte_eth_rss_conf`` > > >> structure for RSS hash algorithm. > > >> > > >> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com> > > >> --- > > > > > > New fields do not require deprecation notice. > > > Since this seems to be a repeated issue, perhaps someone should > > > add this to the documentation. I've just sent such a patch: https://patches.dpdk.org/project/dpdk/patch/20230728142946.1201459-1-thomas@monjalon.net/ > > Hi Stephen, > > > > This is follow up to an existing patchset: > > https://patches.dpdk.org/project/dpdk/list/?series=27400&state=* > > > > Although field is addition to the "struct rte_eth_rss_conf" struct, it > > is embedded into "struct rte_eth_conf" which is parameter to an API, so > > change cause size increase in outer struct and causes ABI breakage, > > requiring deprecation notice. > > It will change ABI so will have to wait for 23.11. > But the purpose of deprecation notice is more about telling users that API > will change. > > The automated tools may give false complaint. Ok to add to deprecation, > but really not necessary. This deprecation notice is marked as superseded, given my patch above should be enough.