Re: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter

[Thomas Monjalon <thomas.monjalon@6wind.com>]

Hi Jingjing,

Please reply below the question.

2014-05-28 01:12, Wu, Jingjing:
> You are discussing whether the APIs provide for NIC filters is generic
> or not. About that we can use same API for a type of filter. For example,
> if we want to configure ethertype filter, we can use the same API, no
> matter the NIC is 82580, i350, 82576 or 82599. We think these NICs may be
> most common used.

I was wondering if this API can apply to non-Intel devices. But nobody talked 
about it. So let's forget it.

My main concern is that Vladimir Medvedkin suggested another API and I'd like 
you give your opinion about it:
	http://dpdk.org/ml/archives/dev/2014-June/003053.html
It offers pool number in configuration of the filters.

Last comment: patches would be more pleasant to read with right alignment and 
spaces in comments. This is an extract to illustrate what I'm talking about:
+       uint16_t priority; /**< used when more than one filter matches */
+       uint8_t dst_port_mask : 1,  /**<if mask is 1b, means not compare*/
+               protocol_mask   : 1;

Thanks
-- 
Thomas