From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f180.google.com (mail-we0-f180.google.com [74.125.82.180]) by dpdk.org (Postfix) with ESMTP id 092A1B0BA for ; Wed, 11 Jun 2014 17:44:55 +0200 (CEST) Received: by mail-we0-f180.google.com with SMTP id x48so6519735wes.39 for ; Wed, 11 Jun 2014 08:45:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=hnA407jvIi4GLTyXDcag4mpYcaEcRSUb9Jv8d4gfa5A=; b=Yhf6FNMSDObF+IXM+9nByGYGtugBb/kMM+Wyitgek1mB+KnGm0o3GSzqMWZ9//Crcq dB4eQkD3MjHk1hZ244dFijoOCrLYjR5hurL2Nmwdkk1OUl3MEVPqwENT/dVvs63D7gGM PmQiqF1ynm9nOCJ+pTQtt3LttzSWD5q+bxhZf0ohEoUQ1JWK9YV+xHqXRJNpPXo2yZlf UH+7O2Ji9/ffsusAlbQvB/3dOY/Gq98wBrk9P+SylRL0pL7tMH4v1xkZaHLAYdMqVFAG TcD8Vmb4IYkUhVoiwGygbslG4/V1vid/YQI8IZX1DETdkxoGy95dMo2YyrOC/6xXRvXx XkLQ== X-Gm-Message-State: ALoCoQlStBySsEikddJLyHm8INOwO7rMJgKCGLr3Y6mh3Yr9pm0tVlzSh/njKIJScqBY1mxeng8Z X-Received: by 10.194.161.168 with SMTP id xt8mr53296863wjb.35.1402501509747; Wed, 11 Jun 2014 08:45:09 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id vm8sm34811223wjc.27.2014.06.11.08.45.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Jun 2014 08:45:08 -0700 (PDT) From: Thomas Monjalon To: "Wu, Jingjing" Date: Wed, 11 Jun 2014 17:45:09 +0200 Message-ID: <2116871.SYCYqgDKRI@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <9BB6961774997848B5B42BEC655768F8A78A07@SHSMSX104.ccr.corp.intel.com> References: <1400895442-32433-1-git-send-email-jingjing.wu@intel.com> <9BB6961774997848B5B42BEC655768F8A789C6@SHSMSX104.ccr.corp.intel.com> <9BB6961774997848B5B42BEC655768F8A78A07@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2014 15:44:56 -0000 Hi Jingjing, Please reply below the question. 2014-05-28 01:12, Wu, Jingjing: > You are discussing whether the APIs provide for NIC filters is generic > or not. About that we can use same API for a type of filter. For example, > if we want to configure ethertype filter, we can use the same API, no > matter the NIC is 82580, i350, 82576 or 82599. We think these NICs may be > most common used. I was wondering if this API can apply to non-Intel devices. But nobody talked about it. So let's forget it. My main concern is that Vladimir Medvedkin suggested another API and I'd like you give your opinion about it: http://dpdk.org/ml/archives/dev/2014-June/003053.html It offers pool number in configuration of the filters. Last comment: patches would be more pleasant to read with right alignment and spaces in comments. This is an extract to illustrate what I'm talking about: + uint16_t priority; /**< used when more than one filter matches */ + uint8_t dst_port_mask : 1, /**