DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] test: fix test_tlb_tx_burst
@ 2015-08-07 12:15 Michal Jastrzebski
  2015-08-10 14:13 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Michal Jastrzebski @ 2015-08-07 12:15 UTC (permalink / raw)
  To: dev

Test failed on verification if number of bytes
transmitted on each slave is not less than 90%
and greater than 110% of mean value of bytes transmitted
thru one slave. This was verified on a real system
but is difficult to achieve using virtualpmd.
That's why for unit tests only, it is sufficient to verify that with
high load (2 seconds transsmission) all slaves are trasnitting
so the traffic is balanced.

v2 changes:
- improved description
- reverted number of packets generated (in v1 it was decreased,
	but to achieve balancing it has to be high load).
	
Signed-off-by: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
---
 app/test/test_link_bonding.c |   16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 305d45d..388cf11 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -4058,7 +4058,6 @@ test_tlb_tx_burst(void)
 	struct rte_eth_stats port_stats[32];
 	uint64_t sum_ports_opackets = 0, all_bond_opackets = 0, all_bond_obytes = 0;
 	uint16_t pktlen;
-	uint64_t floor_obytes = 0, ceiling_obytes = 0;
 
 	TEST_ASSERT_SUCCESS(initialize_bonded_device_with_slaves
 			(BONDING_MODE_TLB, 1, 3, 1),
@@ -4070,7 +4069,7 @@ test_tlb_tx_burst(void)
 			"Burst size specified is greater than supported.\n");
 
 
-	/* Generate 400000 test bursts in 2s of packets to transmit  */
+	/* Generate bursts of packets */
 	for (i = 0; i < 400000; i++) {
 		/*test two types of mac src own(bonding) and others */
 		if (i % 2 == 0) {
@@ -4123,15 +4122,14 @@ test_tlb_tx_burst(void)
 
 	TEST_ASSERT_EQUAL(sum_ports_opackets, (uint64_t)all_bond_opackets,
 			"Total packets sent by slaves is not equal to packets sent by bond interface");
-	/* distribution of packets on each slave within +/- 10% of the expected value. */
-	for (i = 0; i < test_params->bonded_slave_count; i++) {
 
-		floor_obytes = (all_bond_obytes*90)/(test_params->bonded_slave_count*100);
-		ceiling_obytes = (all_bond_obytes*110)/(test_params->bonded_slave_count*100);
-		TEST_ASSERT(port_stats[i].obytes >= floor_obytes &&
-				port_stats[i].obytes <= ceiling_obytes,
-						"Distribution is not even");
+	/* checking if distribution of packets is balanced over slaves */
+	for (i = 0; i < test_params->bonded_slave_count; i++) {
+		TEST_ASSERT(port_stats[i].obytes > 0 &&
+				port_stats[i].obytes < all_bond_obytes,
+						"Packets are not balanced over slaves");
 	}
+
 	/* Put all slaves down and try and transmit */
 	for (i = 0; i < test_params->bonded_slave_count; i++) {
 		virtual_ethdev_simulate_link_status_interrupt(
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-08-10 14:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-07 12:15 [dpdk-dev] [PATCH v2] test: fix test_tlb_tx_burst Michal Jastrzebski
2015-08-10 14:13 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).