From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28322A0524; Thu, 30 Jan 2020 16:59:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F5EA1C022; Thu, 30 Jan 2020 16:59:41 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id D78ED1BFB0 for <dev@dpdk.org>; Thu, 30 Jan 2020 16:59:39 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 356BF2209B; Thu, 30 Jan 2020 10:59:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 30 Jan 2020 10:59:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=TR+rsDGIDRO5rlB+d6nt9ehFt7nA4casTQR0tKHTbFc=; b=MP2yMulR3S2H ++8CPlcJKrZNz8YobR8LUqRJiwYTIfQPUfss3vgckz+raVlyjoC7cfpAxC9hlhr4 WOtd7wiFH8zadqug8tOXFOuu1ELwQS07r6SFKkBjTiSs/VxlcXwa6Vg3itUfJwbp jeiImD+2Ln3njv6iDBbkmL05UXKyMfo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=TR+rsDGIDRO5rlB+d6nt9ehFt7nA4casTQR0tKHTb Fc=; b=Xm2LMb2BjDvomTKIOSEYhe1j97x4XMDnQe6hBVOlbLPToTCglBOEL2VpL LJI4lQU5U1OfI0kpy583cKhCJZ+xQ0UhIkK7yfK+kBNY/gWKAZGkFF5kkLZLhTPs w7fRVH8J0ZePbexlEis7vQ02JvzY/tvA07hgsMUt4/xenLo6yADFvyspRe2I5o+2 O0f5G8C1hn6VlGnm64bUOvq2T2bpb1zgb8UzR2LEC+m0fdjlUFt5X90Y5esuV3dn Y92AOLcu6wJmtxtGwPqn80kQXHE+uskjDALtfSFbVmyttrqCz2W7SISI++fbIGQ3 HwTmaQFtRvx+Svw2OOBR/6ffU+p2Q== X-ME-Sender: <xms:av0yXqvTg7XEOtppm_1Ydv7QhSIx3W5OiYjgEJMCxLVNWnt0Sf0NzA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrfeekgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:av0yXju3FcbTi98XehHz3IKBOevqKYPgzc9kFvX-PuXSGD9X4gTDaQ> <xmx:av0yXgzz7K8pVB9nGSMbQ9edRItuglOHByMzG3jdE_qZzvywN_vqig> <xmx:av0yXphNT1DOJJd0XOXYT4mmqy7wV9PqNj7nCeFyx6UtN7m-WnRyCQ> <xmx:a_0yXt1jkImQYUlWhq7pVMS68Vd8ZGK-LnnNqevhHnlvn-qNliWxGw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3D3323060A88; Thu, 30 Jan 2020 10:59:37 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Anoob Joseph <anoobj@marvell.com>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Trahe, Fiona" <fiona.trahe@intel.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Trahe, Fiona" <fiona.trahe@intel.com>, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Date: Thu, 30 Jan 2020 16:59:36 +0100 Message-ID: <2118076.C4sosBPzcN@xps> In-Reply-To: <BN6PR11MB17965D325A2C002EBC08C68BE4040@BN6PR11MB1796.namprd11.prod.outlook.com> References: <20191220152058.10739-1-david.marchand@redhat.com> <MN2PR18MB287716C2FB283C93CE11AAE0DF050@MN2PR18MB2877.namprd18.prod.outlook.com> <BN6PR11MB17965D325A2C002EBC08C68BE4040@BN6PR11MB1796.namprd11.prod.outlook.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 30/01/2020 14:06, Trahe, Fiona: > We were unaware the LIST_END change could constitute an ABI breakage, but can see how it affects the array size when picked up. > We're exploring options. > > I agree with Anoob's point that if we don't allow the LIST_END to be modified, then it means no feature can be implemented without ABI breakage. > Anyone object to removing those LIST_END elements - or have a better suggestion? Would have to be in 20.11 I suppose. Yes, having max value right after the last value is ridiculous, it prevents adding any value. In 20.11, we should remove all these *_END and *_MAX from API enums and replace them with a separate #define with reasonnable maximums.