From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52121A00C4; Sat, 29 Jan 2022 19:51:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F10D940DF6; Sat, 29 Jan 2022 19:51:55 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 0B51C40041 for ; Sat, 29 Jan 2022 19:51:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 427AE5C012C; Sat, 29 Jan 2022 13:51:52 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 29 Jan 2022 13:51:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; bh=yAEKgshvfwz6p4 Go00IrSbqqpyMpCXsb4+LM3e59q0w=; b=H/Agi5Zi0JDhOTGDVrxN8X153h4q7S GhGxfqqXu04el6A7/33aah5CpUS/fGwmirjG4HpHJjVZuDCl0mJ034zsYgJ6iRDn yzhkGbYgwvPnY3etuKgi6RHfB7L5GXpb9jHgwqcdLn1CY2h2TAX1DMW99obgo+Vt ycE0mnStbB8V4gPnyqxN7ALyFHRtOzCVlJF0P/TTxohgYLBpefrLjUooC4I2HGNd znkhcQoe114uOEXALWDZmTs/yMKNw2lD3BbIFwtQdoq8E6LZbjPzg4nZ1ua/cwmf fMSCopG8OXXxhFQK6F+CzU1JB3pX+MvzaCP4XIHXN3+pkl8IAXML6coA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=yAEKgshvfwz6p4Go00IrSbqqpyMpCXsb4+LM3e59q 0w=; b=PiGqYMwpRGBIQFLDr/Bh1W7E/L8v6eJijA03ixrVG7r8WUp/Vr9OsW5cr bm1LwLOqniqs13vECHur5ML2PQd1++SqOk6sI58z1o3ESrL3LqGz5yIMk1b6yjKG niAcv4mmWbKX/c3ODh3uIFQDbhhjjCQFNJ86wx9Qzrrw7ofP0MPRds6QJStwRg2i xO60sk8NbOuHFzgBBUe7z8N55lUGg2GGQn1kEgmlk7IED+WIf47NKE/s/f0nWXke e+n3E7WgdawMNV+s/2Wgtfy37UKlpmkPtzsryD4BQWdHu/oajZGxRHnAnjVHUBw2 sylfK7fRePdpILv/S6/TR1SHNnAlQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrfeejgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 29 Jan 2022 13:51:50 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Olivier Matz , Andrew Rybchenko , Honnappa Nagarahalli , Konstantin Ananyev Subject: Re: [PATCH v2 01/83] lib: update documentation of XXX_free() functions Date: Sat, 29 Jan 2022 19:51:47 +0100 Message-ID: <2119555.NgBsaNRSFp@thomas> In-Reply-To: <20220128145155.11bf10cd@hermes.local> References: <20220124000518.319850-1-stephen@networkplumber.org> <109562095.nniJfEyVGO@thomas> <20220128145155.11bf10cd@hermes.local> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 28/01/2022 23:51, Stephen Hemminger: > On Fri, 28 Jan 2022 22:47:15 +0100 > Thomas Monjalon wrote: > > > 24/01/2022 18:45, Stephen Hemminger: > > > These functions all behave like libc free() and do > > > nothing if handed a NULL pointer. The code is already doing > > > this, this patch just documents the behavior. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > /** > > > * De-allocate all memory used by hash table. > > > + * > > > + * If the pointer is NULL, the function does nothing. > > > > Would be better to move in the context of the parameter > > I copied text from rte_free to other functions... > For consistency, lets document it one way in all cases. > Don't care which one... I prefer to have comments about a parameter inside the @param please.