From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by dpdk.org (Postfix) with ESMTP id BA06218F for ; Fri, 16 Jan 2015 18:04:36 +0100 (CET) Received: by mail-wi0-f178.google.com with SMTP id z2so5175255wiv.5 for ; Fri, 16 Jan 2015 09:04:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=VrIoMVougoaJgmYND9zTUseUSa/HTi6LoorJZQgI7qA=; b=cPvVMEkZKdMmiyvHwcRXg/DhHin3kADXZBJxsK/z19asC9n6yXq6UNeyJYFoMUd1nq tpLPxJEPe1XQbTdHJs3fReZQ7LMgpF1S/JpaBPAgL8WDYhr4zrPmbnrqmBy2CBc/uOOo wvyh6l8Ynr05GOQZ2dLxy0oNg1DYo7bey9wOYyF19AGgPzffWvMsrqne6ZAipdSDmtBY RJz+hKy234tkrGBFVHfA+vgDK4czhd4jPaQcUXxYHUIAOp2L7bs3b31k2UNJB0yHENeD vdL5M7Eil9pjExC0vG+J8FW47oN1X/3DTsMPVnPPmiGsZcQhxPsCIxnid3y5W6LEpseP 8SVA== X-Gm-Message-State: ALoCoQlfS15RrY+AjeIuaon3+5y6V/6lNN5mMysKEPOmWEwCBzKSg7Ivc3S5X3ZIiIPneRh+0kl1 X-Received: by 10.194.235.226 with SMTP id up2mr31400254wjc.9.1421427876554; Fri, 16 Jan 2015 09:04:36 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ep9sm3761322wid.3.2015.01.16.09.04.35 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Jan 2015 09:04:35 -0800 (PST) From: Thomas Monjalon To: "Wodkowski, PawelX" Date: Fri, 16 Jan 2015 18:04:12 +0100 Message-ID: <2120377.FvxLenVaOl@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.6-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: References: <1420815925-7988-1-git-send-email-michalx.k.jastrzebski@intel.com> <29007273.jolbkK9tis@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] ethdev: fix missing parenthesis X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Jan 2015 17:04:37 -0000 2015-01-16 09:40, Wodkowski, PawelX: > > Good catch! > > Was introduced in commit 4bdefaade6d1 (VMDQ enhancements). > > Note that quite often, when a patch contains too much things, > > we miss this kind of bugs. That's a reason to well split patches. > > What is most surprising I did not spotted this, neither the compiler > what I think it should. It was my IDE which pointed possible bug. > > Are we using '-Wparentheses' switch? If not, we should consider > to use this switch? It's already included in -Wall which is set in WERROR_FLAGS. -- Thomas