From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wj0-f175.google.com (mail-wj0-f175.google.com [209.85.210.175]) by dpdk.org (Postfix) with ESMTP id 1FA6010D8B for ; Thu, 22 Dec 2016 16:28:44 +0100 (CET) Received: by mail-wj0-f175.google.com with SMTP id sd9so45841049wjb.1 for ; Thu, 22 Dec 2016 07:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=2Qvlj6q5wfrS0uBvBj7P5Md12q8wX4a14wpFjHasEIw=; b=Wvbhb/8M0wBY3FbT5nnq9oxnw4Bf4pE6D0mgdiFdRqxvyaQInvmh7IZWghqf4up+LG 0ItBzjcariPXNdq8rZecM0lGzWN11yPuzHpDGbHBAjTOGC6t02YYyDQaNYdu7in0J3+9 Kp8Kjn/Mg62CYrUcg7WCzV/sSI432mXdM0FmodpPYfxmMsMQrFCe7krxNnR5FpceT9KB aABnTUyyGrqebbsgZpid0TgqK3oad/ipbgdcZDS1Fct3NmigUfjt+AKgA6Bn9c7cDTLr qESt42URVS1r+/xTaVO/5txJCx0yuY/Ui3Ro/87zQ7VSbo+sVh4I9ZJ3sBE6AiFAu4Uj 8J/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=2Qvlj6q5wfrS0uBvBj7P5Md12q8wX4a14wpFjHasEIw=; b=Lj+rIr0NyTdTvF12uxm4YJuaQQRbvkoqeVUJ5B8I+0uFjShmNCPK5XPe7rdGszRPQw bNLAPM/rFq5p1ZqViC4RWmDLpp1j9nNibMhn1ehjAdf1O/sCqEhIpshjwAN6HjroObBT M1CuuzvqjMXUA7zH8DhTfnLVPMQILJXSa0E1OASAeRvdpC6KBVB5F1bL5rajqxA7CpOQ xat7Auu61Fz0Mw7dkhuGtkOpsQIO/locTTuRUC5l1KfNV/0Udp5z6tIwN32QfNT+WRw4 xvO5J+TIqXbRIpGXzRQpkF96CCduS+jsEgwU7uPJQp4fYlm67yrNHvu3Da2SOf9IMdRy mr3A== X-Gm-Message-State: AIkVDXL55dXRaPFzsTOCaLPiG7mFek00MlFyhjDZuEmOY9O9qhdkIZmsxzcL4nMGlFysmxOT X-Received: by 10.194.190.229 with SMTP id gt5mr9507753wjc.212.1482420524673; Thu, 22 Dec 2016 07:28:44 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id gj6sm36193694wjb.29.2016.12.22.07.28.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 07:28:44 -0800 (PST) From: Thomas Monjalon To: Ferruh Yigit Cc: Jan Blunck , dev@dpdk.org Date: Thu, 22 Dec 2016 16:28:43 +0100 Message-ID: <21208304.RglXy1FaaL@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <26b1177f-93c3-d3c3-fa63-e971af8dd139@intel.com> References: <20161222115330.7164-1-ferruh.yigit@intel.com> <26b1177f-93c3-d3c3-fa63-e971af8dd139@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] ethdev: cleanup device ops struct whitespace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 15:28:45 -0000 2016-12-22 15:16, Ferruh Yigit: > On 12/22/2016 3:10 PM, Jan Blunck wrote: > > On Thu, Dec 22, 2016 at 2:10 PM, Ferruh Yigit wrote: > >> - Grouped related items using empty lines > > > > Reordering fields of a struct is breaking ABI. We should bump the > > library version now. > > You are right, sorry missed that. > Intention was not to break the ABI, but cleanup. > > Thomas, > If it is too late, do you want me prepare a revert patch? No Please check doc/guides/rel_notes/deprecation.rst We are going to break the ethdev ABI anyway.