From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52])
by dpdk.org (Postfix) with ESMTP id 6CD972BF8
for <dev@dpdk.org>; Tue, 5 Apr 2016 10:25:36 +0200 (CEST)
Received: by mail-wm0-f52.google.com with SMTP id f198so21131365wme.0
for <dev@dpdk.org>; Tue, 05 Apr 2016 01:25:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=6wind-com.20150623.gappssmtp.com; s=20150623;
h=from:to:cc:subject:date:message-id:organization:user-agent
:in-reply-to:references:mime-version:content-transfer-encoding;
bh=ceDVxj3Ge6WrV4w7jGVvdy536wbiB9lZa4HC0WT9Iy0=;
b=pU7zM/dXXq/PjfDE0esiWtF17X1LRPmLxB7W7+9f2Yeq0Md1mmtc5KjRGoDsOJPvVd
79cCTP6EiWyah7TOR1wwvArCeJvhaA2uqZyuu02hCtNL+2aY597pK+GN7Z2GlLpnEH27
6Wf3t45St/ULd2lU53HJ6Y/i+BFr4TfTCeKE0n7dRFVcGMhnajwPlBZrJPrFMGk01+Fh
1UQfd3Q2WrQdG/ioHxwdAN0apvu3eqzdCBG6V3vZe/28trywAXZipFGPjWKiCRRID8Is
fqiBYCq5nR3EaJHlIEWbi5GWeSUWuKd8sO+skrslW/81AVarZbZzEVKNn91TnwjYP83r
BYCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
:user-agent:in-reply-to:references:mime-version
:content-transfer-encoding;
bh=ceDVxj3Ge6WrV4w7jGVvdy536wbiB9lZa4HC0WT9Iy0=;
b=FhWUXp+U4xijaeLXn30rF6WeGHv0+4m2FOXAgmPXjm/L4l3uxdXVU7ovT3G/WYBawy
AhxNDRmSV1f3U0R7Z8C1hcxm7X3+pxb8O+qyOwpNfsz7O4BVprEhQtJXikLT6zJIP+Nj
7+S3tudVXMGPIN4KkBFTllAcGe6EAKLji9q/80dzokWITWGZUpcBqM9QLyVpkGDrBW+6
RaN8Iuc8lYEsUrGpm1c0EzvBzNFInnmOu7oDPKBa1lkx2jE4PzZTbrIKMMGNE7w/e3hI
YS6mecQTxYxQogxOIEmrlcrHitjYBUrFCuvUH5cT/NowvwoFT5g3oYYbbrwmCN2mkCcD
iiZQ==
X-Gm-Message-State: AD7BkJI9Z0sBrBkSr5pN5vdQcaLx8iZVKkIoM+MfcrIyNJQgo/O9EODX6rJPVTOuX9Ai7c/6
X-Received: by 10.28.15.211 with SMTP id 202mr16003459wmp.31.1459844736278;
Tue, 05 Apr 2016 01:25:36 -0700 (PDT)
Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91])
by smtp.gmail.com with ESMTPSA id js8sm33173561wjc.37.2016.04.05.01.25.35
(version=TLSv1/SSLv3 cipher=OTHER);
Tue, 05 Apr 2016 01:25:35 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: dev@dpdk.org, "Xie, Huawei" <huawei.xie@intel.com>,
"yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
"adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>
Date: Tue, 05 Apr 2016 10:23:58 +0200
Message-ID: <2122802.lhySAYkBc9@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <C14CF1D5-BC76-4447-A795-355E9652D7F0@intel.com>
References: <1459538419-81284-1-git-send-email-keith.wiles@intel.com>
<22459074.ccNYgpjxy1@xps13> <C14CF1D5-BC76-4447-A795-355E9652D7F0@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] gcc compiler option -Og warnings fix
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2016 08:25:36 -0000
2016-04-04 23:03, Wiles, Keith:
> >2016-04-01 14:20, Keith Wiles:
> >> The new compiler option -Og causes a few warning on variables
> >> being used before being set warnings.
> >
> >Sometimes the compiler is wrong. It seems this option makes it
> >even wronger. Why not use -Wno-error with -Og?
>
> Did you want me to make these changes or just request everyone to use -Wno-error with -Og?
I was suggesting that everyone can use -Wno-error when using -Og.
> If you want a new patch from me on these changes it will be
> toward the weekend after I get back home from traveling.
If some driver maintainers think there are some things to fix,
they are free to send a patch by themselves before the end of the week.
> >More details below:
> >
> >> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 2 +-
> >> lib/librte_lpm/rte_lpm6.c | 1 +
> >> lib/librte_vhost/vhost_rxtx.c | 4 ++--
> >
> >There are also some warnings in mlx drivers, solved with patch below:
> >
> >--- a/drivers/net/mlx4/mlx4.c
> >+++ b/drivers/net/mlx4/mlx4.c
> >@@ -5415,7 +5415,7 @@ mlx4_pci_devinit(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> > int err = 0;
> > struct ibv_context *attr_ctx = NULL;
> > struct ibv_device_attr device_attr;
> >- unsigned int vf;
> >+ unsigned int vf = 0;
> > int idx;
> > int i;
> >
> >--- a/drivers/net/mlx5/mlx5.c
> >+++ b/drivers/net/mlx5/mlx5.c
> >@@ -260,8 +260,8 @@ mlx5_pci_devinit(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
> > int err = 0;
> > struct ibv_context *attr_ctx = NULL;
> > struct ibv_device_attr device_attr;
> >- unsigned int vf;
> >- unsigned int mps;
> >+ unsigned int vf = 0;
> >+ unsigned int mps = 0;
> > int idx;
> > int i;
> >
> >> --- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> >> +++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
> >> @@ -152,7 +152,7 @@ pci_get_uio_dev(struct rte_pci_device *dev, char *dstbuf,
> >> unsigned int buflen, int create)
> >> {
> >> struct rte_pci_addr *loc = &dev->addr;
> >> - unsigned int uio_num;
> >> + unsigned int uio_num = 0;
> >
> >This one is OK to fix.
> >
> >> --- a/lib/librte_lpm/rte_lpm6.c
> >> +++ b/lib/librte_lpm/rte_lpm6.c
> >> @@ -381,6 +381,7 @@ add_step(struct rte_lpm6 *lpm, struct rte_lpm6_tbl_entry *tbl,
> >> int8_t bitshift;
> >> uint8_t bits_covered;
> >>
> >> + *tbl_next = NULL;
> >> /*
> >> * Calculate index to the table based on the number and position
> >> * of the bytes being inspected in this step.
> >
> >It would be more logical to set this variable in the right condition branch:
> >--- a/lib/librte_lpm/rte_lpm6.c
> >+++ b/lib/librte_lpm/rte_lpm6.c
> >@@ -429,6 +429,7 @@ add_step(struct rte_lpm6 *lpm, struct rte_lpm6_tbl_entry *tbl,
> > }
> > }
> >
> >+ *tbl_next = NULL;
> > return 0;
> > }
> >
> >> --- a/lib/librte_vhost/vhost_rxtx.c
> >> +++ b/lib/librte_vhost/vhost_rxtx.c
> >> @@ -295,7 +295,7 @@ virtio_dev_rx(struct virtio_net *dev, uint16_t queue_id,
> >> for (i = 0; i < count; i++) {
> >> uint16_t desc_idx = desc_indexes[i];
> >> uint16_t used_idx = (res_start_idx + i) & (vq->size - 1);
> >> - uint32_t copied;
> >> + uint32_t copied = 0;
> >
> >This variable is not used if copy_mbuf_to_desc fails, so it is always
> >initialised before being used.
> >We can workaround the silly compiler while avoiding a performance hit
> >by resetting the variable only in the error case of copy_mbuf_to_desc:
> >
> >--- a/lib/librte_vhost/vhost_rxtx.c
> >+++ b/lib/librte_vhost/vhost_rxtx.c
> >@@ -147,8 +147,10 @@ copy_mbuf_to_desc(struct virtio_net *dev, struct vhost_virtqueue *vq,
> > struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0, 0, 0, 0, 0, 0}, 0};
> >
> > desc = &vq->desc[desc_idx];
> >- if (unlikely(desc->len < vq->vhost_hlen))
> >+ if (unlikely(desc->len < vq->vhost_hlen)) {
> >+ *copied = 0;
> > return -1;
> >+ }
> >
> >> err = copy_mbuf_to_desc(dev, vq, pkts[i], desc_idx, &copied);
> >> @@ -531,7 +531,7 @@ virtio_dev_merge_rx(struct virtio_net *dev, uint16_t queue_id,
> >> {
> >> struct vhost_virtqueue *vq;
> >> uint32_t pkt_idx = 0, nr_used = 0;
> >> - uint16_t start, end;
> >> + uint16_t start = 0, end = 0;
> >
> >I don't understand this one because the variables are not used if
> >reserve_avail_buf_mergeable fails.
> >I don't see any smart workaround.
> >Huawei, Yuanhan, can we expect a little slowdown with this change?
> >
> >
>
>
> Regards,
> Keith
>
>
>
>