From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id 78029AD96
 for <dev@dpdk.org>; Tue,  7 Jun 2016 22:30:33 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id v199so35643979wmv.0
 for <dev@dpdk.org>; Tue, 07 Jun 2016 13:30:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=RS6RESP45nEkk/70GGfI7C+JiJ1jUctSdnFegcWhQTo=;
 b=nI40RinX1504aorHGAqT998SY6lpwYkgmXTPTPbDdpHyApyEO6PCI3JIR2VXwxBi4m
 qmhsWT8xU0n384GVJa8/SVDS78rkTAohRtwWYL+SrNSJBrajt+YXg8wneyryntBC4o5I
 c7QqPDKXtmmQN1buP3c1zZnHecoXL/kvgY5WOT6fIm+f1xNBdr2PWh6o4mu12SZeGU0i
 o78sgMHdF6cyLq9JAJk6YbMNl3oTws/xJIklZNqglS/9wt0YEHv/2UF/93rDWwUUd96e
 yUTOm3sGRau351x8sPwi75cMLmzaev2gr94/vjlbdE0+qUxpfxSYgjeLhE1Q4FOJvjBH
 f2lg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=RS6RESP45nEkk/70GGfI7C+JiJ1jUctSdnFegcWhQTo=;
 b=Q2A++MqtZnIJE/6b7xRJq5dxi2kwJ2hUNoeqJ/bdi28Dnw31kswzg8mORWgU+751Vs
 dLxi1KkFohXkilQ6ior7R9IIb0PLoNtXqa9GjtbfUEkSoMcP5tN6WbBGXGWFimaz9QOe
 YhgXBDrGImzxsVu3eyOnqVlwwi3bgeA0rquUNQRhsrV+6sP2nPmyJiyowUBTCdbh1vYG
 lMWNNbNyorwrk1dXE11FCNGx5LQhuVZUMk3OqAQDljNp0j048Uz5s5lSqvYI0WznwAnu
 hWr+DRceFUuztQFJMWI7mYwkK5616JnPff3dYQarD2XTO3+t/0+/8XDgIWK53P0BOwYP
 iwfA==
X-Gm-Message-State: ALyK8tJwnQR1UKWs/EOou1cb054MWCNEwmvJ3iPQPfBA1Xax6glpN9kBdQJLc+OMaCZilmhT
X-Received: by 10.28.228.137 with SMTP id b131mr4259900wmh.43.1465331433221;
 Tue, 07 Jun 2016 13:30:33 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id b201sm21095952wmb.9.2016.06.07.13.30.32
 (version=TLSv1/SSLv3 cipher=OTHER);
 Tue, 07 Jun 2016 13:30:32 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com
Date: Tue, 07 Jun 2016 22:30:31 +0200
Message-ID: <21237364.CLn9ZV8ln9@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com>
References: <1464183292-24280-1-git-send-email-piotrx.t.azarewicz@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1 1/1] examples/l2fwd-crypto: improve random
	key generator
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 07 Jun 2016 20:30:33 -0000

2016-05-25 15:34, Piotr Azarewicz:
> This patch improve generate_random_key() function by replacing rand()
> function with reading from /dev/urandom.
> 
> CID 120136 : Calling risky function (DC.WEAK_CRYPTO)
> dont_call: rand should not be used for security related applications, as
> linear congruential algorithms are too easy to break
> 
> Coverity issue: 120136
> 
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> ---
>  examples/l2fwd-crypto/main.c |   18 +++++++++++++-----

Is it relevant for this example?