From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yskoh@mellanox.com>
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr40061.outbound.protection.outlook.com [40.107.4.61])
 by dpdk.org (Postfix) with ESMTP id 98822A49
 for <dev@dpdk.org>; Thu,  2 May 2019 07:40:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AsHb5IuMGulziWX+tzKyLrCkhgCiriuVdDugFzzsAxo=;
 b=qKmiYxaN32QWej6sgfuZOA9S/atnvgQEf16+dok5Skoh2uXRALELMgZEiiZ/C2GYRiC+JQ+DrHXcoFmTpZkcvq+hK6dJGBjKun9s3bTgtdKgrIHEb6dxTZA+LJHTIjZFxXl2aUOxRFJnuOMynpFGvIGgDtiDMpXA+WogNMJOYK4=
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by
 DB3PR0502MB4010.eurprd05.prod.outlook.com (52.134.66.28) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1856.11; Thu, 2 May 2019 05:40:54 +0000
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com
 ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com
 ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Thu, 2 May 2019
 05:40:54 +0000
From: Yongseok Koh <yskoh@mellanox.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
CC: "jerinj@marvell.com" <jerinj@marvell.com>, Shahaf Shuler
 <shahafs@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org"
 <dev@dpdk.org>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>, "Gavin Hu (Arm
 Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com>
Thread-Topic: [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox
 BlueField
Thread-Index: AQHVAJ07JM4YifiGB0OR6FVB7QQ096ZXUfoA
Date: Thu, 2 May 2019 05:40:53 +0000
Message-ID: <21250682-EB2E-4F14-B75F-F09E1807C112@mellanox.com>
References: <20190502015806.41497-1-yskoh@mellanox.com>
 <20190502015806.41497-2-yskoh@mellanox.com>
 <VE1PR08MB5149C466877B36D655F6B81298340@VE1PR08MB5149.eurprd08.prod.outlook.com>
In-Reply-To: <VE1PR08MB5149C466877B36D655F6B81298340@VE1PR08MB5149.eurprd08.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=yskoh@mellanox.com; 
x-originating-ip: [69.181.245.183]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 23a7bf47-da8c-4acf-b0f1-08d6cec0be4b
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);
 SRVR:DB3PR0502MB4010; 
x-ms-traffictypediagnostic: DB3PR0502MB4010:
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-microsoft-antispam-prvs: <DB3PR0502MB40101F96FA3C8643B39C630FC3340@DB3PR0502MB4010.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0025434D2D
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(396003)(376002)(366004)(346002)(39860400002)(136003)(189003)(199004)(33656002)(11346002)(2616005)(446003)(81166006)(476003)(229853002)(6512007)(486006)(36756003)(6486002)(81156014)(26005)(8936002)(186003)(53546011)(8676002)(6506007)(2906002)(82746002)(6436002)(256004)(102836004)(14444005)(6116002)(53936002)(3846002)(5660300002)(86362001)(6246003)(76116006)(76176011)(25786009)(4326008)(7736002)(478600001)(6916009)(91956017)(305945005)(99286004)(14454004)(73956011)(71200400001)(71190400001)(83716004)(54906003)(66066001)(316002)(68736007)(66446008)(66556008)(66476007)(64756008)(66946007);
 DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4010;
 H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: G6AgycOVPjA56NDwxgWbkiePBRxVPhDEfKOFlCXiB7nvdpwkZySq0+BIVcaqmLoV/ZtGi/ROVuHR0ZeKk8h19ryE8uSrfKzUeqAwNp7NP1RLmLILuChrgg/WXNTgXWIC5PkIoLU6RW1SinI/+0s706hvYwUK9z+6+L/nrT3yMTo7z7p7MTE1ZEmENRQaaGlR6LZuojzdQSDvXNy7zlClVaVBSbM60S9KIiVLa9uffo8FEfNQTDWZm62wKXBEbrZQyqqDZL4C4a8+0Mz4hxBKP14MHul9T2926biUGez6kqiBdeOBUat3h84JwMAd3nWxTKTU1TQUiz1zb1i93B6JqMTb1TMu3r7GUD52yTueNy+m0/VsVTSikTnAEQ5SZOQBicDA4j8Jx8laCn0Ms2U962MoiX5OmRonbOuNoQCjPZo=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <567DB6A91800864DA886B306B4E10D67@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23a7bf47-da8c-4acf-b0f1-08d6cec0be4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2019 05:40:53.9737 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4010
Subject: Re: [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for
 Mellanox BlueField
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 May 2019 05:40:56 -0000

> On May 1, 2019, at 9:12 PM, Honnappa Nagarahalli <Honnappa.Nagarahalli@ar=
m.com> wrote:
>=20
>>=20
>> Mellanox BlueField has a variant which doesn't have armv8 crypto extensi=
on.
>> If crypto enabled binary runs on such a pltform, rte_eal_init() fails. T=
o have
>> binary compatibility across multiple variants, it is disabled by default=
 and can
>> be enabled for crypto enabled parts.
>>=20
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> ---
>> config/defconfig_arm64-bluefield-linuxapp-gcc | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>=20
>> diff --git a/config/defconfig_arm64-bluefield-linuxapp-gcc
>> b/config/defconfig_arm64-bluefield-linuxapp-gcc
>> index b496538819..6da9c2026d 100644
>> --- a/config/defconfig_arm64-bluefield-linuxapp-gcc
>> +++ b/config/defconfig_arm64-bluefield-linuxapp-gcc
>> @@ -10,6 +10,12 @@ CONFIG_RTE_ARCH_ARM_TUNE=3D"cortex-a72"
>> CONFIG_RTE_MAX_NUMA_NODES=3D1
>> CONFIG_RTE_CACHE_LINE_SIZE=3D64
>>=20
>> +# Crypto extension of armv8
>> +#
>> +# Disabled by default for binary compatibility.
>> +# Can be enabled for crypto-enabled parts.
>> +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=3Dn
> How do you plan to support the Bluefield devices with crypto enabled? Do =
you plan to add another config?

Nope, user will have to enable it by modifying this file or specifying it i=
n make command line.
This is just to provide the default which can make majority of cases work w=
ell.
For example, by default, mlx4/5 are even disabled in default x86 build conf=
ig because
not all users have drv/lib installed on their system. Users have to enable =
it if they want.

>> +
>> # UMA architecture
>> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=3Dn
>> CONFIG_RTE_LIBRTE_VHOST_NUMA=3Dn
>> --
>> 2.11.0

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 3A7C1A0AC5
	for <public@inbox.dpdk.org>; Thu,  2 May 2019 07:40:59 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 24C48B62;
	Thu,  2 May 2019 07:40:58 +0200 (CEST)
Received: from EUR03-DB5-obe.outbound.protection.outlook.com
 (mail-eopbgr40061.outbound.protection.outlook.com [40.107.4.61])
 by dpdk.org (Postfix) with ESMTP id 98822A49
 for <dev@dpdk.org>; Thu,  2 May 2019 07:40:56 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=AsHb5IuMGulziWX+tzKyLrCkhgCiriuVdDugFzzsAxo=;
 b=qKmiYxaN32QWej6sgfuZOA9S/atnvgQEf16+dok5Skoh2uXRALELMgZEiiZ/C2GYRiC+JQ+DrHXcoFmTpZkcvq+hK6dJGBjKun9s3bTgtdKgrIHEb6dxTZA+LJHTIjZFxXl2aUOxRFJnuOMynpFGvIGgDtiDMpXA+WogNMJOYK4=
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com (52.134.72.27) by
 DB3PR0502MB4010.eurprd05.prod.outlook.com (52.134.66.28) with Microsoft SMTP
 Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.1856.11; Thu, 2 May 2019 05:40:54 +0000
Received: from DB3PR0502MB3980.eurprd05.prod.outlook.com
 ([fe80::e8d5:4aff:902d:6e98]) by DB3PR0502MB3980.eurprd05.prod.outlook.com
 ([fe80::e8d5:4aff:902d:6e98%5]) with mapi id 15.20.1856.008; Thu, 2 May 2019
 05:40:54 +0000
From: Yongseok Koh <yskoh@mellanox.com>
To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
CC: "jerinj@marvell.com" <jerinj@marvell.com>, Shahaf Shuler
 <shahafs@mellanox.com>, Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org"
 <dev@dpdk.org>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
 "pbhagavatula@marvell.com" <pbhagavatula@marvell.com>, "Gavin Hu (Arm
 Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com>
Thread-Topic: [PATCH 2/2] mk: disable armv8 crypto extension for Mellanox
 BlueField
Thread-Index: AQHVAJ07JM4YifiGB0OR6FVB7QQ096ZXUfoA
Date: Thu, 2 May 2019 05:40:53 +0000
Message-ID: <21250682-EB2E-4F14-B75F-F09E1807C112@mellanox.com>
References: <20190502015806.41497-1-yskoh@mellanox.com>
 <20190502015806.41497-2-yskoh@mellanox.com>
 <VE1PR08MB5149C466877B36D655F6B81298340@VE1PR08MB5149.eurprd08.prod.outlook.com>
In-Reply-To: <VE1PR08MB5149C466877B36D655F6B81298340@VE1PR08MB5149.eurprd08.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=yskoh@mellanox.com; 
x-originating-ip: [69.181.245.183]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 23a7bf47-da8c-4acf-b0f1-08d6cec0be4b
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0; PCL:0;
 RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);
 SRVR:DB3PR0502MB4010; 
x-ms-traffictypediagnostic: DB3PR0502MB4010:
x-ld-processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr
x-microsoft-antispam-prvs: <DB3PR0502MB40101F96FA3C8643B39C630FC3340@DB3PR0502MB4010.eurprd05.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8882;
x-forefront-prvs: 0025434D2D
x-forefront-antispam-report: SFV:NSPM;
 SFS:(10009020)(396003)(376002)(366004)(346002)(39860400002)(136003)(189003)(199004)(33656002)(11346002)(2616005)(446003)(81166006)(476003)(229853002)(6512007)(486006)(36756003)(6486002)(81156014)(26005)(8936002)(186003)(53546011)(8676002)(6506007)(2906002)(82746002)(6436002)(256004)(102836004)(14444005)(6116002)(53936002)(3846002)(5660300002)(86362001)(6246003)(76116006)(76176011)(25786009)(4326008)(7736002)(478600001)(6916009)(91956017)(305945005)(99286004)(14454004)(73956011)(71200400001)(71190400001)(83716004)(54906003)(66066001)(316002)(68736007)(66446008)(66556008)(66476007)(64756008)(66946007);
 DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4010;
 H:DB3PR0502MB3980.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en;
 PTR:InfoNoRecords; MX:1; A:1; 
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: G6AgycOVPjA56NDwxgWbkiePBRxVPhDEfKOFlCXiB7nvdpwkZySq0+BIVcaqmLoV/ZtGi/ROVuHR0ZeKk8h19ryE8uSrfKzUeqAwNp7NP1RLmLILuChrgg/WXNTgXWIC5PkIoLU6RW1SinI/+0s706hvYwUK9z+6+L/nrT3yMTo7z7p7MTE1ZEmENRQaaGlR6LZuojzdQSDvXNy7zlClVaVBSbM60S9KIiVLa9uffo8FEfNQTDWZm62wKXBEbrZQyqqDZL4C4a8+0Mz4hxBKP14MHul9T2926biUGez6kqiBdeOBUat3h84JwMAd3nWxTKTU1TQUiz1zb1i93B6JqMTb1TMu3r7GUD52yTueNy+m0/VsVTSikTnAEQ5SZOQBicDA4j8Jx8laCn0Ms2U962MoiX5OmRonbOuNoQCjPZo=
Content-Type: text/plain; charset="UTF-8"
Content-ID: <567DB6A91800864DA886B306B4E10D67@eurprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Mellanox.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 23a7bf47-da8c-4acf-b0f1-08d6cec0be4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2019 05:40:53.9737 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4010
Subject: Re: [dpdk-dev] [PATCH 2/2] mk: disable armv8 crypto extension for
 Mellanox BlueField
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190502054053.utzKUauoJeKAUiG6upiSrDSr5pagK5o_xsMhYktVQf8@z>

> On May 1, 2019, at 9:12 PM, Honnappa Nagarahalli <Honnappa.Nagarahalli@ar=
m.com> wrote:
>=20
>>=20
>> Mellanox BlueField has a variant which doesn't have armv8 crypto extensi=
on.
>> If crypto enabled binary runs on such a pltform, rte_eal_init() fails. T=
o have
>> binary compatibility across multiple variants, it is disabled by default=
 and can
>> be enabled for crypto enabled parts.
>>=20
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> ---
>> config/defconfig_arm64-bluefield-linuxapp-gcc | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>=20
>> diff --git a/config/defconfig_arm64-bluefield-linuxapp-gcc
>> b/config/defconfig_arm64-bluefield-linuxapp-gcc
>> index b496538819..6da9c2026d 100644
>> --- a/config/defconfig_arm64-bluefield-linuxapp-gcc
>> +++ b/config/defconfig_arm64-bluefield-linuxapp-gcc
>> @@ -10,6 +10,12 @@ CONFIG_RTE_ARCH_ARM_TUNE=3D"cortex-a72"
>> CONFIG_RTE_MAX_NUMA_NODES=3D1
>> CONFIG_RTE_CACHE_LINE_SIZE=3D64
>>=20
>> +# Crypto extension of armv8
>> +#
>> +# Disabled by default for binary compatibility.
>> +# Can be enabled for crypto-enabled parts.
>> +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=3Dn
> How do you plan to support the Bluefield devices with crypto enabled? Do =
you plan to add another config?

Nope, user will have to enable it by modifying this file or specifying it i=
n make command line.
This is just to provide the default which can make majority of cases work w=
ell.
For example, by default, mlx4/5 are even disabled in default x86 build conf=
ig because
not all users have drv/lib installed on their system. Users have to enable =
it if they want.

>> +
>> # UMA architecture
>> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=3Dn
>> CONFIG_RTE_LIBRTE_VHOST_NUMA=3Dn
>> --
>> 2.11.0