From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enic: fix warnings
Date: Wed, 03 Dec 2014 16:05:16 +0100 [thread overview]
Message-ID: <2126129.v20IaaVbE9@xps13> (raw)
In-Reply-To: <D0A4DD27.2962A%ssujith@cisco.com>
2014-12-03 14:52, Sujith Sankar:
>
> On 02/12/14 8:29 pm, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
>
> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set
> >in the Makefile. But they appear with toolchains that enforce more checks.
> >
> >-Wno-deprecated seems useless.
> >-Wno-strict-aliasing is added to avoid false positives.
> >
> >This patch cleans up unused variable, unused functions, wrong types,
> >static declarations, etc. A lot of functions have unused parameters;
> >it suggests that more clean-up could be needed.
>
> I shall look at it when I pull these changes to my repo.
> What other toolchains did you check with?
It's tested with many distributions, example CentOS 6.
But adding the warnings as in this patch should be enough to test with
any toolchain.
--
Thomas
next prev parent reply other threads:[~2014-12-03 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 14:59 Thomas Monjalon
2014-12-03 14:52 ` Sujith Sankar (ssujith)
2014-12-03 15:05 ` Thomas Monjalon [this message]
2014-12-03 15:10 ` Sujith Sankar (ssujith)
2014-12-04 12:06 ` Thomas Monjalon
2014-12-04 10:29 ` Sujith Sankar (ssujith)
2014-12-04 10:48 ` Thomas Monjalon
2014-12-04 10:58 ` Sujith Sankar (ssujith)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2126129.v20IaaVbE9@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).