From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com
 [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 96A778041
 for <dev@dpdk.org>; Wed,  3 Dec 2014 16:05:42 +0100 (CET)
Received: by mail-wi0-f170.google.com with SMTP id bs8so33283381wib.3
 for <dev@dpdk.org>; Wed, 03 Dec 2014 07:05:42 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=LyRPqvmIpaM/08SgTGpumelQd9FcvKfY90KJIV0MQrE=;
 b=Sg+8Wsyyt8MpGS5lh4lIM2wQ9ECSHaQIxmoz+IkBRISoQ+jb1Max7DbWHDDZ04pVVl
 QsQhfOhwaMyLuorXYjXXVqC8wS/WDM/7F7jKym87as1VGHJa2yAShmdcEcD3D3Dcvnlr
 r6ouxGKry9OKJslm3Nv3nrWqTwz60HFDHh+bn3EYbxoQk44xjvPpT2Nhx/aM9FA5ncnI
 zgeufyi6ZvjP2xmYi1u6y3esrbKRW+SeXHyqkm7bFBVwqv1ZhgmkeI1KsqzpeYxGzP95
 xTzXyIubvOTjd0/wWZdleJ/OFT6WjwepkVc7It+Kd748pTgPO7cmeOKnYUAcXbFAaiQa
 oluA==
X-Gm-Message-State: ALoCoQnQNSMqbgiiYSvGgObZqELzyTMjQI9ATGhbJi/RmtNili/eE5q8V+MuL6VpEiuc3rFOYY24
X-Received: by 10.180.82.226 with SMTP id l2mr3579466wiy.61.1417619142423;
 Wed, 03 Dec 2014 07:05:42 -0800 (PST)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id w4sm36631192wjw.39.2014.12.03.07.05.41
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 03 Dec 2014 07:05:41 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Sujith Sankar (ssujith)" <ssujith@cisco.com>
Date: Wed, 03 Dec 2014 16:05:16 +0100
Message-ID: <2126129.v20IaaVbE9@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <D0A4DD27.2962A%ssujith@cisco.com>
References: <1417532360-8568-1-git-send-email-thomas.monjalon@6wind.com>
 <D0A4DD27.2962A%ssujith@cisco.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enic: fix warnings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Dec 2014 15:05:42 -0000

2014-12-03 14:52, Sujith Sankar:
> 
> On 02/12/14 8:29 pm, "Thomas Monjalon" <thomas.monjalon@6wind.com> wrote:
> 
> >A lot of warnings were not seen because $(WERROR_FLAGS) was not set
> >in the Makefile. But they appear with toolchains that enforce more checks.
> >
> >-Wno-deprecated seems useless.
> >-Wno-strict-aliasing is added to avoid false positives.
> >
> >This patch cleans up unused variable, unused functions, wrong types,
> >static declarations, etc. A lot of functions have unused parameters;
> >it suggests that more clean-up could be needed.
> 
> I shall look at it when I pull these changes to my repo.
> What other toolchains did you check with?

It's tested with many distributions, example CentOS 6.
But adding the warnings as in this patch should be enough to test with
any toolchain.

-- 
Thomas