* [dpdk-dev] [PATCH 1/3] test/compress: fix missing header include
2019-02-25 15:23 [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds Bruce Richardson
@ 2019-02-25 15:23 ` Bruce Richardson
2019-02-25 15:23 ` [dpdk-dev] [PATCH 2/3] examples/ip_pipeline: disable build when no epoll Bruce Richardson
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2019-02-25 15:23 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
usleep() is defined in unistd.h, which is missing from include list
in test_compressdev.c, causing compiler errors on FreeBSD.
CC: stable@dpdk.org
Fixes: b06aa643cac4 ("test/compress: add initial unit tests")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
test/test/test_compressdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c
index e8476edd2..13cf26c9a 100644
--- a/test/test/test_compressdev.c
+++ b/test/test/test_compressdev.c
@@ -4,6 +4,7 @@
#include <string.h>
#include <zlib.h>
#include <math.h>
+#include <unistd.h>
#include <rte_cycles.h>
#include <rte_malloc.h>
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 2/3] examples/ip_pipeline: disable build when no epoll
2019-02-25 15:23 [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds Bruce Richardson
2019-02-25 15:23 ` [dpdk-dev] [PATCH 1/3] test/compress: fix missing header include Bruce Richardson
@ 2019-02-25 15:23 ` Bruce Richardson
2019-02-25 15:23 ` [dpdk-dev] [PATCH 3/3] examples/vhost_crypto: fix dependency on vhost library Bruce Richardson
2019-02-26 15:29 ` [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds Thomas Monjalon
3 siblings, 0 replies; 6+ messages in thread
From: Bruce Richardson @ 2019-02-25 15:23 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
The ip_pipeline example requires the epoll.h header from linux, so
disable building the example if the header cannot be found.
CC: stable@dpdk.org
Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
examples/ip_pipeline/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/ip_pipeline/meson.build b/examples/ip_pipeline/meson.build
index 5e5fe6479..664223c97 100644
--- a/examples/ip_pipeline/meson.build
+++ b/examples/ip_pipeline/meson.build
@@ -6,6 +6,7 @@
# To build this example as a standalone application with an already-installed
# DPDK instance, use 'make'
+build = cc.has_header('sys/epoll.h')
deps += ['pipeline', 'bus_pci']
allow_experimental_apis = true
sources = files(
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 3/3] examples/vhost_crypto: fix dependency on vhost library
2019-02-25 15:23 [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds Bruce Richardson
2019-02-25 15:23 ` [dpdk-dev] [PATCH 1/3] test/compress: fix missing header include Bruce Richardson
2019-02-25 15:23 ` [dpdk-dev] [PATCH 2/3] examples/ip_pipeline: disable build when no epoll Bruce Richardson
@ 2019-02-25 15:23 ` Bruce Richardson
2019-02-25 16:24 ` Maxime Coquelin
2019-02-26 15:29 ` [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds Thomas Monjalon
3 siblings, 1 reply; 6+ messages in thread
From: Bruce Richardson @ 2019-02-25 15:23 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson, stable
The vhost_crypto example app can't be used without the DPDK vhost
library, so disable the build of the example if the lib hasn't been
built.
CC: stable@dpdk.org
Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
examples/vhost_crypto/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/examples/vhost_crypto/meson.build b/examples/vhost_crypto/meson.build
index daf19fb87..8e9860f03 100644
--- a/examples/vhost_crypto/meson.build
+++ b/examples/vhost_crypto/meson.build
@@ -6,6 +6,7 @@
# To build this example as a standalone application with an already-installed
# DPDK instance, use 'make'
+build = dpdk_conf.has('RTE_LIBRTE_VHOST')
allow_experimental_apis = true
deps += ['vhost', 'cryptodev']
cflags += ['-D_FILE_OFFSET_BITS=64']
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 3/3] examples/vhost_crypto: fix dependency on vhost library
2019-02-25 15:23 ` [dpdk-dev] [PATCH 3/3] examples/vhost_crypto: fix dependency on vhost library Bruce Richardson
@ 2019-02-25 16:24 ` Maxime Coquelin
0 siblings, 0 replies; 6+ messages in thread
From: Maxime Coquelin @ 2019-02-25 16:24 UTC (permalink / raw)
To: Bruce Richardson, dev; +Cc: stable
On 2/25/19 4:23 PM, Bruce Richardson wrote:
> The vhost_crypto example app can't be used without the DPDK vhost
> library, so disable the build of the example if the lib hasn't been
> built.
>
> CC: stable@dpdk.org
> Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> examples/vhost_crypto/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds
2019-02-25 15:23 [dpdk-dev] [PATCH 0/3] small fixes for FreeBSD builds Bruce Richardson
` (2 preceding siblings ...)
2019-02-25 15:23 ` [dpdk-dev] [PATCH 3/3] examples/vhost_crypto: fix dependency on vhost library Bruce Richardson
@ 2019-02-26 15:29 ` Thomas Monjalon
3 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2019-02-26 15:29 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev
25/02/2019 16:23, Bruce Richardson:
> Set of three one-line fixes to improve the FreeBSD builds, particularly with
> -Dexamples=all set for meson builds.
>
> Bruce Richardson (3):
> test/compress: fix missing header include
> examples/ip_pipeline: disable build when no epoll
> examples/vhost_crypto: fix dependency on vhost library
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread