From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7D1FF2BF3 for ; Tue, 5 Sep 2017 15:50:10 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 2961220CBE; Tue, 5 Sep 2017 09:50:10 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Tue, 05 Sep 2017 09:50:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=ZsoDbHIac6JpWDy Ze9qcz2qYkLu07JE1BFbQsKe3iYs=; b=M/XELTqxkou6xtupSYGfHbAOucB4Ehi bNd0pzYLUDpd1WABGBytn4OQiQrpWjsQsqL2wSQNGQADQG/n2rFNAkzQHkoK2RmU jwhZVdfC8Oyhq7pGvkH0tpkufprwchSbbIpX8l30BGTFJOQyB2U7qOLmVcrltJXt LuOAVXA/p9S4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=ZsoDbHIac6JpWDyZe9qcz2qYkLu07JE1BFbQsKe3iYs=; b=pO5N62DT 9jyOPB1qGNrteiIl0acuGX4m8FNIf4RV20TlX34g2lVH7mLDsqNe1cHSymDDz/r7 XbSrraXutrXRFiFemvBpNB7haEq1urBgQelzauRflWvFUHgRTyS97keLIDYVcAnX fniej1bPWlGKQ7TphjuAAfM5okdcpy7we3g+5vAsHAS7oIK8WXaRrGd3j+5ar14x 1AY7qrolYBqeKx7tk+UISlkTqEtmJoUExYUYgze/ZoFGhDyWro9hp2hle1EKL8bY MFXLvFqFQsXM7Wi9nrmiaMLxdBMbVMyY+6tNZr8HW8XLYnksAx0QsDwqqIIWiANA LSqSb/a1JvcQ7A== X-ME-Sender: X-Sasl-enc: kglrpw2MeE24AMYcZ88YVaoU8/T+KKQrpwGQ57mGydp2 1504619409 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id BAB012444E; Tue, 5 Sep 2017 09:50:09 -0400 (EDT) From: Thomas Monjalon To: Shahaf Shuler Cc: "Ananyev, Konstantin" , dev@dpdk.org Date: Tue, 05 Sep 2017 15:50:08 +0200 Message-ID: <2131636.uY0WNycdMN@xps> In-Reply-To: References: <2601191342CEEE43887BDE71AB9772584F246819@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 4/4] ethdev: add helpers to move to the new offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Sep 2017 13:50:10 -0000 05/09/2017 12:51, Shahaf Shuler: > So looks like we all agree PMDs should report as part of the rte_eth_dev_info_get which offloads are per port and which are per queue. > > Regarding the offloads configuration by application I see 2 options: > 1. have an API to set offloads per port as part of device configure and API to set offloads per queue as part of queue setup > 2. set all offloads as part of queue configuration (per port offloads will be set equally for all queues). In case of a mixed configuration for port offloads PMD will return error. > Such error can be reported on device start. The PMD will traverse the queues and check for conflicts. > > I will focus on the cons, since both achieve the goal: > > Cons of #1: > - Two places to configure offloads. > - Like Thomas mentioned - what about offloads per device? This direction leads to more places to configure the offloads. > > Cons of #2: > - Late error reporting - on device start and not on queue setup. Why not reporting error on queue setup? > I would go with #2. I vote also for #2