From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id E4E429A8A for ; Thu, 16 Apr 2015 10:47:43 +0200 (CEST) Received: by widjs5 with SMTP id js5so6382273wid.1 for ; Thu, 16 Apr 2015 01:47:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=JcjGCkoqgQOx5Mu7c8+nqy2RoGWR2hjKAY+QT4JaQPk=; b=GA5XqK7PKVa/SzRZ8hjnR+sF99ecSG80Cww9a5Q8iOx4hUi6iz4ejuCFxqOO2mY3rL OYvR2d3aYlerDyjgxib3lz8OAvDNBeG8nTfVJjLNm0gccKactswQRtGToyXhbQ0b3VcE E4ZL6P16eKk4thruB4Q0YatNzkq6FleGnXaOApFqB6fRAK8Nh7gEPZTJAF+mTmERmreS +BD8pct57r1S7U05vqSqRDsapkVko16XJ4oevhMGD0/RKrma7vSOWLDoZV/ZYWa5fueN I9VFzgfGg5pptFqmvY+EAo6ZjdG5SGNRzQKfBjwOzxGSO+KprGwawM36ZM8Yl0mHimxx nyqA== X-Gm-Message-State: ALoCoQkAu1yI1zx/cURpgvlSjf5GyZJVQm9sLS7nqQaV/8w9WUikaAf3etN7Hdqv5j//QRz3iVu5 X-Received: by 10.194.60.43 with SMTP id e11mr59662659wjr.36.1429174063747; Thu, 16 Apr 2015 01:47:43 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id hl8sm9385282wjb.38.2015.04.16.01.47.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2015 01:47:43 -0700 (PDT) From: Thomas Monjalon To: Ravi Kerur Date: Thu, 16 Apr 2015 10:46:59 +0200 Message-ID: <2134052.2sEotUrNoM@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1428608412-31191-5-git-send-email-rkerur@gmail.com> References: <1428608301-31033-1-git-send-email-rkerur@gmail.com> <1428608412-31191-1-git-send-email-rkerur@gmail.com> <1428608412-31191-5-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 4/8] Move common functions in eal_timer.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 08:47:44 -0000 2015-04-09 12:40, Ravi Kerur: > Changes in v5 > Rebase to latest code. > > Changes in v4 > Removed extern declaration of eal_tsc_resolution_hz, > instead provided _set_ API. > Make set_tsc_freq_from_clock as wrapper function for BSD. > > Changes in v3 > Changed subject to be more explicit on file name inclusion. > > Changes in v2 > Use common function name set_tsc_freq_from_sysctl for BSD and Linux. > Update comments about its actuality in function declaration. > > Changes in v1 > Move common functions in eal_timer.c to librte_eal/common/ > eal_common_timer.c file. > > Following functions are moved to eal_common_timer.c file > > void rte_delay_us(unsigned us); > uint64_t rte_get_tsc_hz(void); > static void set_tsc_freq_fallback(void); > void set_tsc_freq(void); > > Makefile changes to reflect new file added. > Fix checkpatch warnings and errors. > > Signed-off-by: Ravi Kerur Seems good. Acked-by: Thomas Monjalon Minor nit, a blank line is missing: > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ > +#include