From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 4966212001 for ; Tue, 16 Jan 2018 13:20:45 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 917C420F4A; Tue, 16 Jan 2018 07:20:44 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 16 Jan 2018 07:20:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=cytRkOS048BMUWZWAEaP9dc3zb 2FN+gL1Kd1dp3e0Yo=; b=SjKv78vPGj1ne7bC4fsoTrJG51vXMPY1sjco9mZ8Qi YQkKdIlFB5Tqqf4Qa7XTc4LjMH4t7Kr83VcV/pTzkXVtDV8a4iIfNAPJYfrexdoA vTXESOn9b9QueARlpPBXT5kq5h1MoZUDHVjQyiYNCjNC0zd0617/DxE7ucRc72r1 s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=cytRkO S048BMUWZWAEaP9dc3zb2FN+gL1Kd1dp3e0Yo=; b=UIJmc31frCr8wzcri5Cd9W AOAAMDK/I75GneEaie/mQxDOzByz56H4LTW51GqJTkjGjWh6h8XN8WzTXkGYGsTF vL0d0xPOiyxwfREnwBDJKhnMUJiVjx8r6b9h1rU1GCq0YMUKdX1ivs17MvTxZB4I YGA/ikPAM522KGVlLq3TFs6WiqOEfZpGtillbfFKVgywqkZYx5Qa1LKBNA7JXCvj OSlfVaRZODRIGnRKYEYiPYiodZkeacF4/kUlXy6qhcmzNZ6r+H7EEkyxmxJj1cu8 oW69aqhrjztbjOB+kEpOKhHsnPeyPPJmcjxsZ5/MJ9ua49XUKZRRF8Lq3hJuhIGg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3E96F7E351; Tue, 16 Jan 2018 07:20:44 -0500 (EST) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org Date: Tue, 16 Jan 2018 13:20:12 +0100 Message-ID: <2134391.uA7JBUhxlf@xps> In-Reply-To: <6a6fd300-2523-f50a-3be4-461724a70fe0@intel.com> References: <3f9df1ca17e97b2df560d5af5fa31a778af3263f.1513942728.git.anatoly.burakov@intel.com> <7548056.EcYGU9teXu@xps> <6a6fd300-2523-f50a-3be4-461724a70fe0@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: add function to return number of detected sockets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jan 2018 12:20:45 -0000 16/01/2018 12:56, Burakov, Anatoly: > On 12-Jan-18 11:50 AM, Thomas Monjalon wrote: > > 12/01/2018 12:44, Burakov, Anatoly: > >> On 11-Jan-18 10:20 PM, Thomas Monjalon wrote: > >>> 22/12/2017 13:41, Anatoly Burakov: > >>>> During lcore scan, find maximum socket ID and store it. > >>>> > >>>> Signed-off-by: Anatoly Burakov > >>>> --- > >>>> --- a/lib/librte_eal/common/include/rte_eal.h > >>>> +++ b/lib/librte_eal/common/include/rte_eal.h > >>>> @@ -83,6 +83,7 @@ enum rte_proc_type_t { > >>>> struct rte_config { > >>>> uint32_t master_lcore; /**< Id of the master lcore */ > >>>> uint32_t lcore_count; /**< Number of available logical cores. */ > >>>> + uint32_t numa_node_count; /**< Number of detected NUMA nodes. */ > >>>> uint32_t service_lcore_count;/**< Number of available service cores. */ > >>>> enum rte_lcore_role_t lcore_role[RTE_MAX_LCORE]; /**< State of cores. */ > >>> > >>> isn't it breaking the ABI? > >>> > >>> > >> > >> Yep, you're right, forgot to add that. I didn't expect this to get > >> merged in 18.02 anyway, so v2 will follow. > > > > Please write 18.05 in the subject to show your expectation. > > Thanks > > > > Does it have to be an ABI change though? We can put numa_node_count > after pointer to mem_config, in which case it won't be an ABI break. > Would that be better? Changing the size of a struct which is allocated by the app, is an ABI break. Is your solution changing the size?