From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A8C841B5D7 for ; Fri, 14 Dec 2018 17:41:51 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0BFD2220D8; Fri, 14 Dec 2018 11:41:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 14 Dec 2018 11:41:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rTXx8K56LB6YhsWRxAei7B8Kd0LKo+UtMVwjgVEHKDU=; b=VsWqWmpjt045 dTEx2ddEbcGFhezgLP4CPacGgz0I0FMKwQPjinPt+WUR65BXT+BTkM/NKqrju2pN TX3N1/p9D9dz/BacMFSmcZepOxVLfd9v2AI15CkgtSVoGiLiMf6BKt8HqXHTeVWG PJCqv+oQ8JITOixZOUmmcsfZHsFjDCo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rTXx8K56LB6YhsWRxAei7B8Kd0LKo+UtMVwjgVEHK DU=; b=E3YcwpELQFd2xP58sCUivEWrBS2hwkjD7qSuKKWWxZYe5O1oRAFTFZBLY 4cu+NeTcYGgsXgIBOqBQ8ljQR5RFf4Gve1nO3D+sPsHyMNxFPOhH9wiiRUt3P9LU 6n2Y6mnh5MeYq91lbEuWtjGCzgl7jFqEHVfFPYy/2PLsb8smFG/fUYmZ1J6hXOfx LdKIqYVnLDUxpwbb0B099FZYqFCVHmu8tE20fyRffqhCvfU9+GylXLRpWnHCJ0bA W2OdOzaVhzSvFUm9pm6fLaaMv9vqh8ShxG5LkOQaBEUTRk2LQbDb1THgK2/2F9/G APgCc505aRNK1fVi3dJL/OohYgBVA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudehgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 609CF1026D; Fri, 14 Dec 2018 11:41:49 -0500 (EST) From: Thomas Monjalon To: Ferruh Yigit Cc: Wenzhuo Lu , dev@dpdk.org, Qiming Yang , Xiaoyun Li , Jingjing Wu Date: Fri, 14 Dec 2018 17:41:46 +0100 Message-ID: <2134627.dYyTCR80XC@xps> In-Reply-To: <1db7247c-5332-c344-2304-70a2133fc3d9@intel.com> References: <1542956179-80951-1-git-send-email-wenzhuo.lu@intel.com> <1544776518-91047-31-git-send-email-wenzhuo.lu@intel.com> <1db7247c-5332-c344-2304-70a2133fc3d9@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 30/32] net/ice: support basic RX/TX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Dec 2018 16:41:52 -0000 14/12/2018 14:00, Ferruh Yigit: > On 12/14/2018 8:35 AM, Wenzhuo Lu wrote: > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Qiming Yang > > Signed-off-by: Xiaoyun Li > > Signed-off-by: Jingjing Wu > > <...> > > > + > > + /* Check to make sure the last descriptor to clean is done */ > > + desc_to_clean_to = sw_ring[desc_to_clean_to].last_id; > > + if (!(txd[desc_to_clean_to].cmd_type_offset_bsz & > > + rte_cpu_to_le_64(ICE_TX_DESC_DTYPE_DESC_DONE))) { > > + PMD_TX_FREE_LOG(DEBUG, "TX descriptor %4u is not done " > > + "(port=%d queue=%d) value=0x%lx\n", > > + desc_to_clean_to, > > + txq->port_id, txq->queue_id, > > + txd[desc_to_clean_to].cmd_type_offset_bsz); > > Causing build error for i686 [1], should use PRIx64 for 64bit variables. > > Perhaps we should create a rule in checkpatch to check and warn %lx %lu formats > `git grep -n '%l[xud]' drivers/net/ice/` shows only this occurrence in 'ice' but > there are more in other drivers... If it's clear to everybody that checkpatch can return some false positive, yes I am for checking '%l[xud]'. It is most of the time a mistake.