From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7EC1A43BA9; Fri, 23 Feb 2024 14:55:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12853402E3; Fri, 23 Feb 2024 14:55:22 +0100 (CET) Received: from fout7-smtp.messagingengine.com (fout7-smtp.messagingengine.com [103.168.172.150]) by mails.dpdk.org (Postfix) with ESMTP id 3227C4021E for <dev@dpdk.org>; Fri, 23 Feb 2024 14:55:21 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id A560D1380108; Fri, 23 Feb 2024 08:55:20 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 23 Feb 2024 08:55:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1708696520; x=1708782920; bh=ZexlHG6YtlHaUsFMZgwVS0Fs/ChQU5z4oUML1hrevJI=; b= re/kubhZYOarCNMJ7qc0lmXikqi9/k7aV7m7iOV5ZZ/tyKezh37bv81x7eWFV80Y zXhBdqDCslOP1hd7lqnzmIqrS4CAuH95ZJa4vu3tXuCSI+NLzvP21Qx9xWgETMar MbKKTMiJS+q4TbrxUDlPmyXha2VFosyEGPWFWl/HywdKaGdGyYDJtq44I8CkTiTw 0dit6mBK/v5lHM0nSH5ZBXYF1qIo3y3vD2B4UrxSfg95sL7TZpBl8h0o2uTK8Ap2 5n2ad1X5a8zqTtQu1t92cPxOkDhjFgVf7pR8ZfkL7FgegxqffxvUaHN8CsZerD/c 05+LYZxTJLgeIQdlaar3cA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1708696520; x= 1708782920; bh=ZexlHG6YtlHaUsFMZgwVS0Fs/ChQU5z4oUML1hrevJI=; b=A sJYku8d/6hJo7fiu90OSNM0NdkAwS5I5qda+h0VvmG0v+wrF3viSbbN/NDXV6ynt aXPMcHYAdD0E8miEvXlmJua/MqERByKVweOWT1Dch2LyA1sS3bv9HrltqKWAw0UC OZFfPOQhpmf8t68VAwdb0ItSrKriMKDtbfKHrA7JRMWVeuOSmAd4wDo6WPAbhxwT rnqruBv32diKRdkPptpLyHhSrKiWrydy4kEp9/+ml1iTHPA5Y58GSWepfawobRrd rIWAtx7EZOj0z7OnZnyBjYYtxTe7lfviRAJAf1f/3oLl2Arp5iIeYw/1i+URFKZi sZIfOX9ctSrGuRMOEn2VA== X-ME-Sender: <xms:yKPYZQwMmizMQ2W-_A14DQraqkXt4T1LIAViMtHlR9ZhD3zs7lQD9w> <xme:yKPYZUQFcC-FxRSyZMd-2sT6fz3WhB3UJW3zj9_x_ZTHCUP1ttrebKNkjmyEJpsnS w-vNi4Y154vXu90AA> X-ME-Received: <xmr:yKPYZSWufaG6v6AbaVw1jaAjrG4OCwgvq3Te61Kic9BbRHHP-sHzHwe4VdVTVQOdJYuUicFM8Rr-9RN1Vk-lqjbB8g> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfeeigdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttddunecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepfefhjeeluedvvedtuddtuedtvefhieejtefhffeujefhteduudev tdektdeikeffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:yKPYZejP95Hoyd8WchfQOMwu39t6C7oIMDNcC4upV5vsGRJwlco_3g> <xmx:yKPYZSC6ceFNdRf3WmodqcwbWLdwgzKbY8MfjlxJMI7YbQs3hgdmxQ> <xmx:yKPYZfKbCwFj5NA2_ka5zkDHP8PYsCS2qGl7UBlnct3ZH8Fout6meg> <xmx:yKPYZV_Upg43svfKNtSfJaXY-TiFruFUzI1jane9c6Q-6GoCzFwpRw> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Feb 2024 08:55:19 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>, Ferruh Yigit <ferruh.yigit@amd.com> Cc: david.marchand@redhat.com, dev@dpdk.org Subject: Re: Where to best ack a series Date: Fri, 23 Feb 2024 14:55:18 +0100 Message-ID: <2139196.OBFZWjSADL@thomas> In-Reply-To: <83fdf01b-afcd-41f0-9e12-81e05e7646d1@amd.com> References: <98CBD80474FA8B44BF855DF32C47DC35E9F25C@smartserver.smartshare.dk> <83fdf01b-afcd-41f0-9e12-81e05e7646d1@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 23/02/2024 09:38, Ferruh Yigit: > On 2/23/2024 8:15 AM, Morten Br=F8rup wrote: > > Dear maintainers, > >=20 > > Is it easier for you to spot if we ack a series in patch 0, patch 1, or= the last patch of the series? Or don't you have any preferences? >=20 > When a patch is ack'ed, not cover letter (patch 0), patchwork detects it > and both shows it in the web interface (A/R/T), and automatically adds > it when patch applied from patchwork, so this makes life easy. >=20 > But to ack each patch in a series one by one is noise for mailing list > and overhead for reviewer. For this case I think better to ack whole > series in reply to cover letter, maintainer can apply this manually to > each patch. >=20 > When there is a patch series, but it doesn't have a cover letter, I tend > to reply to patch 1, but I don't think patch 1 or last patch matters, > only to differentiate if the ack is for that patch or whole, I am adding: > ``` > For series, > Acked-by: ... > ``` >=20 > From maintainers perspective this manually adding tags is small enough > work to ignore, but I see authors are impacted too, like if a previous > version cover letter is acked, they are not adding this ack manually to > each patch in next version, requiring reviewer ack the new version again >=20 >=20 > I guess best solution is add this series ack support to patchwork, > it can be either: > - Ack in cover letter automatically add ack to each patch in the series. > or > - Add new "Series-acked-by: " syntax, which if patchwork detects it in > any of patch in the series automatically add ack to each patch in the > series. I agree with all being said by Ferruh. +100