From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] kni: use netif_rx instead of netif_receive_skb in which ocurr deallock on userpace contex
Date: Thu, 17 Jul 2014 14:02:16 +0200 [thread overview]
Message-ID: <2139993.JzhFVyBpua@xps13> (raw)
In-Reply-To: <1405093044-3264-1-git-send-email-blue119@gmail.com>
Hi,
2014-07-11 23:37, Yao-Po Wang:
> Per netif_receive_skb function description, it may only be called from
> interrupt contex, but KNI is run on kthread that like as user-space
> contex. It may occur deallock, if netif_receive_skb called from kthread,
> so it should be repleaced by netif_rx or adding local_bh_disable/enable
> around netif_receive_skb.
>
> Signed-off-by: Yao-Po Wang <blue119@gmail.com>
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> /* Call netif interface */
> - netif_receive_skb(skb);
> + netif_rx(skb);
Is there someone confident to approve this change?
--
Thomas
next prev parent reply other threads:[~2014-07-17 12:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 15:37 Yao-Po Wang
2014-07-17 12:02 ` Thomas Monjalon [this message]
2014-07-17 12:24 ` Alex Markuze
2014-07-19 0:03 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2139993.JzhFVyBpua@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).