From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-we0-f180.google.com (mail-we0-f180.google.com
 [74.125.82.180]) by dpdk.org (Postfix) with ESMTP id 59D7F590F
 for <dev@dpdk.org>; Thu, 17 Jul 2014 14:01:31 +0200 (CEST)
Received: by mail-we0-f180.google.com with SMTP id w61so2629383wes.39
 for <dev@dpdk.org>; Thu, 17 Jul 2014 05:02:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=kJqwGrVufPUGYig7SAwg1+XzdJJuQTobEAA6F4SFr3o=;
 b=eeOxW2GOrsGR+7D3STtdqi3tYGNB6HOYAE9K62L8S2h79a7iiEMQtQVBKUBdNYGX0+
 QcZSULv8nJP3Md+GvjIXkDBJTTBtOSF+v18Obx/J2w682U5DF6Z7WGnhIWUllNlCwv+Z
 AkPSxFOg884xwk/XrqftUGvTxELe8dPjwEw8wowGcnhIDETDWWYKM0PseoLRBTpJlilq
 0O5n5I6zPPpBMN4tLCN3fA/kd6+rgdaKKZxOnN01Jo16BTmQ5wQqJyXo/IUWPbhn3qNV
 ZHx7R30X6CsTPcjJqrlaxNstviA1wV/KVgM2sVR6jsjiM8yD7dd7rlWwG/zh7VYB1nTp
 yOHw==
X-Gm-Message-State: ALoCoQniUUBsbBUyDFc9tGmwoCtm0NDjhsObC1+Timq3g6/WoIGijQ6l9jz8zeW4+JkNS6el3wB0
X-Received: by 10.194.7.36 with SMTP id g4mr44644527wja.37.1405598546131;
 Thu, 17 Jul 2014 05:02:26 -0700 (PDT)
Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net.
 [82.239.227.177])
 by mx.google.com with ESMTPSA id l8sm5663031wje.15.2014.07.17.05.02.23
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 17 Jul 2014 05:02:25 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Date: Thu, 17 Jul 2014 14:02:16 +0200
Message-ID: <2139993.JzhFVyBpua@xps13>
Organization: 6WIND
User-Agent: KMail/4.13.2 (Linux/3.15.5-1-ARCH; KDE/4.13.2; x86_64; ; )
In-Reply-To: <1405093044-3264-1-git-send-email-blue119@gmail.com>
References: <1405093044-3264-1-git-send-email-blue119@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] kni: use netif_rx instead of
	netif_receive_skb in which ocurr deallock on userpace contex
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Jul 2014 12:01:31 -0000

Hi,

2014-07-11 23:37, Yao-Po Wang:
> Per netif_receive_skb function description, it may only be called from
> interrupt contex, but KNI is run on kthread that like as user-space
> contex. It may occur deallock, if netif_receive_skb called from kthread,
> so it should be repleaced by netif_rx or adding local_bh_disable/enable
> around netif_receive_skb.
> 
> Signed-off-by: Yao-Po Wang <blue119@gmail.com>

> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
>  			/* Call netif interface */
> -			netif_receive_skb(skb);
> +			netif_rx(skb);

Is there someone confident to approve this change?

-- 
Thomas