From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CEE9CA10DA
	for <public@inbox.dpdk.org>; Fri,  2 Aug 2019 22:27:36 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 9E33B1C29F;
	Fri,  2 Aug 2019 22:27:35 +0200 (CEST)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 87FDA1C205
 for <dev@dpdk.org>; Fri,  2 Aug 2019 22:27:34 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 1608C21F18;
 Fri,  2 Aug 2019 16:27:34 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Fri, 02 Aug 2019 16:27:34 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=nrLemVAPsVFo74UJloFr8R0vXfKy/xqIxg67wlcSb+k=; b=iURawIekPc0D
 JT0s14cqo77dshYqqt1Gep5jiGThFzAJJtIiYrIdWF0wtXVJ9bI0rOV3teZQ7zML
 0Z+VDR9WkfP3EfDVvzqDzPRNLsHxNDtEN2prkXh7wy9RenZn0kN1Gn52BKehyiPU
 AeXKwE0dHP9D5HYXriihrRuXFRaxzWQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm3; bh=nrLemVAPsVFo74UJloFr8R0vXfKy/xqIxg67wlcSb
 +k=; b=0CB7f9M1cWrzaI90z7us3U0pvw2vSTsncSV4hpAHJwkRAc5N89OdPXzRy
 LJUpmi3sU2V50jYCENy+388h/ArPgeN9NNEZCgBbKVsnAqH5KTQ/dM+qvOW+C6Wd
 VMP9PxTXxEig68y0PUcHcn8vaaFe2qU5Urvn2Vfv9K6+nNG4nzjy4XwkD9THDXGO
 Ts4Ri5C/V5lXke9qLrcKfGpIC5CcjUzc6O5BlhBidrNrwr65mpWKD7rgow+NuG+q
 FeivyAhLBx2uB8C95eeSGiTLTNootunLu9hClERiMx2cdAhq0YnVY1XGy4pWm6RS
 0zlHSnTuijKlsJXpDrBtemhRPCcTA==
X-ME-Sender: <xms:tZxEXenmmUi3GSQUqqaUfAkv96HbZpb9zzdUxYNyapHhA9tvFYyayg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrleelgdduvddvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff
 homhgrihhnpehshhgsrdgtihenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgr
 rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuve
 hluhhsthgvrhfuihiivgeptd
X-ME-Proxy: <xmx:tZxEXTdiaGmFb61UAPPD_jUwRKTbV_S2teclG1nRINzYT_MAu8er7Q>
 <xmx:tZxEXUDNm7WWa8a4wuKAm_woV5ozkWyWH9Lb-w4NTh_T-QD6OCdMmg>
 <xmx:tZxEXayw5daJ3l0dBNpdgQxIWiwa5keYjcYOa0PN1kFB7oe7-q0Fdw>
 <xmx:tpxEXb57r0s0pNAKj-GzI0n0DbIJTAEwpMov61r5Ps89LwfG4T9EUQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 908C180059;
 Fri,  2 Aug 2019 16:27:32 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Aaron Conole <aconole@redhat.com>
Cc: dev@dpdk.org, Michael Santana Francisco <msantana@redhat.com>,
 David Marchand <dmarchan@redhat.com>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>, Luca Boccassi <bluca@debian.org>
Date: Fri, 02 Aug 2019 22:27:31 +0200
Message-ID: <2139994.LeHafPJYVc@xps>
In-Reply-To: <CABzctQ9i9xrG-w4nKefoqbPvOhiO+CWAuHs6njSph-EhwixU4w@mail.gmail.com>
References: <20190731145030.19956-1-aconole@redhat.com>
 <20190731145030.19956-3-aconole@redhat.com>
 <CABzctQ9i9xrG-w4nKefoqbPvOhiO+CWAuHs6njSph-EhwixU4w@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/2] ci: enable unit tests under travis-ci
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

31/07/2019 22:54, Michael Santana Francisco:
> On Wed, Jul 31, 2019 at 10:50 AM Aaron Conole <aconole@redhat.com> wrote:
> > --- a/.ci/linux-build.sh
> > +++ b/.ci/linux-build.sh
> > @@ -22,3 +22,11 @@ fi
> >  OPTS="$OPTS --default-library=$DEF_LIB"
> >  meson build --werror -Dexamples=all $OPTS
> >  ninja -C build
> > +
> > +if [ "$RUN_TESTS" = "1" ]; then
> > +    # On the test build, also build the documentation, since it's expensive
> > +    # and we shouldn't need to build so much of it.
> > +    ninja -C build doc

I am not sure to understand the comment.
Do you mean you build the documentation only once,
which is when running tests?
Why it is not a new option similar as RUN_TESTS?

> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -30,6 +30,7 @@ env:
> >    - DEF_LIB="shared"
> >    - DEF_LIB="static" OPTS="-Denable_kmods=false"
> >    - DEF_LIB="shared" OPTS="-Denable_kmods=false"
> > +  - DEF_LIB="shared" RUN_TESTS=1
> I don't agree with this. This is redundant. Why not put RUN_TESTS=1 on
> an already exiting builds instead of adding two new builds like you
> are doing here?

I agree it is a strange logic.
Why not use an existing build to run the tests?