From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jmiao@redhat.com>
Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com [209.132.183.37])
 by dpdk.org (Postfix) with ESMTP id 0DF82282
 for <dev@dpdk.org>; Wed, 10 Dec 2014 10:39:06 +0100 (CET)
Received: from zmail14.collab.prod.int.phx2.redhat.com
 (zmail14.collab.prod.int.phx2.redhat.com [10.5.83.16])
 by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sBA9d5sC020724;
 Wed, 10 Dec 2014 04:39:05 -0500
Date: Wed, 10 Dec 2014 04:39:05 -0500 (EST)
From: Jincheng Miao <jmiao@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Message-ID: <2140629445.25897578.1418204345008.JavaMail.zimbra@redhat.com>
In-Reply-To: <1474820.EkRfEgf9QI@xps13>
References: <1418182383-5744-1-git-send-email-jmiao@redhat.com>
 <1663200.Cog0FQ0fDE@xps13>
 <957926828.25865702.1418201305408.JavaMail.zimbra@redhat.com>
 <1474820.EkRfEgf9QI@xps13>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.5.82.11]
X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - GC39 (Linux)/8.0.6_GA_5922)
Thread-Topic: replace strict_strtoul with kstrtoul
Thread-Index: 0+rj0qZ4LbzKLkX/dekko3B0lsx8aA==
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/4] kni: replace strict_strtoul with kstrtoul
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Dec 2014 09:39:07 -0000



----- Original Message -----
> 2014-12-10 03:48, Jincheng Miao:
> > > It seems you forgot to include the new compat.h.
> > > 
> > > Did you do some tests with different Fedora/RHEL versions?
> > 
> > Yes, missing compat.h in kni_vhost.c.
> > 
> > 
> > And, I want to get your opinion about adding compat.h to kni and xen_dom0.
> > The pros: easy to implement and minimal wrapper for older kernel.
> 
> Yes I think it's the good approach.
> 
> > The cons: there is so many compat.h, and the file kcompat.h also makes user
> > confuse.
> 
> Why kcompat makes user confuse?

Because a lot of compat fallback in kcompat too.
For example, for kni, there is compat.h and kcompat.h.
I just confuse about it before.
But if you agree it, I will also agree it.

> 
> Do you think you could send a new version quickly to integrate it in the
> next RC (probably today)?
> 
> Please test it with RHEL.

Yes, I am working on it.

I will report my test result latter.

Jincheng Miao

> 
> Thanks
> --
> Thomas
>