From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 94A481BA2E for ; Mon, 29 Jan 2018 19:21:00 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 12EC620FF2; Mon, 29 Jan 2018 13:21:00 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 29 Jan 2018 13:21:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=FRAR2kqJ67bvyTwIKYSa5Nv1XK E2v+FCvNJIhYj6Yi0=; b=md2pYIID1Xn58sZjLk1TNjg7VKWsUffklO+0026XIn /XSMPOCnh3E0Q1SmLQisqRMwRzDjrCyU1s3sh7tAhmrAGbA+4I06IfFguoLmCIoq 7Cy1/CuGKJtRgRco7eQ27O0cP9dcoOZN2j3883qV3DmlVLRRIiDi27W0Dt8UCL3r Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=FRAR2k qJ67bvyTwIKYSa5Nv1XKE2v+FCvNJIhYj6Yi0=; b=lF8pO4rX41AAB0Iq1yUxSA 0wFb9kHyYsqx+x3tNihqSwmCwfVOjJN8kluJ8O3akRfpnt79fxcgeImsIwcTfXY5 dA6QGuURBKkouUwC2HJqFCakHUnUqHTD6z+Xv4mTp6fFhD4sll+UdgCpoOFrVnT7 ABtidIX/HFP+JjUPjK7d3Pg1BhcpkYF5hM8tsrVoexREdmYTZ7xUhdrO/8ZSb4dC O/hyNXtVda584rGlVlTdj/FYptNId+ehgkfuzasEfW3cPs4SnbdSGMiFhnj6CsPq xKMh96AkC6R7KFWLv+FTVCW0vduRBEtsq1ouUpN/MZ+Cqj5ArHD0als9H7pOreqg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id ADE8724805; Mon, 29 Jan 2018 13:20:59 -0500 (EST) From: Thomas Monjalon To: Harry van Haaren Cc: dev@dpdk.org, vipin.varghese@intel.com Date: Mon, 29 Jan 2018 19:20:14 +0100 Message-ID: <2141791.M0NvFpFgTI@xps> In-Reply-To: <1517243852-34142-2-git-send-email-harry.van.haaren@intel.com> References: <1517241642-161397-1-git-send-email-harry.van.haaren@intel.com> <1517243852-34142-1-git-send-email-harry.van.haaren@intel.com> <1517243852-34142-2-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 2/4] eal: add function to release internal resources X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 18:21:00 -0000 29/01/2018 17:37, Harry van Haaren: > @@ -79,6 +80,10 @@ rte_exit(int exit_code, const char *format, ...) > va_end(ap); > > #ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR > + int ret = rte_eal_cleanup(); You should not declare a variable in the middle of the function. Will fix on apply. > + if (ret) > + RTE_LOG(CRIT, EAL, > + "EAL could not release all resources, code %d\n", ret); > exit(exit_code); > #else > rte_dump_stack();