From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 87E3DF1F for ; Wed, 11 Oct 2017 15:14:30 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1CA0321356; Wed, 11 Oct 2017 09:14:30 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 11 Oct 2017 09:14:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=1NJuSi256JZB5wi6ksxB7dmU2V zt2/yq/phWqnZnVco=; b=eOerVB2gerl3qgYFQEsvpoPzcdzwqIUIndDZ+WWI96 DtpWDkkhxu/4JE1JzscyfS9hmTZE2jzyMGW3uZO320a63+xUUnXhGOg9RIPkXxqO ANIS27cWuc0VAooRSb+SxxWtSNMWgTf4yXNQps5jBSpKH7pHA2OXTJ9ydiC2G3k0 Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=1NJuSi 256JZB5wi6ksxB7dmU2Vzt2/yq/phWqnZnVco=; b=SJ8a6iGsOA+GrTxY0ihvCw 2Z5ZpIcv6ZwFHZKx4YVkEakvD4dC/DuliFXWwIMZxriz1YcaCZoRD14SSjVU2ujW Muew3sm7/0trS+MtQj1njMupk4yvn1l8T03FFJw5cDgHa2MtjOADdiKvAH8UARRz H9SvqTBrFrludce38hxngw8jBeGJbUR+pabZW9+zV2lqYwvUJkwD2tMd9FSRCJWl 6VgS8E/PxXIMseLO8+T5n8QzHjFmhqh/rJcgs2sAOPMsbj8ROJbBI8pM0bhLNrqQ asaDD1Sbc8liykG69Zmm7zeLqRAJN+PC6xRaROaD/pY+cNkVkaAdYYc0iJU0dy9g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DE7424735; Wed, 11 Oct 2017 09:14:29 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: Ferruh Yigit , Matan Azrad , dev@dpdk.org Date: Wed, 11 Oct 2017 15:14:28 +0200 Message-ID: <2142367.Av9Mkz2zTi@xps> In-Reply-To: <6b1e8d58-f570-dc28-4705-630788e6a04b@solarflare.com> References: <1507565524-18590-1-git-send-email-matan@mellanox.com> <4271901.RE8S8KQ4zy@xps> <6b1e8d58-f570-dc28-4705-630788e6a04b@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: add return value to stats get dev op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2017 13:14:30 -0000 11/10/2017 15:09, Andrew Rybchenko: > On 10/11/2017 01:46 PM, Thomas Monjalon wrote: > > 11/10/2017 04:09, Ferruh Yigit: > >> On 10/11/2017 3:01 AM, Ferruh Yigit wrote: > >>> On 10/10/2017 9:20 PM, Matan Azrad wrote: > >>>> The stats_get dev op API doesn't include return value, so PMD cannot > >>>> return an error in case of failure at stats getting process time. > >>>> > >>>> Since PCI devices can be removed and there is a time between the > >>>> physical removal to the RMV interrupt, the user may get invalid stats > >>>> without any indication. > >>>> > >>>> This patch changes the stats_get API return value to be int instead of > >>>> void. > >>>> > >>>> All the net PMDs stats_get dev ops are adjusted by this patch. > >>>> > >>>> Signed-off-by: Matan Azrad > >>> Reviewed-by: Ferruh Yigit > >> Applied to dpdk-next-net/master, thanks. > > It is breaking compilation of tests: > > > > test/test/virtual_pmd.c:256:15: fatal error: incompatible pointer types > > initializing 'eth_stats_get_t' (aka 'int (*)(struct rte_eth_dev *, struct rte_eth_stats *)') > > with an expression of type 'void (struct rte_eth_dev *, struct rte_eth_stats *)' > > [-Wincompatible-pointer-types] > > .stats_get = virtual_ethdev_stats_get, > > I've bumped into it this morning as well: > http://dpdk.org/dev/patchwork/patch/30090/ Thank you Andrew. Ferruh, please squash Andrew's patches to avoid any compilation issue.