From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4D61D5F3B
 for <dev@dpdk.org>; Thu, 12 Jul 2018 21:55:07 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id E4DAD223C9;
 Thu, 12 Jul 2018 15:55:06 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 12 Jul 2018 15:55:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=cnler709lhMCa0eC6cWVjDM62Q
 3gQeUWWO6RV91K//8=; b=erKjfPSWXYVQQsDfBN0X/AlG+LgHAIi0arS7j/Rmef
 +3AMUXLDlS8sBFmG9JfLWQWKiauWZukZKG4WdXEV005cFU5oyq29Lt+AwVgzFkmw
 yuwKjEPoK3Hp8p0SuFS3yYg3EnDmZAEreaRcv+76eqWUAN2GxwNxzHcM95YlUQth
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=cnler7
 09lhMCa0eC6cWVjDM62Q3gQeUWWO6RV91K//8=; b=XJ+ipOt9LHL96FIkfU2zbe
 GgJbmtHGLr8pIFA/Ak6K/VufQRuWqxQGqmGzNznz3+htSoL0pPdA0t4iXsM8dLS3
 QSJiU3UWDhkjnitHuMhx6XUHKdIEnADBf7iyQr1k6EIoReRphh47jTft5IQnEeCu
 uq8YZCvqhmMyYLhYhJ89oTia6Jbh0hk6EXZ30zJWzweWRHivwW9Vu7pBaAZVApOk
 0ul+wCqKl/SmgqdUKNwZH6I+zsbPl/CznniNxzN/uuSNtWVHwV4WXRrn1eFR4ekp
 f00DcmgZJ2cX1covhWH/gGPgQpYuOzgzcd8m1sl8raH4lqv+xQ1aCvafsPoH93+w
 ==
X-ME-Proxy: <xmx:GrJHW0oJzeq-nA6nr9MkGONJ-WySREz7-hdd0Oszmxxm9Dc9u9CLWA>
 <xmx:GrJHWwIHaDLzyyQxtrzvJuuBoebFNqVVTMgbYU8Mg8EbWRPwBo44cg>
 <xmx:GrJHW4SZbUmLKAnvsWhhvfriPCisrkBtW1E9dlnExl20CkFF8h69zw>
 <xmx:GrJHWwMD4IJgQ6zmJ6tK6aoZLUK1WqK41ssXK4qYAxlqmEOZIK4bpA>
 <xmx:GrJHW9V4RK8pWI2w9YPKWBx5lOssU8JQveBBSZ_UymJNcXkYAM73DQ>
 <xmx:GrJHWxODm78_Ts_RXrqiCj2sSvGG9FIGZsolQKm7CEuRBkqzmUOp_g>
X-ME-Sender: <xms:GrJHWz-PSJrLXRaaA89ykn5ViQvATLnnN5BaTfc_8JQ_4sCtSMK-2Q>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 06A0910279;
 Thu, 12 Jul 2018 15:55:05 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Date: Thu, 12 Jul 2018 21:55:04 +0200
Message-ID: <2142629.lVosk762JX@xps>
In-Reply-To: <20180612232939.24793-1-stephen@networkplumber.org>
References: <20180612232939.24793-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v11 0/4] Hyper-V/Azure netvsc PMD and bus
	support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Jul 2018 19:55:07 -0000

The old offload API has been removed.
Please could you adapt this PMD to the new API?

The errors are:
=2E./drivers/net/netvsc/hn_ethdev.c:185:4: error: =E2=80=98struct rte_eth_t=
xconf=E2=80=99 has no member named =E2=80=98txq_flags=E2=80=99
=2E./drivers/net/netvsc/hn_ethdev.c:185:16: error: =E2=80=98ETH_TXQ_FLAGS_N=
OXSUMS=E2=80=99 undeclared (first use in this function)
   .txq_flags =3D ETH_TXQ_FLAGS_NOXSUMS,


Some checkpatches warnings are remaining:

### [dpdk-dev] [PATCH v11 2/4] bus/vmbus: add hyper-v virtual bus support

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#353: FILE: drivers/bus/vmbus/linux/vmbus_bus.c:28:
+extern struct rte_vmbus_bus rte_vmbus_bus;

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#2715: FILE: drivers/bus/vmbus/vmbus_common.c:26:
+extern struct rte_vmbus_bus rte_vmbus_bus;

### [dpdk-dev] [PATCH v11 3/4] net/netvsc: add hyper-v netvsc network device

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#519: FILE: drivers/net/netvsc/hn_ethdev.c:189:
+       dev_info->flow_type_rss_offloads
+               =3D ETH_RSS_IPV4 | ETH_RSS_IPV6 | ETH_RSS_TCP | ETH_RSS_UDP;

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#622: FILE: drivers/net/netvsc/hn_ethdev.c:292:
+       const struct rte_eth_rss_conf *rss_conf
+               =3D &dev_conf->rx_adv_conf.rss_conf;

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#632: FILE: drivers/net/netvsc/hn_ethdev.c:302:
+                           "unsupported TX offload: %#" PRIx64,

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#788: FILE: drivers/net/netvsc/hn_ethdev.c:458:
+       const unsigned int nstats
+               =3D dev->data->nb_tx_queues * RTE_DIM(hn_stat_strings)

CHECK:CAMELCASE: Avoid CamelCase: <PRIx32>
#2644: FILE: drivers/net/netvsc/hn_rndis.c:720:
+               PMD_DRV_LOG(ERR, "exec RNDIS set %#" PRIx32 " failed",

CHECK:ASSIGNMENT_CONTINUATIONS: Assignment operator '=3D' should be on the =
previous line
#3500: FILE: drivers/net/netvsc/hn_rxtx.c:441:
+               struct rte_eth_dev *dev
+                       =3D &rte_eth_devices[rxq->port_id];