From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F0FA11B31B for ; Wed, 14 Feb 2018 00:03:31 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 74A8221A30; Tue, 13 Feb 2018 18:03:31 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 13 Feb 2018 18:03:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=/AsG731cclrJCyJn+lmGxXPuRn /lSnI5wiQSt8R0tIU=; b=gSXQZbV72UX0kU61xhumw5vA8WRe730p+8WIA7lnAb 67nkfcS6/4htMhTBHf97xPUPt9yr3Qx5bt9RX/w0RvhJ8Z8TZMFBMYau5MrUt4wQ IK7siGMCkkjE6LoM+cAuZzbr2DXBFL149EPhx0/vbWN6szf+xjQgxyBOQk5EGHjj o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/AsG73 1cclrJCyJn+lmGxXPuRn/lSnI5wiQSt8R0tIU=; b=m4Oukx+0cz53Zd8RZxdg9t LtQ8SIDhns+YiC0CA5NDERhWb3Ut7z3b1UEg5SU9+SqP3aokPZQTb1cClxHKqGxp nJsTjhcPVPuVUzuwc8yiQOybMvM9m2EIFuuTmzrm5TLwhzRaCkLGvMHNFoW9uKY7 wcfX71e4xPomxh58yE2UpKTtta3BW83jaT1AiDYzjw+VkGlS3gd+zsZqoeVxpfG6 uyxYZQsDXraJ1vjUJIRyG3cmBHVvAnWzqXy86WG1aUV2jMSvPHZn1FxMygimM+k4 D/HC1LLcIaZsOfNP8ElLQbqK8YKcRV4PUrWQmellpvWDLjbhnD2j+0Fwo8wFvdkA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 220E57E4B2; Tue, 13 Feb 2018 18:03:31 -0500 (EST) From: Thomas Monjalon To: Chas Williams <3chas3@gmail.com>, Chas Williams Cc: dev@dpdk.org, declan.doherty@intel.com Date: Wed, 14 Feb 2018 00:03:21 +0100 Message-ID: <2142911.RBZ8bQKsro@xps> In-Reply-To: <20180213225430.15556-1-3chas3@gmail.com> References: <20180213225430.15556-1-3chas3@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/bonding: fix link properties with autoneg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Feb 2018 23:03:32 -0000 13/02/2018 23:54, Chas Williams: > From: Chas Williams > > If a link is carrier down and using autonegotiation, then the PMD may not > have detected a speed yet. In this case the best we can do is ignore the > link speed and duplex since they aren't valid. To be completely correct, > there should be additional checks to prevent a slave that negotiates a > different speed from being activated. > > Signed-off-by: Chas Williams Please add Fixes line to all your fix patches. Thanks