From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id BE0CC4C6E
 for <dev@dpdk.org>; Thu, 20 Mar 2014 17:29:03 +0100 (CET)
Received: by mail-wg0-f49.google.com with SMTP id a1so783267wgh.8
 for <dev@dpdk.org>; Thu, 20 Mar 2014 09:30:35 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=9GUlyNeV8+nWSvBry1O5GpN8u2eQs1OtY100nd1osUM=;
 b=Fi+840Lv6vT3Jf4VoELVFYXJlgMzo/iRjSNWBIjqkfDIfjqcXMjsObruZJxsFtZhUZ
 5WcGxQdqTqeBS6sTGeeOgdGBSBROrw04r7B5Ia/INd9lLv9eRLDB3+sXOpHoa7wg3F5O
 atbMMVmach61Uj7Bh1ZULS/snh/VPTyeTZbB6DFhDymMLH55jEjwRI6LX/7wgwpyZczV
 9FACKl74ZyNe7HnCwtgNrmgwalbEH0JXk2KJo+dyQXNhAdxpQWkXdiOvU0+9sjlNcKnt
 1280MknOXkuExmvVN2poPCC2ZNvklQgSGL2vwc0JtiPqciNrsIpnf6/K9yw2ssjKr0Yh
 dwfA==
X-Gm-Message-State: ALoCoQmLDCsnvFIJ6bVC8YFYRT6lHupo50199SDaajMNF0EsFfePOb3s5BQvtrCSYQD241tUMqTm
X-Received: by 10.180.73.141 with SMTP id l13mr24683366wiv.60.1395333035316;
 Thu, 20 Mar 2014 09:30:35 -0700 (PDT)
Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.180.237])
 by mx.google.com with ESMTPSA id i7sm54325830wib.1.2014.03.20.09.30.33
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 20 Mar 2014 09:30:34 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Date: Thu, 20 Mar 2014 17:30:32 +0100
Message-ID: <2143975.C98iGihseR@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.3 (Linux/3.13.6-1-ARCH; KDE/4.12.3; x86_64; ; )
In-Reply-To: <20140227091856.768d413c@nehalam.linuxnetplumber.net>
References: <20140227091856.768d413c@nehalam.linuxnetplumber.net>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1.6.1] don't inline rte_string_fns
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Mar 2014 16:29:04 -0000

Hi,

I have some minor comments below.

27/02/2014 09:18, Stephen Hemminger :
> The function rte_snprintf() can never be inlined by Gcc.
> If compiled with -Winline it generates an error:
>  function =E2=80=98rte_snprintf=E2=80=99 can never be inlined because=
 it uses variable
> argument lists [-Werror=3Dinline]
>=20
> Therefore since both rte_snprintf and rte_strsplit are not performanc=
e
> sensitive just move them to being real functions.
>=20
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

> --- /dev/null
> +++ b/lib/librte_eal/common/eal_common_string_fns.c
> @@ -0,0 +1,95 @@
> +/*-
> + *   BSD LICENSE
> + *
> + *   Copyright(c) 2010-2013 Intel Corporation. All rights reserved.

It is now 2014 in version 1.6.0.

[...]

> +#include <stdio.h>
> +#include <stdarg.h>
> +#include <stddef.h>
> +#include <errno.h>

I think stddef.h is not needed.
=20
[...]

> --- a/lib/librte_eal/common/include/rte_string_fns.h
> +++ b/lib/librte_eal/common/include/rte_string_fns.h
> @@ -47,7 +47,6 @@ extern "C" {
>  #include <stdio.h>
>  #include <stdarg.h>
>  #include <stddef.h>
> -#include <errno.h>
=20
stdarg and stddef are not needed.
=20
[...]

> +int
> +rte_snprintf(char *buffer, int buflen, const char *format, ...);
>=20
>=20

One blank line should be sufficient.

> +int
>  rte_strsplit(char *string, int stringlen,

Thank you
--=20
Thomas