From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0CDEA0C43; Fri, 26 Nov 2021 14:06:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6143F4272C; Fri, 26 Nov 2021 14:06:38 +0100 (CET) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 4C016426E2 for ; Fri, 26 Nov 2021 14:06:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 7B189580245; Fri, 26 Nov 2021 08:06:36 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 26 Nov 2021 08:06:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= Ndv3W4RUktWaQNk2LNVlcmDL2QBGjexD3sAGVbzGTUI=; b=sPAKlz5/AeUXP3ce FrVLyqXNwXb5jMSYakKGJIoNg+unGvT/d7HfH9U3ZkOgMVVQwfCVCkKJ5UrGOyuh j+v0MIv1XFMxzuTBm3fsk3x0nKHXpxU2R4yqX69LUw9LdcaIYEfzW/XY2930GHg8 C7k/xzvH5qSW4+BwFfK2m9ttfquqxqvqphhUpH+FSvtQLa6KYNMBZytk982I9YFs gC1MiaDPc712mTVdJYUdjJowW4A8wyf8MdrWFlicYUEJLFTdfpOU5qWov5qgP5Pp uN6Bi6xKHxVRx10phGRSyhod7uITznai0TF0TZSa4cq/y4Wfe7F2PoNirbkGdY7y bZ9j6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Ndv3W4RUktWaQNk2LNVlcmDL2QBGjexD3sAGVbzGT UI=; b=gSOaC8DPueu9bLZu4tSCNbm3gIzK4gEV9rbfV8s3nSm6wczLmyc0iuP/H SgZHw6YIfby6VdnwJ/ZQLEQl2bvkbhMDEvp+JmTu6xnhQHz+ggyLJypTPubqjOpA 1DthLgQnbQtmWbCuI7//VfoyMPMKY3NJ5Qo6KYhV2VAAvNgcStfBeR/snlAEJKVV UR1tngqd18VapRVrbBLLvDWFzogvM2kJ+9vx5cgQG5ducRZqOFiQxOLFV/P3p2yk h2ELbNhknpiG965pQRAB0Yqs0I2Zfu1Z3uEnL8QNSqJETElN21OiHFE2WFCBJCGw ykgLLNqWqNUVPBNwGV2FL8sIQKSjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedvgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Nov 2021 08:06:28 -0500 (EST) From: Thomas Monjalon To: Viacheslav Ovsiienko , Ferruh Yigit Cc: dev@dpdk.org, hemant.agrawal@nxp.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, andrew.rybchenko@oktetlabs.ru, rahul.lakkireddy@chelsio.com, jerinj@marvell.com, humin29@huawei.com, haiyue.wang@intel.com, ndabilpuram@marvell.com, sthemmin@microsoft.com, sachin.saxena@nxp.com Subject: Re: [PATCH v4] ethdev: deprecate header fields and metadata flow actions Date: Fri, 26 Nov 2021 14:06:23 +0100 Message-ID: <2145893.KXFgBx9ejH@thomas> In-Reply-To: <828f220b-1607-94ac-7cae-bb5324d53654@intel.com> References: <20211123075940.5521-1-viacheslavo@nvidia.com> <20211126095116.9882-1-viacheslavo@nvidia.com> <828f220b-1607-94ac-7cae-bb5324d53654@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 26/11/2021 13:53, Ferruh Yigit: > On 11/26/2021 9:51 AM, Viacheslav Ovsiienko wrote: > > The generic RTE_FLOW_ACTION_TYPE_MODIFY_FIELD action was > > introduced by [1]. This action provides an unified way > > to perform various arithmetic and transfer operations over > > packet network header fields and packet metadata. > > > > [1] commit 641dbe4fb053 ("net/mlx5: support modify field flow action") > > > > On other side there are a bunch of multiple legacy actions, > > that can be superseded by the generic MODIFY_FIELD action: > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL sfc > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC bnxt, cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST bnxt, cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_TP_DST cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_DEC_TTL mlx5, sfc > > RTE_FLOW_ACTION_TYPE_SET_TTL mlx5 > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST cxgbe, mlx5 > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ mlx5 > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ mlx5 > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK mlx5 > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP mlx5 > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP mlx5 > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_VID bnxt, cnxk, cxgbe, enic, > > mlx5, octeontx2, sfc > > RTE_FLOW_ACTION_TYPE_OF_SET_VLAN_PCP bnxt, cnxk, cxgbe, enic, > > mlx5, octeontx2, sfc > > RTE_FLOW_ACTION_TYPE_SET_TAG mlx5 > > RTE_FLOW_ACTION_TYPE_SET_META mlx5 > > > > This note deprecates the following RTE Flow actions, > > as not supported by any of PMDs: > > > > RTE_FLOW_ACTION_TYPE_OF_SET_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_DEC_MPLS_TTL > > RTE_FLOW_ACTION_TYPE_OF_SET_NW_TTL > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_OUT > > RTE_FLOW_ACTION_TYPE_OF_COPY_TTL_IN > > > > The following actions are supposed to be deprecated in 22.07 > > and replaced by generic field modify action: > > > > RTE_FLOW_ACTION_TYPE_OF_DEC_NW_TTL > > RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DST > > RTE_FLOW_ACTION_TYPE_SET_IPV6_SRC > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DST > > RTE_FLOW_ACTION_TYPE_SET_TP_SRC > > RTE_FLOW_ACTION_TYPE_SET_TP_DST > > RTE_FLOW_ACTION_TYPE_DEC_TTL > > RTE_FLOW_ACTION_TYPE_SET_TTL > > RTE_FLOW_ACTION_TYPE_SET_MAC_SRC > > RTE_FLOW_ACTION_TYPE_SET_MAC_DST > > RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ > > RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ > > RTE_FLOW_ACTION_TYPE_INC_TCP_ACK > > RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK > > RTE_FLOW_ACTION_TYPE_SET_IPV4_DSCP > > RTE_FLOW_ACTION_TYPE_SET_IPV6_DSCP > > RTE_FLOW_ACTION_TYPE_SET_TAG > > RTE_FLOW_ACTION_TYPE_SET_META > > > > The VLAN set actions are interrelated to VLAN header insertion/removal > > and supported by multiple PMDs and widely used by applications and > > not supposed to be deprecated due to potential large impact on > > drivers and applications. > > > > Signed-off-by: Viacheslav Ovsiienko > > Thanks for the update, > Acked-by: Ferruh Yigit > > > We need to follow with relevant PMD maintainers to switch to new > 'MODIFY_FIELD' action till end of v22.07 release. Yes I would like to see them replying here, but seems some are not watching. I don't want to block this interesting deprecation plan, so I will merge if few more maintainers involved in ethdev give their ack. Acked-by: Thomas Monjalon