From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1AADA0528; Thu, 9 Jul 2020 15:50:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA0811E91F; Thu, 9 Jul 2020 15:50:55 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 4602C1E919 for <dev@dpdk.org>; Thu, 9 Jul 2020 15:50:54 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200709135054euoutp02307464b274c43a24c6fdfc6345820e53~gGdEfyFif0951009510euoutp02c for <dev@dpdk.org>; Thu, 9 Jul 2020 13:50:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200709135054euoutp02307464b274c43a24c6fdfc6345820e53~gGdEfyFif0951009510euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594302654; bh=c0Ge/YOWmOAma8ANh+hebw0wgjYjWsAx3fzuqoLuPAs=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=jmmybRcInny9SDyINIfk5SIcLx8WI2VAoN16wsoXsAdhQE0jYzIFq05Gb6//iVkKQ N1vG8vxL5/RDfXbGP3arhh40FP53p/HLJys7HK/5ynp7Sr2RarvXr8vQslxmEDg9MS SIT2KM/OczWgcl2dR6rkiV2GBTPq6h5vhUbHc8/I= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200709135053eucas1p1046591d70aee3f2ece91dd582314c08a~gGdELD72b1110411104eucas1p15; Thu, 9 Jul 2020 13:50:53 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id B7.78.06318.DB0270F5; Thu, 9 Jul 2020 14:50:53 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200709135053eucas1p1fb2aa7bae82c9c3e0e71ad4d20dec4bb~gGdDy8MmM1087810878eucas1p1I; Thu, 9 Jul 2020 13:50:53 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200709135053eusmtrp1bb69601827dfae3f96aeb0155a3df8ec~gGdDyQwAI1458714587eusmtrp1e; Thu, 9 Jul 2020 13:50:53 +0000 (GMT) X-AuditID: cbfec7f5-371ff700000018ae-e0-5f0720bd6058 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 4C.1F.06314.DB0270F5; Thu, 9 Jul 2020 14:50:53 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200709135052eusmtip147179fe356a130d0fe145199b26cba0c~gGdDMI3V51652916529eusmtip1R; Thu, 9 Jul 2020 13:50:52 +0000 (GMT) To: Bruce Richardson <bruce.richardson@intel.com> Cc: Olivier Matz <olivier.matz@6wind.com>, Thomas Monjalon <thomas@monjalon.net>, John McNamara <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org, "\"'Lukasz Wojciechowski'\"," <l.wojciechow@partner.samsung.com> From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> Message-ID: <2149abe8-d90c-686c-2ca6-e7b8907d5034@partner.samsung.com> Date: Thu, 9 Jul 2020 15:50:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200626170007.GC564@bricha3-MOBL.ger.corp.intel.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA01SbUhTYRjtvR/bdTR7N609WJSMoAzUxIKBpZYlo/ohgUJB6sqbH+m0XWfZ L+1DcymJ2UINs3Qopk2lqQ0rmqWFTjOINARLVmQ2P5Ocm5bzKvnvPOc85z3ngZchpfW0D5Os zmQ1alWqXCCiWrsc/f7PfYVxe0utuxWD9WGKiZk2QtFfaaIV3wufIEV/cxGtMF1tJhQzX95S 4ULlwO1hpFyoMtDK6o4xQtk1pBcqX010EFH0adGBBDY1OYvVBIbGi5IMjrCM0i2XO5wmOgeN SnTIgwG8D6pMOkKHRIwU1yEwm0sRP/xGsJTbuarMItD3jpBrlqlbS0JeqEUwOm8VuAUptiPI qxG6sRc+DvbZSsqNvXEQmB6aSLeBxC4E1d0FKwYBPgivy+ZoNxbjSGgdu7+czTAU3gnWTn83 vRnHgnGsjeBXJPCuzLbypgeOgGdVRStZJN4B10wVJI9l8Nn2YKU1YLMQhntbBHzrI2DUfVjF XvCz+6mQx9ug504hxRtaEXx0OhA/vETwqahudSsEOpecAnc7EvuB0RzI04fgV+U45aYBe8Kg XcKX8ISS1nskT4vhZp6U3w6Ab4V30Vqsq9FGFSN5+brTytedU77unPL/uVWIqkcyVsulJbJc sJq9FMCp0jitOjHgXHpaC1r+QT1L3XPt6IXrrAVhBsk3iuMXBXFSWpXFZadZEDCk3Ft82NoT KxUnqLKvsJr0OI02leUsaCtDyWXi4EdjZ6Q4UZXJXmDZDFazphKMh08OiqCjXKmDC/F+WaFi /5KBGw2LxVPyhnbf3vQTyDKdsgm9mSxzGH5UkvOzMT6OKWusQdmiLx6vkByb/Bs8QRhHvkZO h4tyNfrkxqJTQbuavO1DzYYY7dEQUbSulvBv29+36KjpOxm9/b0sIt85m7JBEVtwfSH/8Z8A 34vnbU2cnOKSVEF7SA2n+gdAYTUkPQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsVy+t/xu7p7FdjjDQ7s4be4scre4t2n7UwW 5+dtZbV41rOO0eL8xl5Wi61NG5ksPj04weLA7nGx/w6jx68FS1k9Fu95yeRx7OY0do+D7/Yw BbBG6dkU5ZeWpCpk5BeX2CpFG1oY6RlaWugZmVjqGRqbx1oZmSrp29mkpOZklqUW6dsl6GUs /WlfMEWsYs/vrawNjI8Euxg5OSQETCQ+dP9j72Lk4hASWMoo8eTkR6YuRg6ghIzEh0sCEDXC En+udbFB1LxmlNg7fy8zSEJYwFvi7ed5LCC2iIChxNaFW5lBipgF/jFK9G1rZQRJCAmcYpJY vUwSxGYTsJU4MvMrK4jNK+Amse3lHEaQZSwCKhJnD+uChEUF4iSWb5nPDlEiKHFy5hOw+ZwC zhI7F/SCxZkFzCTmbX7IDGHLSzRvnQ1li0vcejKfaQKj0Cwk7bOQtMxC0jILScsCRpZVjCKp pcW56bnFhnrFibnFpXnpesn5uZsYgRG37djPzTsYL20MPsQowMGoxMO74z9bvBBrYllxZe4h RgkOZiURXqezp+OEeFMSK6tSi/Lji0pzUosPMZoC/TaRWUo0OR+YDPJK4g1NDc0tLA3Njc2N zSyUxHk7BA7GCAmkJ5akZqemFqQWwfQxcXBKNTDyvGFacWX1vXSOdmadfc/sHfaGXJ4hMmPR o6fWSh9+TnJ8tNAkUn2e3OqCF4t52AsFq1+aNX5SLTTiU4uUyZo9yWNteEuxYvPSXfuKfyu5 7he75uR7q3DSqRMX4nb+D/ltHnLqwOajhZV/lFUa35Wsaz5+oeFK6Jc9J/RPc7YU6WXqbC8+ +Pi7EktxRqKhFnNRcSIAVSl+Ss4CAAA= X-CMS-MailID: 20200709135053eucas1p1fb2aa7bae82c9c3e0e71ad4d20dec4bb X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200422214615eucas1p2a50ce20695a77b5b2888fd4521296094 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200422214615eucas1p2a50ce20695a77b5b2888fd4521296094 References: <20200417215739.23180-1-l.wojciechow@partner.samsung.com> <20200422214555.11837-1-l.wojciechow@partner.samsung.com> <CGME20200422214615eucas1p2a50ce20695a77b5b2888fd4521296094@eucas1p2.samsung.com> <20200422214555.11837-4-l.wojciechow@partner.samsung.com> <20200626170007.GC564@bricha3-MOBL.ger.corp.intel.com> Subject: Re: [dpdk-dev] [PATCH v2 3/3] mbuf: standardize library debug flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> W dniu 26.06.2020 o 19:00, Bruce Richardson pisze: > On Wed, Apr 22, 2020 at 11:45:55PM +0200, Lukasz Wojciechowski wrote: >> Use standardized debug macro RTE_DEBUG_MBUF instead of >> RTE_LIBRTE_MBUF_DEBUG for wrapping sanity checks. >> >> Add runtime control of running sanity checks basing on >> rte_log_can_log() function. >> >> To run mbuf sanity checks all following conditions must occur: >> 1) RTE_DEBUG_MBUF - must be defined, this can be done by enabling meson >> rte_debug option or defining CFLAGS="-DRTE_DEBUG_MBUF" >> 2) global log level must be set to RTE_LOG_DEBUG >> 3) mbuf library logtype log level (lib.mbuf) must be set to RTE_LOG_DEBUG >> >> Tests and documentation were also updated. >> >> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> >> --- >> app/test/test_mbuf.c | 3 ++- >> config/common_base | 1 - >> doc/guides/prog_guide/mbuf_lib.rst | 2 +- >> lib/librte_mbuf/rte_mbuf.h | 12 ++++++++---- >> 4 files changed, 11 insertions(+), 7 deletions(-) >> >> diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c >> index 8200b4f71..b7b956659 100644 >> --- a/app/test/test_mbuf.c >> +++ b/app/test/test_mbuf.c >> @@ -994,7 +994,8 @@ test_pktmbuf_free_segment(struct rte_mempool *pktmbuf_pool) >> /* >> * Stress test for rte_mbuf atomic refcnt. >> * Implies that RTE_MBUF_REFCNT_ATOMIC is defined. >> - * For more efficiency, recommended to run with RTE_LIBRTE_MBUF_DEBUG defined. >> + * For more efficiency, recommended to run with RTE_DEBUG_MBUF defined >> + * or using rte_debug meson build option. >> */ >> >> #ifdef RTE_MBUF_REFCNT_ATOMIC >> diff --git a/config/common_base b/config/common_base >> index 38c5ada26..80fa3281f 100644 >> --- a/config/common_base >> +++ b/config/common_base >> @@ -859,7 +859,6 @@ CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL=y >> # Compile librte_mbuf >> # >> CONFIG_RTE_LIBRTE_MBUF=y >> -CONFIG_RTE_LIBRTE_MBUF_DEBUG=n > This provides no "standard" way to enable the debug options with make, > right? I think that is perhaps a step too far. Two options I see: > * Rather than dropping this flag, it could be converted inside the mbuf > library (maybe the makefile) to the new version > * Replace this macro with CONFIG_RTE_DEBUG_MBUF > > What do you think? I prefer the second option because we want to standardize the names - so let it be only one flag with proper name. Using conversion would be a bit messy as probably final user will be able to achieve the same effect using either old or new flag. Change applied in v3. > /Bruce > > -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com