From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f178.google.com (mail-we0-f178.google.com [74.125.82.178]) by dpdk.org (Postfix) with ESMTP id 2C9575ABA for ; Sat, 7 Mar 2015 21:39:40 +0100 (CET) Received: by wesw62 with SMTP id w62so3153947wes.0 for ; Sat, 07 Mar 2015 12:39:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=UeHxS8G/krGkzn0/INF9tuvUSJqW03iSfsUk1YuAY+Q=; b=j0k53UlvA4Sbbqt+yPOUC8ET1RuPvdnVCnz9WyDU37SWUDCQsi4cWIlvZFGssQb786 hRYJinLv+t8un7haycIShQ402ZbTeMFAyJDMQX01rCNG/5gMynWDSvv+8UG8Ybktpo77 X6CgBjyO4bIZWUpRa8/oqNCye8dbJCc+0XUka93gA4rnYZ2aig8KIUE28jzGmDS0E5ct LLDZxryn2BcN103AExi7jwSbi5n0XR9bl1yhKrnVEw28DyqicXOcxEUA+zLvGPkJtBYS I5/nOQkjxY8+xNBH8RXiFE/2OCpXa4UfrRFiUH7CPKQ5ktADNstBlloUQugflgrvq6JZ 6yEg== X-Gm-Message-State: ALoCoQmOqk5wASuuTmk+15xtTLVUBB5E0UbYrM7SYVr++wwngvAU10Egeu6EKG+QwtYuFSjoX4Eo X-Received: by 10.194.75.168 with SMTP id d8mr42987322wjw.87.1425760779979; Sat, 07 Mar 2015 12:39:39 -0800 (PST) Received: from xps13.localnet (ABayonne-157-1-175-143.w109-222.abo.wanadoo.fr. [109.222.38.143]) by mx.google.com with ESMTPSA id m10sm6997507wij.5.2015.03.07.12.39.38 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Mar 2015 12:39:39 -0800 (PST) From: Thomas Monjalon To: Olivier MATZ Date: Sat, 07 Mar 2015 21:38:47 +0100 Message-ID: <2151096.y3SmQntZBq@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <54F96951.2060406@6wind.com> References: <1425489189-43477-1-git-send-email-keith.wiles@intel.com> <54F96951.2060406@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Move mk/rte.extvars.mk to mk/internal/rte.extvars.mk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Mar 2015 20:39:40 -0000 2015-03-06 09:46, Olivier MATZ: > Hi Keith, > > On 03/04/2015 06:13 PM, Keith Wiles wrote: > > Move the rte.extvars.mk to an internal directory and > > update rte.vars.mk to find the file in the new location. > > > > Signed-off-by: Keith Wiles > > Acked-by: Olivier Matz > (for after 2.0 I guess as it's not a fix) It's a good clean-up without risk. It should go in. > Note for Thomas: when you apply it, git complains there is a blank > line at the end of the file that is moved, I think you can strip it: > > dpdk/.git/rebase-apply/patch:94: new blank line at EOF. > + OK, thanks