From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 11340F955; Thu, 2 Mar 2017 14:04:10 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 02 Mar 2017 05:04:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,231,1484035200"; d="scan'208";a="71387916" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.134.95]) ([10.255.134.95]) by fmsmga005.fm.intel.com with ESMTP; 02 Mar 2017 05:04:07 -0800 To: Rasesh Mody , dev@dpdk.org References: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> Cc: Dept-EngDPDKDev@cavium.com, dpdk stable From: Ferruh Yigit Message-ID: <2152c44b-3013-b709-16c0-cdef9c20fce2@intel.com> Date: Thu, 2 Mar 2017 13:04:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1488181923-9649-1-git-send-email-rasesh.mody@cavium.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 01/21] net/qede/base: fix incorrect typecasting of flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 13:04:11 -0000 On 2/27/2017 7:51 AM, Rasesh Mody wrote: > dcbx-update-flag is incorrectly converted to boolean before assigining > it to ramrod data, fix this typecasting. Also, added more debug > messages in the dcbx code paths. > > Fixes: 26ae839d06e9 ("qede: add DCBX support") > > Signed-off-by: Rasesh Mody > --- <...> Not to this patch, but for the whole patchset, thank you for splitting fixes into small chunks, this makes review easier. And for patches you want them in stable tree, please - CC those patches to stable mail list (stable@dpdk.org) - and add a new tag in commit log just below "Fixes: " line, like: " Fixes: xxxxxxxxxxxx ("...") Cc: stable@dpdk.org Signed-off-by: .... Acked-by: .... "