From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5372EA0C41; Wed, 17 Nov 2021 13:36:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BD96426E6; Wed, 17 Nov 2021 13:36:53 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id C9B4A426E3 for ; Wed, 17 Nov 2021 13:36:51 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7B06E5C0194; Wed, 17 Nov 2021 07:36:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Wed, 17 Nov 2021 07:36:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= UUcyDVrB7wDKQsALwzOpxZFFfa2l+hk3ofufsyX/GXY=; b=OCGCDNAaMzo84dgZ C7RzLCLTCDGZz5DpXouaF8ICUKJNo9h6i9Loo+95j72P8mNdUXlWQMahexDM0I21 xmN6mtICB99WLMvg3VL7NbQJg2ieTYeOj2mVCmqxmiMORtzXnsyk9tTK2SrOVWMJ zf+MfFpNQeHEDCXVW88XOL+OYV39du2QcvL2GfWkqswgurXwGhfydVKA7GRmqrm8 eUhA+VC6gNT/2tWD0ch1bpM47vh/L4qV3bHhJgFM3q8QbLKkKl12y5Jf3UqWdqGC 6Ew7IHtMokJTG3rVlvBCJAIitQh/gB11zN7jau8q/mJEiQrnGAN+0vU7bs7ZzxFi aZgWpw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=UUcyDVrB7wDKQsALwzOpxZFFfa2l+hk3ofufsyX/G XY=; b=VkdT94dKcoRUN3qIPkiU9yjEXgSY4UXzqiiPGFEyW+ixso0+53X24EYwZ OE8yv+BEw4FVrbzCYvkr+dFCgHpuqPCBB1uHsezMuLPdDxc7K4XJszvTY2KJu/yb sXMhUnpjbloICBidS2glMyRY4LogaZYQt5TERG73bmyCqfxEx/S0FspLaEtK2tQb gvNSvrdm8TOJ0FBnEWD/+OLhSvQYVWQt/C7o4v9Pe5IaxpXEoR71nXGC98Yhm5M9 5C3qT/7MRnY/mbFyytVwwCJyahgW6qaFH51ezbwK7dk88iy0zxx+Adz/skyPlMtV PoPMadREO1jxsd07Stre45ERcPQbw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrfeeggdefjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 17 Nov 2021 07:36:49 -0500 (EST) From: Thomas Monjalon To: Elena Agostini Cc: dev@dpdk.org, bruce.richardson@intel.com Subject: Re: [PATCH v1] build: make gpudev optional Date: Wed, 17 Nov 2021 13:36:48 +0100 Message-ID: <2153320.YCSTWHfduz@thomas> In-Reply-To: <20211117203351.6087-1-eagostini@nvidia.com> References: <20211117203351.6087-1-eagostini@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 17/11/2021 21:33, eagostini@nvidia.com: > --- a/app/test-gpudev/meson.build > +++ b/app/test-gpudev/meson.build > @@ -1,5 +1,12 @@ > # SPDX-License-Identifier: BSD-3-Clause > # Copyright (c) 2021 NVIDIA Corporation & Affiliates > > -sources = files('main.c') > -deps = ['gpudev', 'ethdev'] > +if dpdk_conf.has('RTE_LIB_GPUDEV') > + sources = files('main.c') > + deps = ['gpudev', 'ethdev'] > +else > + build = false > + reason = 'gpudev library is disabled' > + subdir_done() > +endif I would prefer the form "if not" so we can save the "else". > --- a/lib/meson.build > +++ b/lib/meson.build > @@ -76,6 +76,7 @@ optional_libs = [ > 'pdump', > 'power', > 'vhost', > + 'gpudev', > ] It should be sorted alphabetically.