From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9956541CC1;
	Fri, 17 Feb 2023 16:32:37 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 279E940EE3;
	Fri, 17 Feb 2023 16:32:37 +0100 (CET)
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40])
 by mails.dpdk.org (Postfix) with ESMTP id 833C340EE1
 for <dev@dpdk.org>; Fri, 17 Feb 2023 16:32:35 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=HrqM0WysfsgSoeqMohLUMphxhut3kdnIRqdkSxMOksgDjk2XToaBumMkA0gN1CqtVJLUf6vyjatd41zHXxLrtsfio9rcYjYZ0+3+9x9XTj0RcJ7BjVsJt8PVnVgT8vZ70jT3z0XN9CClUGSTeXjkJ6ev/ju9wiPbjqGPLMFp/bZ4oY3YWQ9jEA6jTuEVXR+Jr2Lraf+X7RTZXSOrAYYwr0NDex1s++Tix52rDOnax4Lc5cHMmR2SC2BcNijY0mt5wddVA3KzEquA5hxGCfRAsz3OzjSc30A1CQKGV5HWYBPp/7UTSwJN/Yd0vAaOjPhcR0xkGD/BIkhStIOFxS/Pmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=Pa2kqVnmyAWCLStLlJPv8mSpKl5vRf1EJJtbABpljU4=;
 b=ghvDHvRSMN+4OuZF1rDz03NlxztHjcTUE+L81TvArQhauQb9Zdyv52tWReoh3pio3j3UBbkSKU/g40sd8M1hxpQncEtVURLVY+7U2WZhUApxvZzX7JY9fRyyJYxci83jLtjNPgd6SkgJBH+pToKrGWkcEPG/OIzDM6cmPHEKKN8yom8G68SBO5MrnSUlGm1w5psbL0NqdIji2W+UMrKZk3HwenT7+JUU78d4qiyfR+da2CE/ETJIdWsErw8x4OtlGQmdHiXXNvXIa8g5XSN9xbd6dkjwTuqPk8EuJ8/f0pQSGepiOGYHc/aXLhrGR54judm7iGYFma4f5l9EhBNhAA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass
 header.d=amd.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; 
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Pa2kqVnmyAWCLStLlJPv8mSpKl5vRf1EJJtbABpljU4=;
 b=ct7F0FSYydva716AfjWNR/FY4X7J5nMZ8C2atpjloINCooZNqE4HzhtSlRtCt1kpo9BsHx1R8HnqzHaJ0CcNAm4tIonXazX51rR5c0oXR2IfE9KqzKHD9MNRTEmh/tU2QgwrRwaLykEv2v8X0L7ENA29Qz3Lgq7jScVRXEFwt0s=
Authentication-Results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=amd.com;
Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11)
 by IA1PR12MB6188.namprd12.prod.outlook.com (2603:10b6:208:3e4::6)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.12; Fri, 17 Feb
 2023 15:32:33 +0000
Received: from CH2PR12MB4294.namprd12.prod.outlook.com
 ([fe80::3614:22ed:ed5:5b48]) by CH2PR12MB4294.namprd12.prod.outlook.com
 ([fe80::3614:22ed:ed5:5b48%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023
 15:32:33 +0000
Message-ID: <2153af66-a33a-41db-c0d7-a35907370bf7@amd.com>
Date: Fri, 17 Feb 2023 15:32:25 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.2
Subject: Re: [PATCH v6 1/2] ethdev: add Tx queue mapping of aggregated ports
Content-Language: en-US
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>,
 Slava Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,
 "NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
 Aman Singh <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
References: <20230203050717.46914-1-jiaweiw@nvidia.com>
 <20230217105026.12927-1-jiaweiw@nvidia.com>
 <20230217105026.12927-2-jiaweiw@nvidia.com>
 <557ee985-b634-f630-0ef4-1b28f876f690@oktetlabs.ru>
 <PH0PR12MB5451448328DFC7A8536E89FBC6A19@PH0PR12MB5451.namprd12.prod.outlook.com>
 <6fc0cee5-9cce-90c0-e943-9a9d87706204@oktetlabs.ru>
From: Ferruh Yigit <ferruh.yigit@amd.com>
In-Reply-To: <6fc0cee5-9cce-90c0-e943-9a9d87706204@oktetlabs.ru>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: LO4P123CA0684.GBRP123.PROD.OUTLOOK.COM
 (2603:10a6:600:351::17) To CH2PR12MB4294.namprd12.prod.outlook.com
 (2603:10b6:610:a9::11)
MIME-Version: 1.0
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6188:EE_
X-MS-Office365-Filtering-Correlation-Id: f53d11b7-6720-4bd7-ba73-08db10fc3023
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: vBRsb7gkugn28PlkzZpV8f04QOJCJ8Gf4Dw6VkeVvOOvS6mrWhrg2zfYUtse+m+TpH27xujjiJJQi2PEr60m+WPH8kRqxwuyyKFMqOOxGp2Bj29J73o/voOzX8BFWfumaiACKfRPXh2C7N99SV4LjryNtOK72Jry/bzKcn8+5QlzR4HDBAbfZ6eGdM9SN7B8wK28z9UAV+V9cIFexb719+EkEvs1XYjF7XvpnagX+d2o6LlweA5I2vR0r16G9XQYOXg3O8//SJqhAAcZbieyuBuvwD3csFe3sEVmrMz6mJKFerNLHAmXYCcOsXkqdMF3iA/eK+BzE0hV9Ogz6z925jckzEquGDUWlITH4WAJAiyxDheoxTuh+0O7lMVHyAAHXtFNhxFSq39wjAS4Wzb3pjf/50ogpqkbIDSAu3u6MbTXZPn6jnRDBKwymJd6ZF+jgqydkybcJuVw4Wo8wPPVdPm/cZ1FyslsJqCXeXMfDEiamaUkAw0f2Li5MLp0qGVWUxu11HCfIa93OMazti9c7CYR8iulZuKRGoGPW53neH7RndQqU0j7+d4SR6BTBCpifoegLznv1SNawWXSwuJH+cFH4g5L8YKKpTAR558Dn+OPgCRxpre4OyHEunQt11C4CFU70wZY2WPZBEpAbZ5L0DW024YUtDyR7515OBRsumK9y+7mzXBEW0HAp96XhHamWoM3+0avIxoy1phMLfK7RXRed0t9Z96LOerPvIZpBd4=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230025)(4636009)(366004)(39860400002)(376002)(346002)(396003)(136003)(451199018)(83380400001)(31686004)(66476007)(66556008)(8676002)(4326008)(41300700001)(38100700002)(316002)(8936002)(54906003)(66946007)(6486002)(44832011)(5660300002)(110136005)(2616005)(86362001)(36756003)(6666004)(31696002)(2906002)(6512007)(26005)(186003)(478600001)(53546011)(6506007)(45980500001)(43740500002);
 DIR:OUT; SFP:1101; 
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFFTVkJSaHRJa2g1YU1mUVBFak1UeTJadzlrb3RUMVhkOHJlY0N4eFFkbEE3?=
 =?utf-8?B?QzJXUG5IaTVEL0N6M3c4bnEzblJDdXZHL3ZVQ0xxaGtkNWFLbS9Yek5EbUlr?=
 =?utf-8?B?bkxZclhia3pxMjNublVwN2VMbmxYNmxrOUZBNDhKN0ZScjRQZUR3SUl5aGZW?=
 =?utf-8?B?WW1Mc0hMWC85UGUxZW1ITzJuZzRDYjM1R2xJNUFEL0Q3SXFLQWtHYlBSeXJL?=
 =?utf-8?B?TjRUL1NMTFFrS1B5VEQxNFVaZ2RUV3g4TnJ3QzYzTjVlbExFWDZDOTkrQitY?=
 =?utf-8?B?TE1KMmZheTNNbkdMQjQ4U2krZ3lUT3N5d1ZEV0NOeFcydTRCZEpsRjJkUWJz?=
 =?utf-8?B?WEM5YnYvVW1jeGpWYVVpd0FsNGRYTFNPZGd2VzNsamxabEdEZnp3UW5ydWp1?=
 =?utf-8?B?Wk9LN3lQNVQ0Uy8yQjc0Q0pVN1VTRzVNd0RYRW12bS82YmlLQ0xvQ0RXM3h2?=
 =?utf-8?B?eEhrb3FJYkFXcmJUY1dSU3JyeEt2QWVZQzJIcFl6bU5ySnF3cXFiOU5id1g2?=
 =?utf-8?B?dXJtNVF1WlZ6K0NqVllzTFJQSU9sNmV1OWpnNDNUaXVuRkMxZlVlLzNOak9K?=
 =?utf-8?B?YUJpdHVLY21Eckg3MUpHS256SGtSdGE1aHF6QTJDTjVjeUozK1ZHZHpOL2pV?=
 =?utf-8?B?TXpydUFwRnUvM2hnYkY2SVI5cUdsMDdGMmpqTlFXcDdvUmdqT0k2V3cxaDFL?=
 =?utf-8?B?UmxPMm5QMmFoWC9yOTdsVzRkSDMxdlRWN3paUzFqQ01qcjVXR20yZFVteXJi?=
 =?utf-8?B?ekRaekdCTDZmb2JjMkZOMVpDb3dvdFM0eCtCRHhkaW5GUE12NExsR0FFYTR2?=
 =?utf-8?B?VHM1OFdZVm5nVnJCbW5YVzdja3lhREtWOG1SOGh3ZDlkRks0cHFUZUpoaW5i?=
 =?utf-8?B?SHhHeHEreFB0L3I0YjJlOUdQSU56M09XamRlRlllc2tGdjM4d0NxN0xNQ3pn?=
 =?utf-8?B?bEhMMlUvUFlPS1RxbkxQZFYvSzh1bFBGTWhqc0ZoeDQ4U2NsQUE1aVFsazBj?=
 =?utf-8?B?T3VvYzFLeWxoWUVZQ3BlcE5xdXNkSXEyQmFhN2Q4Sm83Y2JVMzR1NjZjM1Vs?=
 =?utf-8?B?U2tvbHBzZGF0eXN2UGRvRHRsN3VzZzVYTUMvRkpxMnN4bXg2TktsUnh0WFVk?=
 =?utf-8?B?RGxOY2ZtQWYyQm9Jb3lmcytJdGluSklRYXE5UG9lQUk1anNrcERzRnUvYWRm?=
 =?utf-8?B?T0FQUDFBMzlBNjl3ZkRFdngyY1FqdHB2OU40clYwUUhVUGdzODJKdXZIZy8x?=
 =?utf-8?B?VEdsS2h0ekoyNG51NXI2VzlQSi8xdFBRZTJPcEFmQjZ6SDVqY0wzNlBTdi9s?=
 =?utf-8?B?MHBMV3R1d04xU0ZSOFo3MlFFVzk4UGYwU3g0VFhwSXUwa1FJZ2IrMytxaDR5?=
 =?utf-8?B?cHVhTGxma0pIQTVuYUNrTzMxUXhyaTN4L1FOZU5GYUdoQndIVVptZWU4dFM0?=
 =?utf-8?B?YmhoMkVBbm5BT0pHNC9YeDYzZGJpb01DamRvckVvSmpDTzhMRUU4RUpSRE5S?=
 =?utf-8?B?cFpDVkpEMy9rL0Y3aW9WMkw2eDJlRjdnMnZBT3UyNmliYlZvMG1ydk9zblli?=
 =?utf-8?B?dTdCblFmbm9ER21RWFJCdGIyWFJrYnhnVlkrRWJwNk5ZZjlLSjdEVkYvTmFO?=
 =?utf-8?B?YXFCbzVzeittV3UwRFEwMWx4VWV1ZWlpTDN1Q0N0VzFKMDBlaE12aVBNUzIx?=
 =?utf-8?B?UHlFVVNtdmViMUpCT2VxamNJVVRxVkdyT1VaZlgveWtXcDA2Q1k4QTNzcVAv?=
 =?utf-8?B?RTZOUmFoemNCc0dhTTMvTmM0YktySjk5bWtYS1NEczlIMytnY3NmbjdWRlJR?=
 =?utf-8?B?Y2tOOVltUWJwMUNuYUNlRnFESitlK1VrMmNNcE5RQUkxVFZ3a0kzblRuVzFL?=
 =?utf-8?B?NktZcDJxT212RVBVbHloYXBYaFBOS2d6a210cGRzUkU3eE5WY3dQazQ3c3BI?=
 =?utf-8?B?bSt5T3RBOEtKL2V4Zk00dXJDdE1VS0puc0hUdGZFZVlGcGEzcFV1Umx4R204?=
 =?utf-8?B?UEMzK2tkSzk4MXhsM09rN0R0bFN1Yk1oZkkyaHorS1NiQW9yY2lOa0d5bERi?=
 =?utf-8?B?TEZHc3M3TU9aYS9GdkdHOUlnTVF1b1VFVzlHVkhPVTF6Ynd1REhTQitVNjU4?=
 =?utf-8?Q?kZLA8EOjnVgpVvDuer7JJCsve?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f53d11b7-6720-4bd7-ba73-08db10fc3023
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2023 15:32:33.0695 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 87L3X+O0K0eBLWaEPKGWP3ibeGAqEXORq07wnAX/D1FqumRaf4lfylxik7unBuiw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6188
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2/17/2023 3:03 PM, Andrew Rybchenko wrote:
> On 2/17/23 16:41, Jiawei(Jonny) Wang wrote:
>> Hi Andrew,
>>
>>> -----Original Message-----
>>> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>> Sent: Friday, February 17, 2023 8:57 PM
>>> To: Jiawei(Jonny) Wang <jiaweiw@nvidia.com>; Slava Ovsiienko
>>> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU-Contact-
>>> Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>;
>>> ferruh.yigit@amd.com; Aman Singh <aman.deep.singh@intel.com>; Yuying
>>> Zhang <yuying.zhang@intel.com>
>>> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
>>> Subject: Re: [PATCH v6 1/2] ethdev: add Tx queue mapping of
>>> aggregated ports
>>>
>> [snip]
>>>> --- a/lib/ethdev/rte_ethdev.c
>>>> +++ b/lib/ethdev/rte_ethdev.c
>>>> @@ -6946,6 +6946,78 @@
>>> rte_eth_buffer_split_get_supported_hdr_ptypes(uint16_t port_id, uint32_t
>>> *ptypes
>>>>        return j;
>>>>    }
>>>>
>>>> +int rte_eth_dev_count_aggr_ports(uint16_t port_id) {
>>>> +    struct rte_eth_dev *dev;
>>>> +    int ret;
>>>> +
>>>> +    RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
>>>> +    dev = &rte_eth_devices[port_id];
>>>> +
>>>> +    if (*dev->dev_ops->count_aggr_ports == NULL)
>>>
>>> Is it OK that tracing is long in this case?
>>>
>>
>> Do you mean that we don't need tracing in this case?
> 
> Sorry for typo. I'm asking if it is OK that tracing is *lost* in this case.
> 

It is not black & white, but I think it is OK since there is no dev_ops
called.

Adding tracing here can make it unnecessary complex and for many cases
tracing is limited only to success path.

>>
>>>> +        return 0;
>>>> +    ret = eth_err(port_id,
>>>> (*dev->dev_ops->count_aggr_ports)(port_id));
>>>> +
>>>> +    rte_eth_trace_count_aggr_ports(port_id, ret);
>>>> +
>>>> +    return ret;
>>>> +}
>>>> +
>>>
>>> [snip]
>>
>