From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9CC2A0524; Fri, 5 Feb 2021 17:42:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3BA8E1887BD; Fri, 5 Feb 2021 17:42:57 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id 42DD1188715; Fri, 5 Feb 2021 17:42:55 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 87E745C0105; Fri, 5 Feb 2021 11:42:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 05 Feb 2021 11:42:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= OhdvtKFEbGVYP2y9oAMpb6mrCQyGk8sfMHdUJmYiMvw=; b=2N7T0hLREii/fjj3 r0OEXohHyilGACzcmi4IIoTFZvvlexjxYjk/Z0cnraqDXxluRkOCqVERlTHHNeHy sm/H3WDs/+Xk1A3u+dsjyprOClN9chxBMqvjE2oieHANpWrf6+qvoryYlih8b8+/ sUGk+d+vshe7HwH/Ezuo53LDvkhnmMJw5NPJ/WjWeTQIKaxzi+P22t/uj7uRSlNs K0aR+bDgM6IvYEpULDRG0VtPNxyMMDVNe/YtfNkOWqQvYXv7yqpu+aqjHYySplGO MxPS5DO2YF6O7+1MCGt5ZbPFz5Fsr9CEwwHiAzJlflP+4BS20PWT/UjujE/qsRko nnijWg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=OhdvtKFEbGVYP2y9oAMpb6mrCQyGk8sfMHdUJmYiM vw=; b=cXU25qsP5Hhc/PpZKNw3Q9WdieeU6zXXLp5cyNwPzyrWxg06ErE44N7bt hReQCYXKtCaJuwbtmsFKg+6p43ptdmkFDB2vzd5NFiCC3izbR/NoGBq4nq47ZFbj o4ssyMsWY9lMZF01RHrt2h5kFxCUWXYFgbcCvYWtp4QYApwNf41zM5Qc+wQsmEkD DVOuC1q8whdvYvCB2q7i5xadHtLiUEzwg6HmRa17tlJM14z/NDhXiV2NXSw6d9nd As/+PaaFHc+4Ev3mC9Pw8PksPkcL3StV/tixew3/MhfiBMnR1pQtQGXbbvCXbOiG Y+oXkqFl/4QKPC3NgpImhG2JXLmEA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrgeeigdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F0681080068; Fri, 5 Feb 2021 11:42:53 -0500 (EST) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, stable@dpdk.org, Andrew Rybchenko Date: Fri, 05 Feb 2021 17:42:51 +0100 Message-ID: <2156953.uCqoqdHMZK@thomas> In-Reply-To: <10d7ba83-0646-846b-c37f-3f752441e71e@oktetlabs.ru> References: <20210203090101.5669-1-olivier.matz@6wind.com> <10d7ba83-0646-846b-c37f-3f752441e71e@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mempool: fix invalid panic on dump or audit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/02/2021 14:33, Andrew Rybchenko: > On 2/3/21 12:01 PM, Olivier Matz wrote: > > When doing a mempool dump or an audit, the application can panic because > > the length of the cache is greater than the flush threshold, which is > > seen as a fatal error. But this can temporarily happen when the mempool > > is in use. > > > > Fix the panic condition to abort only when the cache length is greater > > than the array. > > > > Fixes: ea5dd2744b90 ("mempool: cache optimisations") > > Cc: stable@dpdk.org > > > > Signed-off-by: Olivier Matz > > Acked-by: Andrew Rybchenko Applied, thanks