From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id A307D7F79 for ; Sun, 16 Nov 2014 22:49:42 +0100 (CET) Received: by mail-wi0-f176.google.com with SMTP id ex7so4001173wid.9 for ; Sun, 16 Nov 2014 13:59:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=ehnMPUviRFrfeYUIkfHyazGAJfP2adz164VgxjkKZIc=; b=QCn0GQsqga1BhgvR/5muVQuOxiupZrS4/iaR1NMBsylfi9iyIhmhXUyAP6E0pGr0NA AkmpdK6jFMKoWtY9SqZUITLsivum3+5hjRQuOINqf+wPrmRr73FYkdhHU1EeTSKEhotL Otmwyqjtw+u0WGDbFbQkVEaa6zn9nSBCpTTVoURU5CGX8Yv1cUJgEStY/7EGl4QXMe3d dPRV+Zirt0nc+i/ebLrikoZfMv/ieWidByXuhfJxoeQ8oDpbCfEe+DCM8zy8iAEK5UPb DVEDIDneRQg0x4qgMU2d0yA7RujsQ16i+lvVxHNEaN6TORQmoHcN7h+Fk8msMHExvA+D BZSA== X-Gm-Message-State: ALoCoQmOKUZoeuj/5ajYEjzCYcdJjreR9lBsTZtLR8DWPuCi7zLOct4EOHuEBTDZrotL5Pycv7r4 X-Received: by 10.180.91.137 with SMTP id ce9mr26171251wib.60.1416175196361; Sun, 16 Nov 2014 13:59:56 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ga1sm12764187wib.1.2014.11.16.13.59.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Nov 2014 13:59:55 -0800 (PST) From: Thomas Monjalon To: "Pattan, Reshma" Date: Sun, 16 Nov 2014 22:59:34 +0100 Message-ID: <2157876.pGkxDz74i3@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.2-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <3AEA2BF9852C6F48A459DA490692831FE35F2D@IRSMSX109.ger.corp.intel.com> References: <1413554380-22809-1-git-send-email-reshma.pattan@intel.com> <2996275.IBF3pFpS8C@xps13> <3AEA2BF9852C6F48A459DA490692831FE35F2D@IRSMSX109.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7] distributor_app: new sample app X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 21:49:42 -0000 2014-11-14 08:44, Pattan, Reshma: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > From: Reshma Pattan > > > > > > > > A new sample app that shows the usage of the distributor library. > > > > This app works as follows: > > > > > > > > * An RX thread runs which pulls packets from each ethernet port in turn > > > > and passes those packets to worker using a distributor component. > > > > * The workers take the packets in turn, and determine the output port > > > > for those packets using basic l2forwarding doing an xor on the source > > > > port id. > > > > * The RX thread takes the returned packets from the workers and enqueue > > > > those packets into an rte_ring structure. > > > > * A TX thread pulls the packets off the rte_ring structure and then > > > > sends each packet out the output port specified previously by the > > > > worker > > > > * Command-line option support provided only for portmask. > > > > > > > > v5 change: > > > > * Handled gracefull shutdown of rx and tx threads upon SIGINT. > > > > > > > > v6 change: > > > > * modified graceful shutdown logic to handle all threads upon SIGINT > > > > * removed call to rte_eal_pci_probe() > > > > * added seperate print_stats function > > > > > > > > v7 change: > > > > * passing NULL as rxconf/txconf parameter for rx/tx queue setup > > > > * removed zero-ed fields from port conf structure > > > > * fixed style related comments > > > > > > > > > > > > Signed-off-by: Bruce Richardson > > > > Signed-off-by: Reshma Pattan > > > > > > Acked-by: Pablo de Lara > > > > Before applying this patch, I have 2 comments: > > - Other examples directories don't have _app suffix. > > - checkpatch reports "switch and case should be at the same indent" > > > > If you agree I will fix these 2 minor issues before applying. > > Fine with me. You can proceed. Applied Thanks -- Thomas